[GitHub] [inlong] GanfengTan commented on a diff in pull request #4844: [INLONG-4843][Manager] Add RPC URL for TubeMQ cluster

[GitBox <gi...@apache.org>]

GanfengTan commented on code in PR #4844:
URL: https://github.com/apache/inlong/pull/4844#discussion_r912374957


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/group/InlongGroupServiceImpl.java:
##########
@@ -355,8 +355,8 @@ public boolean updateAfterApprove(InlongGroupApproveRequest approveInfo, String
         Preconditions.checkNotNull(approveInfo, "inlong approve request cannot be empty");
         String groupId = approveInfo.getInlongGroupId();
         Preconditions.checkNotNull(groupId, ErrorCodeEnum.GROUP_ID_IS_EMPTY.getMessage());
-        String mqType = approveInfo.getMqType();
-        Preconditions.checkNotNull(mqType, "MQ type cannot be empty");
+        // String mqType = approveInfo.getMqType();

Review Comment:
   Has been modified.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org