You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "saurabhd336 (via GitHub)" <gi...@apache.org> on 2023/08/22 12:08:36 UTC

[GitHub] [pinot] saurabhd336 opened a new pull request, #11403: Fix RawStringDistinctExecutor integer overflow

saurabhd336 opened a new pull request, #11403:
URL: https://github.com/apache/pinot/pull/11403

   ```
   select DISTINCT(n_comment) from nation limit 10
   ```
   on tpc-h dataset fails on v2 engine due to integer overflow
   
   ```
   [
     {
       "errorCode": 200,
       "message": "QueryExecutionError:\njava.lang.RuntimeException: Error executing query: [0]@100.94.5.107:49954 MAIL_RECEIVE(RANDOM_DISTRIBUTED)\n└── [1]@localhost:49966 MAIL_SEND(RANDOM_DISTRIBUTED)->{[0]@100.94.5.107@{49954,49954}|[0]}\n   └── [1]@localhost:49966 AGGREGATE_FINAL\n      └── [1]@localhost:49966 MAIL_RECEIVE(HASH_DISTRIBUTED)\n         └── [2]@localhost:49966 MAIL_SEND(HASH_DISTRIBUTED)->{[1]@localhost@{49966,49967}|[0]}\n...\nCaused by: java.lang.RuntimeException: Received error query execution result block: {200=QueryExecutionError:\njava.lang.AssertionError\n\tat org.apache.pinot.core.query.distinct.raw.BaseRawStringSingleColumnDistinctExecutor.getResult(BaseRawStringSingleColumnDistinctExecutor.java:70)\n\tat org.apache.pinot.core.query.distinct.raw.RawStringSingleColumnDistinctOnlyExecutor.getResult(RawStringSingleColumnDistinctOnlyExecutor.java:29)\n\tat org.apache.pinot.core.operator.query.DistinctOperator.getNextBlock(DistinctOperato
 r.java:64)"
     }
   ]
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] Jackie-Jiang commented on pull request #11403: Fix RawStringDistinctExecutor integer overflow

Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on PR #11403:
URL: https://github.com/apache/pinot/pull/11403#issuecomment-1688690996

   @shenyu0127 This was supposed to be fixed within #10940, but introduced back in #10914. Let's be more careful next time :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] shenyu0127 commented on pull request #11403: Fix RawStringDistinctExecutor integer overflow

Posted by "shenyu0127 (via GitHub)" <gi...@apache.org>.
shenyu0127 commented on PR #11403:
URL: https://github.com/apache/pinot/pull/11403#issuecomment-1688895856

   @Jackie-Jiang Well noted!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] xiangfu0 merged pull request #11403: Fix RawStringDistinctExecutor integer overflow

Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 merged PR #11403:
URL: https://github.com/apache/pinot/pull/11403


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] codecov-commenter commented on pull request #11403: Fix RawStringDistinctExecutor integer overflow

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11403:
URL: https://github.com/apache/pinot/pull/11403#issuecomment-1688148980

   ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11403?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#11403](https://app.codecov.io/gh/apache/pinot/pull/11403?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0c3ddd5) into [master](https://app.codecov.io/gh/apache/pinot/commit/4a263ea7d91d5dfbddbf2731433680c5fd7bdb4d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (4a263ea) will **decrease** coverage by `48.30%`.
   > Report is 5 commits behind head on master.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #11403       +/-   ##
   =============================================
   - Coverage     62.81%   14.51%   -48.30%     
   + Complexity      207      201        -6     
   =============================================
     Files          2300     2301        +1     
     Lines        123622   123664       +42     
     Branches      18796    18798        +2     
   =============================================
   - Hits          77650    17948    -59702     
   - Misses        40448   104200    +63752     
   + Partials       5524     1516     -4008     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/pinot/pull/11403/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [integration](https://app.codecov.io/gh/apache/pinot/pull/11403/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [integration1](https://app.codecov.io/gh/apache/pinot/pull/11403/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [integration2](https://app.codecov.io/gh/apache/pinot/pull/11403/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [java-11](https://app.codecov.io/gh/apache/pinot/pull/11403/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `14.51% <0.00%> (-48.28%)` | :arrow_down: |
   | [java-17](https://app.codecov.io/gh/apache/pinot/pull/11403/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [java-20](https://app.codecov.io/gh/apache/pinot/pull/11403/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [temurin](https://app.codecov.io/gh/apache/pinot/pull/11403/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `14.51% <0.00%> (-48.30%)` | :arrow_down: |
   | [unittests](https://app.codecov.io/gh/apache/pinot/pull/11403/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `14.51% <0.00%> (-48.30%)` | :arrow_down: |
   | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/11403/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [unittests2](https://app.codecov.io/gh/apache/pinot/pull/11403/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `14.51% <0.00%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files Changed](https://app.codecov.io/gh/apache/pinot/pull/11403?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...BaseRawBigDecimalSingleColumnDistinctExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/11403?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvQmFzZVJhd0JpZ0RlY2ltYWxTaW5nbGVDb2x1bW5EaXN0aW5jdEV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (-93.94%)` | :arrow_down: |
   | [.../raw/BaseRawBytesSingleColumnDistinctExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/11403?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvQmFzZVJhd0J5dGVzU2luZ2xlQ29sdW1uRGlzdGluY3RFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (-87.88%)` | :arrow_down: |
   | [...raw/BaseRawStringSingleColumnDistinctExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/11403?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvQmFzZVJhd1N0cmluZ1NpbmdsZUNvbHVtbkRpc3RpbmN0RXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | :arrow_down: |
   
   ... and [1472 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/11403/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org