You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2023/02/01 14:24:11 UTC
[GitHub] [arrow-adbc] lidavidm opened a new pull request, #407: fix(go/adbc/driver/driver/flightsql): use libc allocator
lidavidm opened a new pull request, #407:
URL: https://github.com/apache/arrow-adbc/pull/407
This lets us pass cgocheck=2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on pull request #407: fix(go/adbc/driver/driver/flightsql): use libc allocator
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #407:
URL: https://github.com/apache/arrow-adbc/pull/407#issuecomment-1414104912
The defer is here, it's just hidden behind the other changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] zeroshade commented on pull request #407: fix(go/adbc/driver/driver/flightsql): use libc allocator
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #407:
URL: https://github.com/apache/arrow-adbc/pull/407#issuecomment-1412326548
Looks like we've got more leaks, i wonder if it's related to the `mallocator` or something else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on pull request #407: fix(go/adbc/driver/driver/flightsql): use libc allocator
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #407:
URL: https://github.com/apache/arrow-adbc/pull/407#issuecomment-1412851733
I'll dig into it tomorrow when I get a chance :sadpusheen:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on pull request #407: fix(go/adbc/driver/driver/flightsql): use libc allocator
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #407:
URL: https://github.com/apache/arrow-adbc/pull/407#issuecomment-1413765516
It was a Go side issue :)
```diff
--- a/go/adbc/driver/flightsql/flightsql_adbc.go
+++ b/go/adbc/driver/flightsql/flightsql_adbc.go
@@ -916,6 +916,7 @@ func (g *getObjects) release() {
func (g *getObjects) finish() (array.RecordReader, error) {
record := g.builder.NewRecord()
+ defer record.Release()
result, err := array.NewRecordReader(g.builder.Schema(), []arrow.Record{record})
if err != nil {
return nil, adbc.Error{
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm merged pull request #407: fix(go/adbc/driver/driver/flightsql): use libc allocator
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #407:
URL: https://github.com/apache/arrow-adbc/pull/407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on pull request #407: fix(go/adbc/driver/driver/flightsql): use libc allocator
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #407:
URL: https://github.com/apache/arrow-adbc/pull/407#issuecomment-1413903607
See #33999 for why we're explicitly copying strings now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] zeroshade commented on pull request #407: fix(go/adbc/driver/driver/flightsql): use libc allocator
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #407:
URL: https://github.com/apache/arrow-adbc/pull/407#issuecomment-1414072207
@lidavidm was adding that defer done in a different PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on pull request #407: fix(go/adbc/driver/driver/flightsql): use libc allocator
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #407:
URL: https://github.com/apache/arrow-adbc/pull/407#issuecomment-1413765768
But there are some other test failures that look legit, so digging into those now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org