You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:53:48 UTC

[GitHub] [spark] cloud-fan edited a comment on pull request #29244: [SPARK-20680][SQL][FOLLOW-UP] Make NullType.simpleString as void to support hive

cloud-fan edited a comment on pull request #29244:
URL: https://github.com/apache/spark/pull/29244#issuecomment-665038741


   Another safer fix is: In `HiveClientImpl.createTable`, replace `NullType` with a new `HiveVoidType` whose `simpleString` returns `void`, before generating the type string and create Hive `FieldSchema`.
   
   The question is: do we think `void` is a better type name than `null` when doing EXPLAIN?
   
   cc @dongjoon-hyun @maropu @viirya 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org