[GitHub] [trafficcontrol] rawlinp opened a new pull request #4389: [Backport 4.0.x] Fix atstccfg Delivery Service Server caching. (#4387)

[GitBox <gi...@apache.org>]

rawlinp opened a new pull request #4389: [Backport 4.0.x] Fix atstccfg Delivery Service Server caching. (#4387)
URL: https://github.com/apache/trafficcontrol/pull/4389
 
 
   Fixes atstccfg Delivery Service Server caching.
       
   Fixses an inconsistent ORT bug with files, noticably parent.config,
   not having all lines. Bug was filtering before saving the cache file.
   
   DSS gets everything, and then filters. It was filtering before saving
   the cache file, causing subsequent ORT calls under the cache age which
   had more DSSes to be missing them.
   
   This fixes it to filter after saving/loading the cache file, instead
   of before.
   
   Also adds a flag to ORT to disable caching. Caching is hard, and we've had similar bugs before. This will allow users to disable it in ORT without having to modify ORT (atstccfg already had a flag, it just wasn't exposed), which will reduce the severity of caching issues in the future.
   
   ORT doesn't have an Integration Test framework yet, and the bug requires TO requests to test. I've manually verified full ORT calls place the full config files, where without the fix parent.config is missing most values. Also manually verified the new ORT --use_cache flag works as expected, by running ORT and verifying cache usage in atstccfg log.
   No changelog, no docs, no interface change, and bug does not exist prior to 4.0.x.
   
   - [x] This PR is not related to any other Issue
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Ops ORT
   
   ## What is the best way to verify this PR?
   Run ORT, verify full files are placed, specifically parent.config. Run atstccfg for a mid header rewrite file (which will only request a single DS), inspect DSS cache file `deliveryservice_servers_s_d_.json` and verify it contains all DSes, not just 1.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   - master
   - 4.0.x
   
   
   ## The following criteria are ALL met by this PR
   
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   
   ## Additional Information

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rawlinp merged pull request #4389: [Backport 4.0.x] Fix atstccfg Delivery Service Server caching. (#4387)

[GitBox <gi...@apache.org>]

rawlinp merged pull request #4389: [Backport 4.0.x] Fix atstccfg Delivery Service Server caching. (#4387)
URL: https://github.com/apache/trafficcontrol/pull/4389
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services