[GitHub] cloudstack pull request: CLOUDSTACK-9182: Some running VMs turned ...

[alexandrelimassantana <gi...@git.apache.org>]

Github user alexandrelimassantana commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1252#discussion_r55169762
  
    --- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
    @@ -4468,6 +4472,16 @@ private boolean checkIfHostIsDedicated(HostVO host) {
             }
         }
     
    +    private void checkIfHostOfVMIsInPrepareForMaintenanceState(Long hostId, Long vmId, String operation) {
    --- End diff --
    
    Hello @sureshanaparti 
    
    I think this method can use a Javadoc. Since it's supposed to check something and doesn't return nothing, it might make someone have to open the code to check what does it do.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---