You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/17 07:01:25 UTC
[GitHub] [flink] docete opened a new pull request #10880: [FLINK-15469][SQL] Update UpsertStreamTableSink and RetractStreamTabl…
docete opened a new pull request #10880: [FLINK-15469][SQL] Update UpsertStreamTableSink and RetractStreamTabl…
URL: https://github.com/apache/flink/pull/10880
…eSink and related interface to new type system
## What is the purpose of the change
Currently UpsertStreamTableSink can only returns TypeInformation of the requested record, which can't support types with precision and scale, e.g. TIMESTAMP(p), DECIMAL(p,s).
This PR would deprecate the getRecordType API and adding a getRecordDataType API instead to return the data type of the requested record.
## Brief change log
- e0f8cdb Update UpsertStreamTableSink and RetractStreamTableSink and related interface to new type system
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10880: [FLINK-15469][SQL] Update UpsertStreamTableSink and RetractStreamTabl…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10880: [FLINK-15469][SQL] Update UpsertStreamTableSink and RetractStreamTabl…
URL: https://github.com/apache/flink/pull/10880#issuecomment-575512352
<!--
Meta data
Hash:e0f8cdbe764bc1f9687e862467088de1ce260780 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144892323 TriggerType:PUSH TriggerID:e0f8cdbe764bc1f9687e862467088de1ce260780
Hash:e0f8cdbe764bc1f9687e862467088de1ce260780 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4422 TriggerType:PUSH TriggerID:e0f8cdbe764bc1f9687e862467088de1ce260780
-->
## CI report:
* e0f8cdbe764bc1f9687e862467088de1ce260780 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144892323) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4422)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10880: [FLINK-15469][SQL] Update UpsertStreamTableSink and RetractStreamTabl…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10880: [FLINK-15469][SQL] Update UpsertStreamTableSink and RetractStreamTabl…
URL: https://github.com/apache/flink/pull/10880#issuecomment-575512352
<!--
Meta data
Hash:e0f8cdbe764bc1f9687e862467088de1ce260780 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:e0f8cdbe764bc1f9687e862467088de1ce260780
-->
## CI report:
* e0f8cdbe764bc1f9687e862467088de1ce260780 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10880: [FLINK-15469][SQL] Update UpsertStreamTableSink and RetractStreamTabl…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10880: [FLINK-15469][SQL] Update UpsertStreamTableSink and RetractStreamTabl…
URL: https://github.com/apache/flink/pull/10880#issuecomment-575512352
<!--
Meta data
Hash:e0f8cdbe764bc1f9687e862467088de1ce260780 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144892323 TriggerType:PUSH TriggerID:e0f8cdbe764bc1f9687e862467088de1ce260780
Hash:e0f8cdbe764bc1f9687e862467088de1ce260780 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4422 TriggerType:PUSH TriggerID:e0f8cdbe764bc1f9687e862467088de1ce260780
-->
## CI report:
* e0f8cdbe764bc1f9687e862467088de1ce260780 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144892323) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4422)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10880: [FLINK-15469][SQL] Update UpsertStreamTableSink and RetractStreamTabl…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10880: [FLINK-15469][SQL] Update UpsertStreamTableSink and RetractStreamTabl…
URL: https://github.com/apache/flink/pull/10880#issuecomment-575512352
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0f8cdbe764bc1f9687e862467088de1ce260780",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/144892323",
"triggerID" : "e0f8cdbe764bc1f9687e862467088de1ce260780",
"triggerType" : "PUSH"
}, {
"hash" : "e0f8cdbe764bc1f9687e862467088de1ce260780",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4422",
"triggerID" : "e0f8cdbe764bc1f9687e862467088de1ce260780",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0f8cdbe764bc1f9687e862467088de1ce260780 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144892323) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4422)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10880: [FLINK-15469][SQL] Update UpsertStreamTableSink and RetractStreamTabl…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10880: [FLINK-15469][SQL] Update UpsertStreamTableSink and RetractStreamTabl…
URL: https://github.com/apache/flink/pull/10880#issuecomment-575502134
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit e0f8cdbe764bc1f9687e862467088de1ce260780 (Fri Jan 17 07:04:36 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15469).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services