You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Julian Reschke (Jira)" <ji...@apache.org> on 2019/09/13 13:22:00 UTC

[jira] [Commented] (OAK-8624) oak-run: tests leak mapd temp files

    [ https://issues.apache.org/jira/browse/OAK-8624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16929187#comment-16929187 ] 

Julian Reschke commented on OAK-8624:
-------------------------------------

Proposed change:  [^OAK-8624.diff] 

> oak-run: tests leak mapd temp files
> -----------------------------------
>
>                 Key: OAK-8624
>                 URL: https://issues.apache.org/jira/browse/OAK-8624
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: run
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Major
>         Attachments: OAK-8624.diff
>
>
> This is because {{MapDBMapFactory}} is backed by temporary DB, but that one is never closed.
> Fix:
> - make it {{closeable}}
> - adapt test case and use in {{RecoveryCommand}}
> However, {{RecoveryCommand}} sets the {{MapFactory}} instance globally, and never resets it. Thus, if the factory is indeed closed, subsequent tests will fail. So, in {{RecoveryCommand}}, restore the default factory when done.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)