You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/07/06 07:07:30 UTC
[GitHub] [flink] twalthr opened a new pull request #16386: [FLINK-22879][table] Remove "blink" suffix from table modules
twalthr opened a new pull request #16386:
URL: https://github.com/apache/flink/pull/16386
## What is the purpose of the change
This removes the `blink` suffix from all table modules and artifacts. The API itself is not affected by this change, however, it will cause to adjust dependencies for some users.
This PR is based on #16374.
## Brief change log
See commit messages.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): yes
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #16386: [FLINK-22879][table] Remove "blink" suffix from table modules
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #16386:
URL: https://github.com/apache/flink/pull/16386#discussion_r664335131
##########
File path: docs/content/docs/dev/table/sql/set.md
##########
@@ -43,11 +43,11 @@ The following examples show how to run a `SET` statement in SQL CLI.
{{< tabs "set" >}}
{{< tab "SQL CLI" >}}
```sql
-Flink SQL> SET 'table.planner' = 'blink';
+Flink SQL> SET 'table.local-time-zone' = 'Europe/Berlin';
[INFO] Session property has been set.
Flink SQL> SET;
-'table.planner' = 'blink'
+'table.planner' = 'Europe/Berlin'
Review comment:
`'table.local-time-zone' = 'Europe/Berlin'`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16386: [FLINK-22879][table] Remove "blink" suffix from table modules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16386:
URL: https://github.com/apache/flink/pull/16386#issuecomment-874546325
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e6e3882a156d1946a898b813354143f905ea05e1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19973",
"triggerID" : "e6e3882a156d1946a898b813354143f905ea05e1",
"triggerType" : "PUSH"
}, {
"hash" : "556663a37adefce4998c750f992b920e4fb285ef",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "556663a37adefce4998c750f992b920e4fb285ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e6e3882a156d1946a898b813354143f905ea05e1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19973)
* 556663a37adefce4998c750f992b920e4fb285ef UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on pull request #16386: [FLINK-22879][table] Remove "blink" suffix from table modules
Posted by GitBox <gi...@apache.org>.
twalthr commented on pull request #16386:
URL: https://github.com/apache/flink/pull/16386#issuecomment-874516543
@wuchong this causes a lot of merge conflicts, a quick review would be appreciated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16386: [FLINK-22879][table] Remove "blink" suffix from table modules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16386:
URL: https://github.com/apache/flink/pull/16386#issuecomment-874546325
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e6e3882a156d1946a898b813354143f905ea05e1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19973",
"triggerID" : "e6e3882a156d1946a898b813354143f905ea05e1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e6e3882a156d1946a898b813354143f905ea05e1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19973)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16386: [FLINK-22879][table] Remove "blink" suffix from table modules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16386:
URL: https://github.com/apache/flink/pull/16386#issuecomment-874546325
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e6e3882a156d1946a898b813354143f905ea05e1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19973",
"triggerID" : "e6e3882a156d1946a898b813354143f905ea05e1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e6e3882a156d1946a898b813354143f905ea05e1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19973)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on pull request #16386: [FLINK-22879][table] Remove "blink" suffix from table modules
Posted by GitBox <gi...@apache.org>.
twalthr commented on pull request #16386:
URL: https://github.com/apache/flink/pull/16386#issuecomment-874516543
@wuchong this causes a lot of merge conflicts, a quick review would be appreciated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16386: [FLINK-22879][table] Remove "blink" suffix from table modules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16386:
URL: https://github.com/apache/flink/pull/16386#issuecomment-874546325
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e6e3882a156d1946a898b813354143f905ea05e1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19973",
"triggerID" : "e6e3882a156d1946a898b813354143f905ea05e1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e6e3882a156d1946a898b813354143f905ea05e1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19973)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16386: [FLINK-22879][table] Remove "blink" suffix from table modules
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16386:
URL: https://github.com/apache/flink/pull/16386#issuecomment-874531812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16386: [FLINK-22879][table] Remove "blink" suffix from table modules
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16386:
URL: https://github.com/apache/flink/pull/16386#issuecomment-874546325
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e6e3882a156d1946a898b813354143f905ea05e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e6e3882a156d1946a898b813354143f905ea05e1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e6e3882a156d1946a898b813354143f905ea05e1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16386: [FLINK-22879][table] Remove "blink" suffix from table modules
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16386:
URL: https://github.com/apache/flink/pull/16386#issuecomment-874531812
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit e6e3882a156d1946a898b813354143f905ea05e1 (Tue Jul 06 07:34:50 UTC 2021)
**Warnings:**
* **28 pom.xml files were touched**: Check for build and licensing issues.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16386: [FLINK-22879][table] Remove "blink" suffix from table modules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16386:
URL: https://github.com/apache/flink/pull/16386#issuecomment-874531812
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 0c23715917e0025b41ed119a83c1bee8dfe1bc6b (Thu Sep 23 17:58:23 UTC 2021)
**Warnings:**
* **27 pom.xml files were touched**: Check for build and licensing issues.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16386: [FLINK-22879][table] Remove "blink" suffix from table modules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16386:
URL: https://github.com/apache/flink/pull/16386#issuecomment-874546325
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e6e3882a156d1946a898b813354143f905ea05e1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19973",
"triggerID" : "e6e3882a156d1946a898b813354143f905ea05e1",
"triggerType" : "PUSH"
}, {
"hash" : "556663a37adefce4998c750f992b920e4fb285ef",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "556663a37adefce4998c750f992b920e4fb285ef",
"triggerType" : "PUSH"
}, {
"hash" : "0c23715917e0025b41ed119a83c1bee8dfe1bc6b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0c23715917e0025b41ed119a83c1bee8dfe1bc6b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e6e3882a156d1946a898b813354143f905ea05e1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19973)
* 556663a37adefce4998c750f992b920e4fb285ef UNKNOWN
* 0c23715917e0025b41ed119a83c1bee8dfe1bc6b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #16386: [FLINK-22879][table] Remove "blink" suffix from table modules
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #16386:
URL: https://github.com/apache/flink/pull/16386#discussion_r664335131
##########
File path: docs/content/docs/dev/table/sql/set.md
##########
@@ -43,11 +43,11 @@ The following examples show how to run a `SET` statement in SQL CLI.
{{< tabs "set" >}}
{{< tab "SQL CLI" >}}
```sql
-Flink SQL> SET 'table.planner' = 'blink';
+Flink SQL> SET 'table.local-time-zone' = 'Europe/Berlin';
[INFO] Session property has been set.
Flink SQL> SET;
-'table.planner' = 'blink'
+'table.planner' = 'Europe/Berlin'
Review comment:
`'table.local-time-zone' = 'Europe/Berlin'`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #16386: [FLINK-22879][table] Remove "blink" suffix from table modules
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #16386:
URL: https://github.com/apache/flink/pull/16386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on pull request #16386: [FLINK-22879][table] Remove "blink" suffix from table modules
Posted by GitBox <gi...@apache.org>.
twalthr commented on pull request #16386:
URL: https://github.com/apache/flink/pull/16386#issuecomment-874842465
Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16386: [FLINK-22879][table] Remove "blink" suffix from table modules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16386:
URL: https://github.com/apache/flink/pull/16386#issuecomment-874546325
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e6e3882a156d1946a898b813354143f905ea05e1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19973",
"triggerID" : "e6e3882a156d1946a898b813354143f905ea05e1",
"triggerType" : "PUSH"
}, {
"hash" : "556663a37adefce4998c750f992b920e4fb285ef",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "556663a37adefce4998c750f992b920e4fb285ef",
"triggerType" : "PUSH"
}, {
"hash" : "0c23715917e0025b41ed119a83c1bee8dfe1bc6b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20001",
"triggerID" : "0c23715917e0025b41ed119a83c1bee8dfe1bc6b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e6e3882a156d1946a898b813354143f905ea05e1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19973)
* 556663a37adefce4998c750f992b920e4fb285ef UNKNOWN
* 0c23715917e0025b41ed119a83c1bee8dfe1bc6b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20001)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org