You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by "nanonyme (via GitHub)" <gi...@apache.org> on 2023/03/25 20:45:10 UTC

[GitHub] [buildstream] nanonyme opened a new pull request, #1836: Use urlretrieve

nanonyme opened a new pull request, #1836:
URL: https://github.com/apache/buildstream/pull/1836

   Fixes https://github.com/apache/buildstream/issues/1835


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [buildstream] nanonyme commented on pull request #1836: Use urlretrieve

Posted by "nanonyme (via GitHub)" <gi...@apache.org>.
nanonyme commented on PR #1836:
URL: https://github.com/apache/buildstream/pull/1836#issuecomment-1483925489

   This cannot work indeed. I have filed feature request for this against CPython since it's a useful thing for urlretrieve but BuildStream cannot assume that exists.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [buildstream] nanonyme closed pull request #1836: Use urlretrieve

Posted by "nanonyme (via GitHub)" <gi...@apache.org>.
nanonyme closed pull request #1836: Use urlretrieve
URL: https://github.com/apache/buildstream/pull/1836


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [buildstream] nanonyme commented on pull request #1836: Use urlretrieve

Posted by "nanonyme (via GitHub)" <gi...@apache.org>.
nanonyme commented on PR #1836:
URL: https://github.com/apache/buildstream/pull/1836#issuecomment-1483923864

   I'm not entirely sure if this can work. Looks possible the API does not in fact support passing request which would mean we can't use it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org