You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/06/07 16:58:15 UTC

[GitHub] [calcite] laurentgo commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

laurentgo commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter
URL: https://github.com/apache/calcite/pull/1030#discussion_r291675197
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rel/rules/MultiJoinProjectTransposeRule.java
 ##########
 @@ -128,7 +129,7 @@ protected LogicalProject getRightChild(RelOptRuleCall call) {
   // override JoinProjectTransposeRule
 
 Review comment:
   I'd happy to post a patch to fix it: I think @siddharthteotia has been really patient, so let's not abuse his time

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services