You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by rw...@apache.org on 2008/04/06 22:30:16 UTC
svn commit: r645300 - in /commons/proper/net/trunk/src:
java/org/apache/commons/net/ftp/parser/
test/org/apache/commons/net/ftp/parser/
Author: rwinston
Date: Sun Apr 6 13:30:14 2008
New Revision: 645300
URL: http://svn.apache.org/viewvc?rev=645300&view=rev
Log:
Add Sebbs patch
Modified:
commons/proper/net/trunk/src/java/org/apache/commons/net/ftp/parser/NTFTPEntryParser.java
commons/proper/net/trunk/src/java/org/apache/commons/net/ftp/parser/NetwareFTPEntryParser.java
commons/proper/net/trunk/src/java/org/apache/commons/net/ftp/parser/OS2FTPEntryParser.java
commons/proper/net/trunk/src/java/org/apache/commons/net/ftp/parser/OS400FTPEntryParser.java
commons/proper/net/trunk/src/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParser.java
commons/proper/net/trunk/src/java/org/apache/commons/net/ftp/parser/VMSFTPEntryParser.java
commons/proper/net/trunk/src/test/org/apache/commons/net/ftp/parser/CompositeFTPParseTestFramework.java
commons/proper/net/trunk/src/test/org/apache/commons/net/ftp/parser/FTPParseTestFramework.java
Modified: commons/proper/net/trunk/src/java/org/apache/commons/net/ftp/parser/NTFTPEntryParser.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/java/org/apache/commons/net/ftp/parser/NTFTPEntryParser.java?rev=645300&r1=645299&r2=645300&view=diff
==============================================================================
--- commons/proper/net/trunk/src/java/org/apache/commons/net/ftp/parser/NTFTPEntryParser.java (original)
+++ commons/proper/net/trunk/src/java/org/apache/commons/net/ftp/parser/NTFTPEntryParser.java Sun Apr 6 13:30:14 2008
@@ -101,7 +101,7 @@
}
catch (ParseException e)
{
- return null; // this is a parsing failure too.
+ // intentionally do nothing
}
if (null == name || name.equals(".") || name.equals(".."))
Modified: commons/proper/net/trunk/src/java/org/apache/commons/net/ftp/parser/NetwareFTPEntryParser.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/java/org/apache/commons/net/ftp/parser/NetwareFTPEntryParser.java?rev=645300&r1=645299&r2=645300&view=diff
==============================================================================
--- commons/proper/net/trunk/src/java/org/apache/commons/net/ftp/parser/NetwareFTPEntryParser.java (original)
+++ commons/proper/net/trunk/src/java/org/apache/commons/net/ftp/parser/NetwareFTPEntryParser.java Sun Apr 6 13:30:14 2008
@@ -122,7 +122,7 @@
try {
f.setTimestamp(super.parseTimestamp(datestr));
} catch (ParseException e) {
- return null; // this is a parsing failure too.
+ // intentionally do nothing
}
//is it a DIR or a file
Modified: commons/proper/net/trunk/src/java/org/apache/commons/net/ftp/parser/OS2FTPEntryParser.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/java/org/apache/commons/net/ftp/parser/OS2FTPEntryParser.java?rev=645300&r1=645299&r2=645300&view=diff
==============================================================================
--- commons/proper/net/trunk/src/java/org/apache/commons/net/ftp/parser/OS2FTPEntryParser.java (original)
+++ commons/proper/net/trunk/src/java/org/apache/commons/net/ftp/parser/OS2FTPEntryParser.java Sun Apr 6 13:30:14 2008
@@ -102,7 +102,7 @@
}
catch (ParseException e)
{
- return null; // this is a parsing failure too.
+ // intentionally do nothing
}
Modified: commons/proper/net/trunk/src/java/org/apache/commons/net/ftp/parser/OS400FTPEntryParser.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/java/org/apache/commons/net/ftp/parser/OS400FTPEntryParser.java?rev=645300&r1=645299&r2=645300&view=diff
==============================================================================
--- commons/proper/net/trunk/src/java/org/apache/commons/net/ftp/parser/OS400FTPEntryParser.java (original)
+++ commons/proper/net/trunk/src/java/org/apache/commons/net/ftp/parser/OS400FTPEntryParser.java Sun Apr 6 13:30:14 2008
@@ -93,7 +93,7 @@
}
catch (ParseException e)
{
- return null; // this is a parsing failure too.
+ // intentionally do nothing
}
Modified: commons/proper/net/trunk/src/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParser.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParser.java?rev=645300&r1=645299&r2=645300&view=diff
==============================================================================
--- commons/proper/net/trunk/src/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParser.java (original)
+++ commons/proper/net/trunk/src/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParser.java Sun Apr 6 13:30:14 2008
@@ -172,7 +172,7 @@
}
catch (ParseException e)
{
- return null; // this is a parsing failure too.
+ // intentionally do nothing
}
Modified: commons/proper/net/trunk/src/java/org/apache/commons/net/ftp/parser/VMSFTPEntryParser.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/java/org/apache/commons/net/ftp/parser/VMSFTPEntryParser.java?rev=645300&r1=645299&r2=645300&view=diff
==============================================================================
--- commons/proper/net/trunk/src/java/org/apache/commons/net/ftp/parser/VMSFTPEntryParser.java (original)
+++ commons/proper/net/trunk/src/java/org/apache/commons/net/ftp/parser/VMSFTPEntryParser.java Sun Apr 6 13:30:14 2008
@@ -149,7 +149,7 @@
}
catch (ParseException e)
{
- return null; // this is a parsing failure too.
+ // intentionally do nothing
}
Modified: commons/proper/net/trunk/src/test/org/apache/commons/net/ftp/parser/CompositeFTPParseTestFramework.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/test/org/apache/commons/net/ftp/parser/CompositeFTPParseTestFramework.java?rev=645300&r1=645299&r2=645300&view=diff
==============================================================================
--- commons/proper/net/trunk/src/test/org/apache/commons/net/ftp/parser/CompositeFTPParseTestFramework.java (original)
+++ commons/proper/net/trunk/src/test/org/apache/commons/net/ftp/parser/CompositeFTPParseTestFramework.java Sun Apr 6 13:30:14 2008
@@ -104,7 +104,7 @@
String test = badsamples[i][j];
FTPFile f = parser.parseFTPEntry(test);
assertNull("Should have Failed to parse " + test,
- f);
+ nullFileOrNullDate(f));
doAdditionalBadTests(test, f);
}
Modified: commons/proper/net/trunk/src/test/org/apache/commons/net/ftp/parser/FTPParseTestFramework.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/test/org/apache/commons/net/ftp/parser/FTPParseTestFramework.java?rev=645300&r1=645299&r2=645300&view=diff
==============================================================================
--- commons/proper/net/trunk/src/test/org/apache/commons/net/ftp/parser/FTPParseTestFramework.java (original)
+++ commons/proper/net/trunk/src/test/org/apache/commons/net/ftp/parser/FTPParseTestFramework.java Sun Apr 6 13:30:14 2008
@@ -54,7 +54,7 @@
String test = badsamples[i];
FTPFile f = parser.parseFTPEntry(test);
assertNull("Should have Failed to parse " + test,
- f);
+ nullFileOrNullDate(f));
doAdditionalBadTests(test, f);
}
@@ -144,5 +144,21 @@
super.setUp();
parser = getParser();
df = new SimpleDateFormat("EEE MMM dd HH:mm:ss yyyy", Locale.US);
+ }
+
+ /**
+ * Check if FTPFile entry parsing failed; i.e. if entry is null or date is null.
+ *
+ * @param f FTPFile entry - may be null
+ * @return null if f is null or the date is null
+ */
+ protected FTPFile nullFileOrNullDate(FTPFile f) {
+ if (f==null){
+ return null;
+ }
+ if (f.getTimestamp() == null){
+ return null;
+ }
+ return f;
}
}