You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by tiodollar <gi...@git.apache.org> on 2017/06/29 15:11:10 UTC
[GitHub] storm pull request #2181: [STORM-2607] Offset consumer + 1
GitHub user tiodollar opened a pull request:
https://github.com/apache/storm/pull/2181
[STORM-2607] Offset consumer + 1
When i put a message a partition, the storm-kafka-client consume this message.
But storm-kafka-client commit the offset -1.
storm-kafka-client: 1.1.0
storm-core : 1.1.0
kafka: 0.10.2.0
Steps to bug
#1 - Insert message in kafka
#2 - Read with storm Spout this topic
#3 - Get the offset for the consumer group and the offset is always offset -1
https://issues.apache.org/jira/browse/STORM-2607
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tiodollar/storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2181.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2181
----
commit 34ffb9562374ddd0c1c0c12834a7ae03d7e7cbab
Author: Rodolfo Ribeiro <ro...@b2wdigital.com>
Date: 2017-06-29T15:06:20Z
[STORM-2607] Offset consumer + 1
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2181: [STORM-2607] Offset consumer + 1
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2181
@tiodollar Please let me know if you're having trouble resolving the conflicts. I'd be happy to help.
---
[GitHub] storm pull request #2181: [STORM-2607] Offset consumer + 1
Posted by tiodollar <gi...@git.apache.org>.
Github user tiodollar commented on a diff in the pull request:
https://github.com/apache/storm/pull/2181#discussion_r125533409
--- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/OffsetManager.java ---
@@ -96,31 +98,34 @@ public OffsetAndMetadata findNextCommitOffset() {
the next logical point in the topic. Next logical offset should be the
first element after committedOffset in the ascending ordered emitted set.
*/
- LOG.debug("Processed non contiguous offset."
- + " (committedOffset+1) is no longer part of the topic."
- + " Committed: [{}], Processed: [{}]", committedOffset, currOffset);
- final Long nextEmittedOffset = emittedOffsets.ceiling(nextCommitOffset);
+ LOG.debug("Processed non-contiguous offset."
+ + " The earliest uncommitted offset is no longer part of the topic."
+ + " Missing uncommitted offset: [{}], Processed: [{}]", nextEarliestUncommittedOffset, currOffset);
+ final Long nextEmittedOffset = emittedOffsets.ceiling(nextEarliestUncommittedOffset);
if (nextEmittedOffset != null && currOffset == nextEmittedOffset) {
+ LOG.debug("Found committable offset: [{}] after missing offset: [{}], skipping to the committable offset",
+ currOffset, nextEarliestUncommittedOffset);
nextCommitMsg = currAckedMsg;
- nextCommitOffset = currOffset;
+ nextEarliestUncommittedOffset = currOffset + 1;
} else {
- LOG.debug("topic-partition [{}] has non-continuous offset [{}]."
- + " Next Offset to commit should be [{}]", tp, currOffset, nextEmittedOffset);
+ LOG.debug("topic-partition [{}] has non-contiguous offset [{}]."
+ + " Next Offset to commit should be [{}]", tp, currOffset, nextEarliestUncommittedOffset - 1);
break;
}
}
} else {
//Received a redundant ack. Ignore and continue processing.
- LOG.warn("topic-partition [{}] has unexpected offset [{}]. Current committed Offset [{}]",
- tp, currOffset, committedOffset);
+ LOG.warn("topic-partition [{}] has unexpected offset [{}]. Current earliest uncommitted offset [{}]",
+ tp, currOffset, earliestUncommittedOffset);
}
}
OffsetAndMetadata nextCommitOffsetAndMetadata = null;
if (nextCommitMsg != null) {
- nextCommitOffsetAndMetadata = new OffsetAndMetadata(nextCommitOffset, nextCommitMsg.getMetadata(Thread.currentThread()));
+ nextCommitOffsetAndMetadata = new OffsetAndMetadata(nextEarliestUncommittedOffset,
+ nextCommitMsg.getMetadata(Thread.currentThread()));
LOG.debug("topic-partition [{}] has offsets [{}-{}] ready to be committed",
- tp, committedOffset + 1, nextCommitOffsetAndMetadata.offset());
+ tp, earliestUncommittedOffset, nextCommitOffsetAndMetadata.offset());
--- End diff --
@srdo I corrected that!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2181: [STORM-2607] Offset consumer + 1
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2181
Anyone could take this over since this PR looks like inactive.
Please keep in mind that you are encouraged to preserve @tiodollar commits with keeping authorship. Also encouraged to squash commits into one, and add your commits if needed.
---
[GitHub] storm issue #2181: [STORM-2607] Offset consumer + 1
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2181
@tiodollar Happy to hear it :)
---
[GitHub] storm issue #2181: [STORM-2607] Offset consumer + 1
Posted by Chandan83 <gi...@git.apache.org>.
Github user Chandan83 commented on the issue:
https://github.com/apache/storm/pull/2181
@tiodollar Great. Thanks.
---
[GitHub] storm pull request #2181: [STORM-2607] Offset consumer + 1
Posted by tiodollar <gi...@git.apache.org>.
Github user tiodollar commented on a diff in the pull request:
https://github.com/apache/storm/pull/2181#discussion_r124927995
--- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/OffsetManager.java ---
@@ -162,7 +164,7 @@ public long commit(OffsetAndMetadata committedOffset) {
LOG.debug("Committed offsets [{}-{} = {}] for topic-partition [{}].",
preCommitCommittedOffsets + 1, this.committedOffset, numCommittedOffsets, tp);
- return numCommittedOffsets;
+ return numCommittedOffsets - 1;// The committed offset should be the next message
--- End diff --
@srdo Ok!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2181: [STORM-2607] Offset consumer + 1
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2181
@tiodollar Any updates?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2181: [STORM-2607] Offset consumer + 1
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2181#discussion_r124906648
--- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/OffsetManager.java ---
@@ -162,7 +164,7 @@ public long commit(OffsetAndMetadata committedOffset) {
LOG.debug("Committed offsets [{}-{} = {}] for topic-partition [{}].",
preCommitCommittedOffsets + 1, this.committedOffset, numCommittedOffsets, tp);
- return numCommittedOffsets;
+ return numCommittedOffsets - 1;// The committed offset should be the next message
--- End diff --
Please fix this in L144 instead, so the log messages above print the right number as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2181: [STORM-2607] Offset consumer + 1
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2181
We should also remove the +1 here I think https://github.com/tiodollar/storm/blob/da7f49b94502914af769d7f40929bd54d3fae865/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java#L201
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2181: [STORM-2607] Offset consumer + 1
Posted by tiodollar <gi...@git.apache.org>.
Github user tiodollar commented on the issue:
https://github.com/apache/storm/pull/2181
@srdo i'll fix this! Tks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2181: [STORM-2607] Offset consumer + 1
Posted by tiodollar <gi...@git.apache.org>.
Github user tiodollar commented on the issue:
https://github.com/apache/storm/pull/2181
@srdo i'll resolve this issue today! I have been busy, but i reseved some hour to do this.
---
[GitHub] storm pull request #2181: [STORM-2607] Offset consumer + 1
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2181#discussion_r125522989
--- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/OffsetManager.java ---
@@ -96,31 +98,34 @@ public OffsetAndMetadata findNextCommitOffset() {
the next logical point in the topic. Next logical offset should be the
first element after committedOffset in the ascending ordered emitted set.
*/
- LOG.debug("Processed non contiguous offset."
- + " (committedOffset+1) is no longer part of the topic."
- + " Committed: [{}], Processed: [{}]", committedOffset, currOffset);
- final Long nextEmittedOffset = emittedOffsets.ceiling(nextCommitOffset);
+ LOG.debug("Processed non-contiguous offset."
+ + " The earliest uncommitted offset is no longer part of the topic."
+ + " Missing uncommitted offset: [{}], Processed: [{}]", nextEarliestUncommittedOffset, currOffset);
+ final Long nextEmittedOffset = emittedOffsets.ceiling(nextEarliestUncommittedOffset);
if (nextEmittedOffset != null && currOffset == nextEmittedOffset) {
+ LOG.debug("Found committable offset: [{}] after missing offset: [{}], skipping to the committable offset",
+ currOffset, nextEarliestUncommittedOffset);
nextCommitMsg = currAckedMsg;
- nextCommitOffset = currOffset;
+ nextEarliestUncommittedOffset = currOffset + 1;
} else {
- LOG.debug("topic-partition [{}] has non-continuous offset [{}]."
- + " Next Offset to commit should be [{}]", tp, currOffset, nextEmittedOffset);
+ LOG.debug("topic-partition [{}] has non-contiguous offset [{}]."
+ + " Next Offset to commit should be [{}]", tp, currOffset, nextEarliestUncommittedOffset - 1);
break;
}
}
} else {
//Received a redundant ack. Ignore and continue processing.
- LOG.warn("topic-partition [{}] has unexpected offset [{}]. Current committed Offset [{}]",
- tp, currOffset, committedOffset);
+ LOG.warn("topic-partition [{}] has unexpected offset [{}]. Current earliest uncommitted offset [{}]",
+ tp, currOffset, earliestUncommittedOffset);
}
}
OffsetAndMetadata nextCommitOffsetAndMetadata = null;
if (nextCommitMsg != null) {
- nextCommitOffsetAndMetadata = new OffsetAndMetadata(nextCommitOffset, nextCommitMsg.getMetadata(Thread.currentThread()));
+ nextCommitOffsetAndMetadata = new OffsetAndMetadata(nextEarliestUncommittedOffset,
+ nextCommitMsg.getMetadata(Thread.currentThread()));
LOG.debug("topic-partition [{}] has offsets [{}-{}] ready to be committed",
- tp, committedOffset + 1, nextCommitOffsetAndMetadata.offset());
+ tp, earliestUncommittedOffset, nextCommitOffsetAndMetadata.offset());
--- End diff --
Whoops, missed a -1 here. It should be nextCommitOffsetAndMetadata.offset() - 1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2181: [STORM-2607] Offset consumer + 1
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2181
@tiodollar Since there is still a conflict here, and we'd like this to go in 1.1.2 which we hope to release before too long, I've resolved the conflicts and addressed the review comments. There's a PR with the full set of changes here https://github.com/apache/storm/pull/2367. Note that your commits are still present, so you should still be credited with the fix.
Let me know if this is not okay with you.
---
[GitHub] storm issue #2181: [STORM-2607] Offset consumer + 1
Posted by tiodollar <gi...@git.apache.org>.
Github user tiodollar commented on the issue:
https://github.com/apache/storm/pull/2181
@srdo tks for this! I'm very busy, and is better that! For me it's ok!
---
[GitHub] storm pull request #2181: [STORM-2607] Offset consumer + 1
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2181#discussion_r124906681
--- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/OffsetManager.java ---
@@ -118,6 +118,8 @@ public OffsetAndMetadata findNextCommitOffset() {
OffsetAndMetadata nextCommitOffsetAndMetadata = null;
if (nextCommitMsg != null) {
+ //The committed offset should be the next message
+ nextCommitOffset = nextCommitOffset + 1;
--- End diff --
I would prefer that we fix the offsets in the code block above (L76-117) instead of adjusting the offset here. That way the log messages won't be printing the wrong offset.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2181: [STORM-2607] Offset consumer + 1
Posted by tiodollar <gi...@git.apache.org>.
Github user tiodollar commented on the issue:
https://github.com/apache/storm/pull/2181
@srdo I'll take look, and try fixing this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2181: [STORM-2607] Offset consumer + 1
Posted by Chandan83 <gi...@git.apache.org>.
Github user Chandan83 commented on the issue:
https://github.com/apache/storm/pull/2181
@srdo I have created an apache jira account with id ChandanKrSingh. Please assign the issue to me.
---
[GitHub] storm issue #2181: [STORM-2607] Offset consumer + 1
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2181
Yes, we should get this in soon if @tiodollar is busy. @Chandan83 if you'd like to work on this please create an account at https://issues.apache.org/jira and let us know, so we can assign the issue to you.
With regard to squashing, I think it should be possible to squash the existing commits into one for @tiodollar's commits and one for mine and preserve authorship information that way.
---
[GitHub] storm issue #2181: [STORM-2607] Offset consumer + 1
Posted by tiodollar <gi...@git.apache.org>.
Github user tiodollar commented on the issue:
https://github.com/apache/storm/pull/2181
@HeartSaVioR i'll fix this merge today!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2181: [STORM-2607] Offset consumer + 1
Posted by tiodollar <gi...@git.apache.org>.
Github user tiodollar commented on a diff in the pull request:
https://github.com/apache/storm/pull/2181#discussion_r124927989
--- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/OffsetManager.java ---
@@ -118,6 +118,8 @@ public OffsetAndMetadata findNextCommitOffset() {
OffsetAndMetadata nextCommitOffsetAndMetadata = null;
if (nextCommitMsg != null) {
+ //The committed offset should be the next message
+ nextCommitOffset = nextCommitOffset + 1;
--- End diff --
@srdo Ok!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2181: [STORM-2607] Offset consumer + 1
Posted by tiodollar <gi...@git.apache.org>.
Github user tiodollar closed the pull request at:
https://github.com/apache/storm/pull/2181
---
[GitHub] storm issue #2181: [STORM-2607] Offset consumer + 1
Posted by Chandan83 <gi...@git.apache.org>.
Github user Chandan83 commented on the issue:
https://github.com/apache/storm/pull/2181
Is there any reason this merge is pending? Can I help?
---
[GitHub] storm issue #2181: [STORM-2607] Offset consumer + 1
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2181
@tiodollar Nice find. The fix is not workable though. We need to update OffsetManager to handle that the commit offset should be the last processed offset +1, as per the Kafka docs for commitSync: "The committed offset should be the next message your application will consume, i.e. lastProcessedMessageOffset + 1".
Would you like to take a look at fixing this? I'd also be happy to take a stab at it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2181: [STORM-2607] Offset consumer + 1
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2181
@tiodollar Seems like there's a conflict with master. Could you fix it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2181: [STORM-2607] Offset consumer + 1
Posted by tiodollar <gi...@git.apache.org>.
Github user tiodollar commented on the issue:
https://github.com/apache/storm/pull/2181
@hmcl Could I get you to review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2181: [STORM-2607] Offset consumer + 1
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2181#discussion_r125533526
--- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/OffsetManager.java ---
@@ -96,31 +98,34 @@ public OffsetAndMetadata findNextCommitOffset() {
the next logical point in the topic. Next logical offset should be the
first element after committedOffset in the ascending ordered emitted set.
*/
- LOG.debug("Processed non contiguous offset."
- + " (committedOffset+1) is no longer part of the topic."
- + " Committed: [{}], Processed: [{}]", committedOffset, currOffset);
- final Long nextEmittedOffset = emittedOffsets.ceiling(nextCommitOffset);
+ LOG.debug("Processed non-contiguous offset."
+ + " The earliest uncommitted offset is no longer part of the topic."
+ + " Missing uncommitted offset: [{}], Processed: [{}]", nextEarliestUncommittedOffset, currOffset);
+ final Long nextEmittedOffset = emittedOffsets.ceiling(nextEarliestUncommittedOffset);
if (nextEmittedOffset != null && currOffset == nextEmittedOffset) {
+ LOG.debug("Found committable offset: [{}] after missing offset: [{}], skipping to the committable offset",
+ currOffset, nextEarliestUncommittedOffset);
nextCommitMsg = currAckedMsg;
- nextCommitOffset = currOffset;
+ nextEarliestUncommittedOffset = currOffset + 1;
} else {
- LOG.debug("topic-partition [{}] has non-continuous offset [{}]."
- + " Next Offset to commit should be [{}]", tp, currOffset, nextEmittedOffset);
+ LOG.debug("topic-partition [{}] has non-contiguous offset [{}]."
+ + " Next Offset to commit should be [{}]", tp, currOffset, nextEarliestUncommittedOffset - 1);
break;
}
}
} else {
//Received a redundant ack. Ignore and continue processing.
- LOG.warn("topic-partition [{}] has unexpected offset [{}]. Current committed Offset [{}]",
- tp, currOffset, committedOffset);
+ LOG.warn("topic-partition [{}] has unexpected offset [{}]. Current earliest uncommitted offset [{}]",
+ tp, currOffset, earliestUncommittedOffset);
}
}
OffsetAndMetadata nextCommitOffsetAndMetadata = null;
if (nextCommitMsg != null) {
- nextCommitOffsetAndMetadata = new OffsetAndMetadata(nextCommitOffset, nextCommitMsg.getMetadata(Thread.currentThread()));
+ nextCommitOffsetAndMetadata = new OffsetAndMetadata(nextEarliestUncommittedOffset,
+ nextCommitMsg.getMetadata(Thread.currentThread()));
LOG.debug("topic-partition [{}] has offsets [{}-{}] ready to be committed",
- tp, committedOffset + 1, nextCommitOffsetAndMetadata.offset());
+ tp, earliestUncommittedOffset, nextCommitOffsetAndMetadata.offset());
--- End diff --
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2181: [STORM-2607] Offset consumer + 1
Posted by hmcl <gi...@git.apache.org>.
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2181
@tiodollar once you do the merge, can you please squash all the commits. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2181: [STORM-2607] Offset consumer + 1
Posted by hmcl <gi...@git.apache.org>.
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2181
@tiodollar ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---