[GitHub] [beam] lostluck commented on a diff in pull request #22102: Fixes #21698: Use normal Container snapshots for Go Load Tests

[GitBox <gi...@apache.org>]

lostluck commented on code in PR #22102:
URL: https://github.com/apache/beam/pull/22102#discussion_r911172120


##########
.test-infra/jenkins/LoadTestsBuilder.groovy:
##########
@@ -25,6 +25,7 @@ import static PythonTestProperties.LOAD_TEST_PYTHON_VERSION
 
 class LoadTestsBuilder {
   final static String DOCKER_CONTAINER_REGISTRY = 'gcr.io/apache-beam-testing/beam_portability'
+  final static String DOCKER_CONTAINER_REGISTRY_GO = 'gcr.io/apache-beam-testing/beam-sdk'

Review Comment:
   So, I've moved it to a variable, but I'll also point out that there are so many ways these configurations could be refactored to avoid all the repetition, while allowing for one off changes. So further changes of this nature are out of scope for this PR. 
   
   Eg. each specific load test has it's configuration repeated in the three languages, with very few changes between them other than the SDK container, and the name.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org