svn commit: r986869 - in /subversion/trunk/subversion/svnrdump: load_editor.c svnrdump.c

[da...@apache.org]

Author: danielsh
Date: Wed Aug 18 19:21:12 2010
New Revision: 986869

URL: http://svn.apache.org/viewvc?rev=986869&view=rev
Log:
Tweak print statements in svnrdump.

* subversion/svnrdump/load_editor.c
  (commit_callback, close_revision):
    Tweak the print statement for consistency with 'svnadmin dump'.
    Add a TODO saying this should be moved out (IIRC we plan to move the load
    editor to a library).

* subversion/svnrdump/svnrdump.c
  (replay_revend, replay_revisions):
    Tweak the print statement for consistency with 'svnadmin dump'.

Modified:
    subversion/trunk/subversion/svnrdump/load_editor.c
    subversion/trunk/subversion/svnrdump/svnrdump.c

Modified: subversion/trunk/subversion/svnrdump/load_editor.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/svnrdump/load_editor.c?rev=986869&r1=986868&r2=986869&view=diff
==============================================================================
--- subversion/trunk/subversion/svnrdump/load_editor.c (original)
+++ subversion/trunk/subversion/svnrdump/load_editor.c Wed Aug 18 19:21:12 2010
@@ -44,7 +44,8 @@ commit_callback(const svn_commit_info_t 
                 void *baton,
                 apr_pool_t *pool)
 {
-  SVN_ERR(svn_cmdline_printf(pool, "* Loaded revision %ld\n",
+  /* ### Don't print directly; generate a notification. */
+  SVN_ERR(svn_cmdline_printf(pool, "* Loaded revision %ld.\n",
                              commit_info->revision));
   return SVN_NO_ERROR;
 }
@@ -452,7 +453,8 @@ close_revision(void *baton)
 
   /* Fake revision 0 */
   if (rb->rev == 0)
-    SVN_ERR(svn_cmdline_printf(rb->pool, "* Loaded revision 0\n"));
+    /* ### Don't print directly; generate a notification. */
+    SVN_ERR(svn_cmdline_printf(rb->pool, "* Loaded revision 0.\n"));
   else if (commit_editor)
     {
       /* Close all pending open directories, and then close the edit

Modified: subversion/trunk/subversion/svnrdump/svnrdump.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/svnrdump/svnrdump.c?rev=986869&r1=986868&r2=986869&view=diff
==============================================================================
--- subversion/trunk/subversion/svnrdump/svnrdump.c (original)
+++ subversion/trunk/subversion/svnrdump/svnrdump.c Wed Aug 18 19:21:12 2010
@@ -179,7 +179,7 @@ replay_revend(svn_revnum_t revision,
   /* No resources left to free. */
   struct replay_baton *rb = replay_baton;
   if (! rb->quiet)
-    svn_cmdline_fprintf(stderr, pool, "* Dumped revision %lu\n", revision);
+    svn_cmdline_fprintf(stderr, pool, "* Dumped revision %lu.\n", revision);
   return SVN_NO_ERROR;
 }
 
@@ -288,7 +288,7 @@ replay_revisions(svn_ra_session_t *sessi
                                &(propstring->len)));
       SVN_ERR(svn_stream_printf(stdout_stream, pool, "\n"));
       if (! quiet)
-        svn_cmdline_fprintf(stderr, pool, "* Dumped revision %lu\n", start_revision);
+        svn_cmdline_fprintf(stderr, pool, "* Dumped revision %lu.\n", start_revision);
 
       start_revision++;
     }