You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/01 01:55:39 UTC
[GitHub] [flink] kbohinski opened a new pull request #10988: Add commas to
large numeric accumulators
kbohinski opened a new pull request #10988: Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988
## What is the purpose of the change
*Make large numeric accumulator values easier to read.
## Brief change log
*Decimal piped the value if it is finite.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no) no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no) no
- The serializers: (yes / no / don't know) no
- The runtime per-record code paths (performance sensitive): (yes / no / don't know) no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know) no
- The S3 file system connector: (yes / no / don't know) no
## Documentation
- Does this pull request introduce a new feature? (yes / no) no
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] vthinkxie commented on a change in pull request #10988: Add
commas to large numeric accumulators
Posted by GitBox <gi...@apache.org>.
vthinkxie commented on a change in pull request #10988: Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988#discussion_r384511776
##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/overview/accumulators/job-overview-drawer-accumulators.component.html
##########
@@ -37,7 +37,10 @@
<tr *ngFor="let accumulator of listOfAccumulator; trackBy:trackAccumulatorBy;">
<td>{{ accumulator.name }}</td>
<td>{{ accumulator.type }}</td>
- <td>{{ accumulator.value }}</td>
+ <td *ngIf="isFinite(accumulator.value); else nonNumeric">{{ accumulator.value | number:'1.0-0' }}</td>
+ <ng-template #nonNumeric>
+ <td>{{ accumulator.value }}</td>
Review comment:
there is no need to duplicate the `td` here, try this way
```html
<td>
<ng-container *ngIf="isFinite(accumulator.value); else nonNumeric">{{ accumulator.value | number:'1.0-0' }}</ng-container>
<ng-template #nonNumeric>{{ accumulator.value }}</ng-template>
</td>
```
and another easier way to do this
```html
<td>
{{ (accumulator.value | number:'1.0-3' ) || accumulator.value }}
</td>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] vthinkxie commented on issue #10988: Add commas to large
numeric accumulators
Posted by GitBox <gi...@apache.org>.
vthinkxie commented on issue #10988: Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988#issuecomment-591444396
Hi @kbohinski
Thanks for your PR, I have left some comments
cc @rmetzger
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10988: Add commas to
large numeric accumulators
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10988: Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988#issuecomment-580980044
<!--
Meta data
Hash:cec303a7c2c6e4338ca57f80f4fadfe7182126bb Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4745 TriggerType:PUSH TriggerID:cec303a7c2c6e4338ca57f80f4fadfe7182126bb
Hash:cec303a7c2c6e4338ca57f80f4fadfe7182126bb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147017024 TriggerType:PUSH TriggerID:cec303a7c2c6e4338ca57f80f4fadfe7182126bb
Hash:03ed8174e26557a168fe5defeebbfa8bc139c08d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147028572 TriggerType:PUSH TriggerID:03ed8174e26557a168fe5defeebbfa8bc139c08d
Hash:03ed8174e26557a168fe5defeebbfa8bc139c08d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4747 TriggerType:PUSH TriggerID:03ed8174e26557a168fe5defeebbfa8bc139c08d
-->
## CI report:
* cec303a7c2c6e4338ca57f80f4fadfe7182126bb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147017024) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4745)
* 03ed8174e26557a168fe5defeebbfa8bc139c08d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147028572) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4747)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10988: Add commas to
large numeric accumulators
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10988: Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988#issuecomment-580980044
<!--
Meta data
Hash:cec303a7c2c6e4338ca57f80f4fadfe7182126bb Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4745 TriggerType:PUSH TriggerID:cec303a7c2c6e4338ca57f80f4fadfe7182126bb
Hash:cec303a7c2c6e4338ca57f80f4fadfe7182126bb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147017024 TriggerType:PUSH TriggerID:cec303a7c2c6e4338ca57f80f4fadfe7182126bb
Hash:03ed8174e26557a168fe5defeebbfa8bc139c08d Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:03ed8174e26557a168fe5defeebbfa8bc139c08d
-->
## CI report:
* cec303a7c2c6e4338ca57f80f4fadfe7182126bb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147017024) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4745)
* 03ed8174e26557a168fe5defeebbfa8bc139c08d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10988: Add commas to
large numeric accumulators
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10988: Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988#issuecomment-580980044
<!--
Meta data
Hash:cec303a7c2c6e4338ca57f80f4fadfe7182126bb Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4745 TriggerType:PUSH TriggerID:cec303a7c2c6e4338ca57f80f4fadfe7182126bb
Hash:cec303a7c2c6e4338ca57f80f4fadfe7182126bb Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147017024 TriggerType:PUSH TriggerID:cec303a7c2c6e4338ca57f80f4fadfe7182126bb
-->
## CI report:
* cec303a7c2c6e4338ca57f80f4fadfe7182126bb Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147017024) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4745)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10988: Add commas to
large numeric accumulators
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10988: Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988#issuecomment-580980044
<!--
Meta data
Hash:cec303a7c2c6e4338ca57f80f4fadfe7182126bb Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4745 TriggerType:PUSH TriggerID:cec303a7c2c6e4338ca57f80f4fadfe7182126bb
Hash:cec303a7c2c6e4338ca57f80f4fadfe7182126bb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147017024 TriggerType:PUSH TriggerID:cec303a7c2c6e4338ca57f80f4fadfe7182126bb
Hash:03ed8174e26557a168fe5defeebbfa8bc139c08d Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147028572 TriggerType:PUSH TriggerID:03ed8174e26557a168fe5defeebbfa8bc139c08d
Hash:03ed8174e26557a168fe5defeebbfa8bc139c08d Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4747 TriggerType:PUSH TriggerID:03ed8174e26557a168fe5defeebbfa8bc139c08d
-->
## CI report:
* cec303a7c2c6e4338ca57f80f4fadfe7182126bb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147017024) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4745)
* 03ed8174e26557a168fe5defeebbfa8bc139c08d Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147028572) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4747)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10988: Add commas to
large numeric accumulators
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10988: Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988#issuecomment-580980044
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cec303a7c2c6e4338ca57f80f4fadfe7182126bb",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4745",
"triggerID" : "cec303a7c2c6e4338ca57f80f4fadfe7182126bb",
"triggerType" : "PUSH"
}, {
"hash" : "cec303a7c2c6e4338ca57f80f4fadfe7182126bb",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/147017024",
"triggerID" : "cec303a7c2c6e4338ca57f80f4fadfe7182126bb",
"triggerType" : "PUSH"
}, {
"hash" : "03ed8174e26557a168fe5defeebbfa8bc139c08d",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/147028572",
"triggerID" : "03ed8174e26557a168fe5defeebbfa8bc139c08d",
"triggerType" : "PUSH"
}, {
"hash" : "03ed8174e26557a168fe5defeebbfa8bc139c08d",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4747",
"triggerID" : "03ed8174e26557a168fe5defeebbfa8bc139c08d",
"triggerType" : "PUSH"
}, {
"hash" : "06668089b730778948e758f114c2ed34d141135f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "06668089b730778948e758f114c2ed34d141135f",
"triggerType" : "PUSH"
}, {
"hash" : "ac364646023681c9a4b237afe86f073c3fe5d108",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150764622",
"triggerID" : "ac364646023681c9a4b237afe86f073c3fe5d108",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 06668089b730778948e758f114c2ed34d141135f UNKNOWN
* ac364646023681c9a4b237afe86f073c3fe5d108 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150764622)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10988: Add commas to large
numeric accumulators
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10988: Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988#issuecomment-580978399
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit cec303a7c2c6e4338ca57f80f4fadfe7182126bb (Sat Feb 01 01:58:29 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **Invalid pull request title: No valid Jira ID provided**
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10988: Add commas to
large numeric accumulators
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10988: Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988#issuecomment-580980044
<!--
Meta data
Hash:cec303a7c2c6e4338ca57f80f4fadfe7182126bb Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4745 TriggerType:PUSH TriggerID:cec303a7c2c6e4338ca57f80f4fadfe7182126bb
Hash:cec303a7c2c6e4338ca57f80f4fadfe7182126bb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147017024 TriggerType:PUSH TriggerID:cec303a7c2c6e4338ca57f80f4fadfe7182126bb
-->
## CI report:
* cec303a7c2c6e4338ca57f80f4fadfe7182126bb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147017024) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4745)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10988:
[FLINK-16348][Runtime/WebFrontend] Add commas to large numeric accumulators
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10988: [FLINK-16348][Runtime/WebFrontend] Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988#issuecomment-580978399
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit ac364646023681c9a4b237afe86f073c3fe5d108 (Fri Feb 28 21:50:23 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-16348).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] kbohinski commented on issue #10988: Add commas to large
numeric accumulators
Posted by GitBox <gi...@apache.org>.
kbohinski commented on issue #10988: Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988#issuecomment-591741466
Thanks for the feedback, added changes! They can be a floating point value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10988: Add commas to large
numeric accumulators
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10988: Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988#issuecomment-580980044
<!--
Meta data
Hash:cec303a7c2c6e4338ca57f80f4fadfe7182126bb Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:cec303a7c2c6e4338ca57f80f4fadfe7182126bb
-->
## CI report:
* cec303a7c2c6e4338ca57f80f4fadfe7182126bb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] vthinkxie commented on issue #10988: Add commas to large
numeric accumulators
Posted by GitBox <gi...@apache.org>.
vthinkxie commented on issue #10988: Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988#issuecomment-591752358
Hi @kbohinski
the codes lgtm now, the commit message needs to follow the commit format
please check this comment https://github.com/apache/flink/pull/10988#issuecomment-591435529
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10988: Add commas to
large numeric accumulators
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10988: Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988#issuecomment-580980044
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cec303a7c2c6e4338ca57f80f4fadfe7182126bb",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4745",
"triggerID" : "cec303a7c2c6e4338ca57f80f4fadfe7182126bb",
"triggerType" : "PUSH"
}, {
"hash" : "cec303a7c2c6e4338ca57f80f4fadfe7182126bb",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/147017024",
"triggerID" : "cec303a7c2c6e4338ca57f80f4fadfe7182126bb",
"triggerType" : "PUSH"
}, {
"hash" : "03ed8174e26557a168fe5defeebbfa8bc139c08d",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/147028572",
"triggerID" : "03ed8174e26557a168fe5defeebbfa8bc139c08d",
"triggerType" : "PUSH"
}, {
"hash" : "03ed8174e26557a168fe5defeebbfa8bc139c08d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4747",
"triggerID" : "03ed8174e26557a168fe5defeebbfa8bc139c08d",
"triggerType" : "PUSH"
}, {
"hash" : "06668089b730778948e758f114c2ed34d141135f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "06668089b730778948e758f114c2ed34d141135f",
"triggerType" : "PUSH"
}, {
"hash" : "ac364646023681c9a4b237afe86f073c3fe5d108",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150764622",
"triggerID" : "ac364646023681c9a4b237afe86f073c3fe5d108",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 03ed8174e26557a168fe5defeebbfa8bc139c08d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147028572) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4747)
* 06668089b730778948e758f114c2ed34d141135f UNKNOWN
* ac364646023681c9a4b237afe86f073c3fe5d108 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150764622)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol merged pull request #10988:
[FLINK-16348][Runtime/WebFrontend] Add commas to large numeric accumulators
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #10988: [FLINK-16348][Runtime/WebFrontend] Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] vthinkxie commented on a change in pull request #10988: Add
commas to large numeric accumulators
Posted by GitBox <gi...@apache.org>.
vthinkxie commented on a change in pull request #10988: Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988#discussion_r384511776
##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/overview/accumulators/job-overview-drawer-accumulators.component.html
##########
@@ -37,7 +37,10 @@
<tr *ngFor="let accumulator of listOfAccumulator; trackBy:trackAccumulatorBy;">
<td>{{ accumulator.name }}</td>
<td>{{ accumulator.type }}</td>
- <td>{{ accumulator.value }}</td>
+ <td *ngIf="isFinite(accumulator.value); else nonNumeric">{{ accumulator.value | number:'1.0-0' }}</td>
+ <ng-template #nonNumeric>
+ <td>{{ accumulator.value }}</td>
Review comment:
there is no need to duplicate the `td` here, try this way
```html
<td>
<ng-container *ngIf="isFinite(accumulator.value); else nonNumeric">{{ accumulator.value | number:'1.0-0' }}</ng-container>
<ng-template #nonNumeric>{{ accumulator.value }}</ng-template>
</td>
```
and another easier way to do this
```html
<td>
{{ (accumulator.value | number:'1.0-0' ) || '-'}}
</td>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] kbohinski commented on issue #10988:
[FLINK-16348][Runtime/WebFrontend] Add commas to large numeric accumulators
Posted by GitBox <gi...@apache.org>.
kbohinski commented on issue #10988: [FLINK-16348][Runtime/WebFrontend] Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988#issuecomment-592730766
@rmetzger I think I fixed the PR title.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10988: Add commas to
large numeric accumulators
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10988: Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988#issuecomment-580980044
<!--
Meta data
Hash:cec303a7c2c6e4338ca57f80f4fadfe7182126bb Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4745 TriggerType:PUSH TriggerID:cec303a7c2c6e4338ca57f80f4fadfe7182126bb
Hash:cec303a7c2c6e4338ca57f80f4fadfe7182126bb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147017024 TriggerType:PUSH TriggerID:cec303a7c2c6e4338ca57f80f4fadfe7182126bb
Hash:03ed8174e26557a168fe5defeebbfa8bc139c08d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147028572 TriggerType:PUSH TriggerID:03ed8174e26557a168fe5defeebbfa8bc139c08d
Hash:03ed8174e26557a168fe5defeebbfa8bc139c08d Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4747 TriggerType:PUSH TriggerID:03ed8174e26557a168fe5defeebbfa8bc139c08d
-->
## CI report:
* cec303a7c2c6e4338ca57f80f4fadfe7182126bb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147017024) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4745)
* 03ed8174e26557a168fe5defeebbfa8bc139c08d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147028572) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4747)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10988: Add commas to
large numeric accumulators
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10988: Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988#issuecomment-580980044
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cec303a7c2c6e4338ca57f80f4fadfe7182126bb",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4745",
"triggerID" : "cec303a7c2c6e4338ca57f80f4fadfe7182126bb",
"triggerType" : "PUSH"
}, {
"hash" : "cec303a7c2c6e4338ca57f80f4fadfe7182126bb",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/147017024",
"triggerID" : "cec303a7c2c6e4338ca57f80f4fadfe7182126bb",
"triggerType" : "PUSH"
}, {
"hash" : "03ed8174e26557a168fe5defeebbfa8bc139c08d",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/147028572",
"triggerID" : "03ed8174e26557a168fe5defeebbfa8bc139c08d",
"triggerType" : "PUSH"
}, {
"hash" : "03ed8174e26557a168fe5defeebbfa8bc139c08d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4747",
"triggerID" : "03ed8174e26557a168fe5defeebbfa8bc139c08d",
"triggerType" : "PUSH"
}, {
"hash" : "06668089b730778948e758f114c2ed34d141135f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "06668089b730778948e758f114c2ed34d141135f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 03ed8174e26557a168fe5defeebbfa8bc139c08d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147028572) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4747)
* 06668089b730778948e758f114c2ed34d141135f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] vthinkxie commented on a change in pull request #10988: Add
commas to large numeric accumulators
Posted by GitBox <gi...@apache.org>.
vthinkxie commented on a change in pull request #10988: Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988#discussion_r384511776
##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/overview/accumulators/job-overview-drawer-accumulators.component.html
##########
@@ -37,7 +37,10 @@
<tr *ngFor="let accumulator of listOfAccumulator; trackBy:trackAccumulatorBy;">
<td>{{ accumulator.name }}</td>
<td>{{ accumulator.type }}</td>
- <td>{{ accumulator.value }}</td>
+ <td *ngIf="isFinite(accumulator.value); else nonNumeric">{{ accumulator.value | number:'1.0-0' }}</td>
+ <ng-template #nonNumeric>
+ <td>{{ accumulator.value }}</td>
Review comment:
there is no need to duplicate the `td` here, try this way
```html
<td>
<ng-container *ngIf="isFinite(accumulator.value); else nonNumeric">{{ accumulator.value | number:'1.0-0' }}</ng-container>
<ng-template #nonNumeric>{{ accumulator.value }}</ng-template>
</td>
```
and another easier way to do this
```html
<td>
{{ (accumulator.value | number:'1.0-0' ) || accumulator.value }}
</td>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] rmetzger commented on issue #10988: Add commas to large
numeric accumulators
Posted by GitBox <gi...@apache.org>.
rmetzger commented on issue #10988: Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988#issuecomment-591448203
Thanks a lot for the quick reaction!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10988: Add commas to
large numeric accumulators
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10988: Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988#issuecomment-580980044
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cec303a7c2c6e4338ca57f80f4fadfe7182126bb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4745",
"triggerID" : "cec303a7c2c6e4338ca57f80f4fadfe7182126bb",
"triggerType" : "PUSH"
}, {
"hash" : "cec303a7c2c6e4338ca57f80f4fadfe7182126bb",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/147017024",
"triggerID" : "cec303a7c2c6e4338ca57f80f4fadfe7182126bb",
"triggerType" : "PUSH"
}, {
"hash" : "03ed8174e26557a168fe5defeebbfa8bc139c08d",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/147028572",
"triggerID" : "03ed8174e26557a168fe5defeebbfa8bc139c08d",
"triggerType" : "PUSH"
}, {
"hash" : "03ed8174e26557a168fe5defeebbfa8bc139c08d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4747",
"triggerID" : "03ed8174e26557a168fe5defeebbfa8bc139c08d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cec303a7c2c6e4338ca57f80f4fadfe7182126bb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147017024) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4745)
* 03ed8174e26557a168fe5defeebbfa8bc139c08d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147028572) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4747)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] vthinkxie commented on a change in pull request #10988: Add
commas to large numeric accumulators
Posted by GitBox <gi...@apache.org>.
vthinkxie commented on a change in pull request #10988: Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988#discussion_r384509858
##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/overview/accumulators/job-overview-drawer-accumulators.component.html
##########
@@ -37,7 +37,10 @@
<tr *ngFor="let accumulator of listOfAccumulator; trackBy:trackAccumulatorBy;">
<td>{{ accumulator.name }}</td>
<td>{{ accumulator.type }}</td>
- <td>{{ accumulator.value }}</td>
+ <td *ngIf="isFinite(accumulator.value); else nonNumeric">{{ accumulator.value | number:'1.0-0' }}</td>
Review comment:
I'm not sure, but is the `{{accumulator.value}}` is always integer? if not we should not make it round to intergerwith `number:'1.0-0'`,`number:'1.0-3'` is better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] kbohinski commented on issue #10988:
[FLINK-16348][Runtime/WebFrontend] Add commas to large numeric accumulators
Posted by GitBox <gi...@apache.org>.
kbohinski commented on issue #10988: [FLINK-16348][Runtime/WebFrontend] Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988#issuecomment-592735549
Also `Make sure that the pull request corresponds to a JIRA issue.` on the https://flink.apache.org/contributing/code-style-and-quality-pull-requests.html#jira-issue-and-naming page link does not work
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] rmetzger commented on issue #10988: Add commas to large
numeric accumulators
Posted by GitBox <gi...@apache.org>.
rmetzger commented on issue #10988: Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988#issuecomment-591435529
Thanks a lot for your contribution! Sadly, our contribution process is a little bit involved and requires some steps to be followed: https://flink.apache.org/contributing/code-style-and-quality-pull-requests.html#jira-issue-and-naming
In particular, this PR is lacking a JIRA ticket, which you will also need to reference from the commit.
If @vthinkxie is +1 on this change, I can also create the ticket for you. Just let me know!
@vthinkxie can you take a look? Thanks 💯
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] vthinkxie commented on a change in pull request #10988: Add
commas to large numeric accumulators
Posted by GitBox <gi...@apache.org>.
vthinkxie commented on a change in pull request #10988: Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988#discussion_r384511776
##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/overview/accumulators/job-overview-drawer-accumulators.component.html
##########
@@ -37,7 +37,10 @@
<tr *ngFor="let accumulator of listOfAccumulator; trackBy:trackAccumulatorBy;">
<td>{{ accumulator.name }}</td>
<td>{{ accumulator.type }}</td>
- <td>{{ accumulator.value }}</td>
+ <td *ngIf="isFinite(accumulator.value); else nonNumeric">{{ accumulator.value | number:'1.0-0' }}</td>
+ <ng-template #nonNumeric>
+ <td>{{ accumulator.value }}</td>
Review comment:
there is no need to duplicate the `td` here, try this way
```html
<td>
<ng-container *ngIf="isFinite(accumulator.value); else nonNumeric">{{ accumulator.value | number:'1.0-0' }}</ng-container>
<ng-template #nonNumeric>{{ accumulator.value }}</ng-template>
</td>
```
and a easier way is
```html
<td>
{{ (accumulator.value | number:'1.0-0' ) || '-'}}
</td>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10988: Add commas to
large numeric accumulators
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10988: Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988#issuecomment-580980044
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cec303a7c2c6e4338ca57f80f4fadfe7182126bb",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4745",
"triggerID" : "cec303a7c2c6e4338ca57f80f4fadfe7182126bb",
"triggerType" : "PUSH"
}, {
"hash" : "cec303a7c2c6e4338ca57f80f4fadfe7182126bb",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/147017024",
"triggerID" : "cec303a7c2c6e4338ca57f80f4fadfe7182126bb",
"triggerType" : "PUSH"
}, {
"hash" : "03ed8174e26557a168fe5defeebbfa8bc139c08d",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/147028572",
"triggerID" : "03ed8174e26557a168fe5defeebbfa8bc139c08d",
"triggerType" : "PUSH"
}, {
"hash" : "03ed8174e26557a168fe5defeebbfa8bc139c08d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4747",
"triggerID" : "03ed8174e26557a168fe5defeebbfa8bc139c08d",
"triggerType" : "PUSH"
}, {
"hash" : "06668089b730778948e758f114c2ed34d141135f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "06668089b730778948e758f114c2ed34d141135f",
"triggerType" : "PUSH"
}, {
"hash" : "ac364646023681c9a4b237afe86f073c3fe5d108",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ac364646023681c9a4b237afe86f073c3fe5d108",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 03ed8174e26557a168fe5defeebbfa8bc139c08d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147028572) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4747)
* 06668089b730778948e758f114c2ed34d141135f UNKNOWN
* ac364646023681c9a4b237afe86f073c3fe5d108 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] vthinkxie commented on a change in pull request #10988: Add
commas to large numeric accumulators
Posted by GitBox <gi...@apache.org>.
vthinkxie commented on a change in pull request #10988: Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988#discussion_r384509858
##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/overview/accumulators/job-overview-drawer-accumulators.component.html
##########
@@ -37,7 +37,10 @@
<tr *ngFor="let accumulator of listOfAccumulator; trackBy:trackAccumulatorBy;">
<td>{{ accumulator.name }}</td>
<td>{{ accumulator.type }}</td>
- <td>{{ accumulator.value }}</td>
+ <td *ngIf="isFinite(accumulator.value); else nonNumeric">{{ accumulator.value | number:'1.0-0' }}</td>
Review comment:
I'm not sure, but is the `{{accumulator.value}}` always integer? if not we should not make it round to interger with `number:'1.0-0'`,`number:'1.0-3'` is better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10988: Add commas to
large numeric accumulators
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10988: Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988#issuecomment-580980044
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cec303a7c2c6e4338ca57f80f4fadfe7182126bb",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4745",
"triggerID" : "cec303a7c2c6e4338ca57f80f4fadfe7182126bb",
"triggerType" : "PUSH"
}, {
"hash" : "cec303a7c2c6e4338ca57f80f4fadfe7182126bb",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/147017024",
"triggerID" : "cec303a7c2c6e4338ca57f80f4fadfe7182126bb",
"triggerType" : "PUSH"
}, {
"hash" : "03ed8174e26557a168fe5defeebbfa8bc139c08d",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/147028572",
"triggerID" : "03ed8174e26557a168fe5defeebbfa8bc139c08d",
"triggerType" : "PUSH"
}, {
"hash" : "03ed8174e26557a168fe5defeebbfa8bc139c08d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4747",
"triggerID" : "03ed8174e26557a168fe5defeebbfa8bc139c08d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 03ed8174e26557a168fe5defeebbfa8bc139c08d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147028572) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4747)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] vthinkxie commented on a change in pull request #10988: Add
commas to large numeric accumulators
Posted by GitBox <gi...@apache.org>.
vthinkxie commented on a change in pull request #10988: Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988#discussion_r384511776
##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/overview/accumulators/job-overview-drawer-accumulators.component.html
##########
@@ -37,7 +37,10 @@
<tr *ngFor="let accumulator of listOfAccumulator; trackBy:trackAccumulatorBy;">
<td>{{ accumulator.name }}</td>
<td>{{ accumulator.type }}</td>
- <td>{{ accumulator.value }}</td>
+ <td *ngIf="isFinite(accumulator.value); else nonNumeric">{{ accumulator.value | number:'1.0-0' }}</td>
+ <ng-template #nonNumeric>
+ <td>{{ accumulator.value }}</td>
Review comment:
there is no need to duplicate the `td` here, we can use
```html
<td>
<ng-container *ngIf="isFinite(accumulator.value); else nonNumeric">{{ accumulator.value | number:'1.0-0' }}</ng-container>
<ng-template #nonNumeric>{{ accumulator.value }}</ng-template>
</td>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] vthinkxie commented on a change in pull request #10988: Add
commas to large numeric accumulators
Posted by GitBox <gi...@apache.org>.
vthinkxie commented on a change in pull request #10988: Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988#discussion_r384509858
##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/overview/accumulators/job-overview-drawer-accumulators.component.html
##########
@@ -37,7 +37,10 @@
<tr *ngFor="let accumulator of listOfAccumulator; trackBy:trackAccumulatorBy;">
<td>{{ accumulator.name }}</td>
<td>{{ accumulator.type }}</td>
- <td>{{ accumulator.value }}</td>
+ <td *ngIf="isFinite(accumulator.value); else nonNumeric">{{ accumulator.value | number:'1.0-0' }}</td>
Review comment:
I'm not sure, but is the `{{accumulator.value}}` always integer? if not we should not make it round to integer with `number:'1.0-0'`,`number:'1.0-3'` is better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services