You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Diwaker Gupta <no...@github.com> on 2013/07/24 20:53:07 UTC
[jclouds] Preserve content-type and content-disposition for
multi-part uploads. (#73)
Fixes JCLOUDS-204
You can merge this Pull Request by running:
git pull https://github.com/maginatics/jclouds feature/mpu-metadata
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/73
-- Commit Summary --
* Preserve content-type and content-disposition for multi-part uploads.
-- File Changes --
M providers/aws-s3/src/main/java/org/jclouds/aws/s3/blobstore/strategy/internal/SequentialMultipartUploadStrategy.java (7)
M providers/aws-s3/src/test/java/org/jclouds/aws/s3/blobstore/strategy/internal/SequentialMultipartUploadStrategyMockTest.java (9)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/73.patch
https://github.com/jclouds/jclouds/pull/73.diff
Re: [jclouds] Preserve content-type and content-disposition for
multi-part uploads. (#73)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #79](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/79/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/73#issuecomment-21555105
Re: [jclouds] Preserve content-type and content-disposition for
multi-part uploads. (#73)
Posted by Andrew Phillips <no...@github.com>.
Looks good to me. Thanks, @diwakergupta!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/73#issuecomment-21551668
Re: [jclouds] Preserve content-type and content-disposition for
multi-part uploads. (#73)
Posted by Andrew Phillips <no...@github.com>.
Closed #73.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/73
Re: [jclouds] Preserve content-type and content-disposition for
multi-part uploads. (#73)
Posted by Andrew Phillips <no...@github.com>.
Reopened #73.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/73
Re: [jclouds] Preserve content-type and content-disposition for
multi-part uploads. (#73)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #221](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/221/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/73#issuecomment-21510615
Re: [jclouds] Preserve content-type and content-disposition for
multi-part uploads. (#73)
Posted by Diwaker Gupta <no...@github.com>.
RFC @demobox @andrewgaul. This probably impacts other blobstores as well -- I'll check and push separate patches for each as appropriate. For now, focusing just on AWS-S3.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/73#issuecomment-21535682
Re: [jclouds] Preserve content-type and content-disposition for
multi-part uploads. (#73)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #225](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/225/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/73#issuecomment-21554626
Re: [jclouds] Preserve content-type and content-disposition for
multi-part uploads. (#73)
Posted by Andrew Gaul <no...@github.com>.
Closed #73.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/73
Re: [jclouds] Preserve content-type and content-disposition for
multi-part uploads. (#73)
Posted by Andrew Gaul <no...@github.com>.
I successfully ran unit and live tests. I amended the commit message and pushed to master and 1.6.x. Thank you for your contribution @diwakergupta !
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/73#issuecomment-21570618
Re: [jclouds] Preserve content-type and content-disposition for
multi-part uploads. (#73)
Posted by Andrew Phillips <no...@github.com>.
PS: Curious about the lack of DEV@cloud PR job. Will close and re-open to try to trigger one.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/73#issuecomment-21551713
Re: [jclouds] Preserve content-type and content-disposition for
multi-part uploads. (#73)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #536](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/536/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/73#issuecomment-21555022