You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/08/25 22:45:04 UTC

[GitHub] [hudi] rahil-c opened a new pull request #3538: [HUDI-2359] Add basic "hoodie_is_deleted" unit tests to TestDataSource classes

rahil-c opened a new pull request #3538:
URL: https://github.com/apache/hudi/pull/3538


   ## What is the purpose of the pull request
   
   JIRA : https://issues.apache.org/jira/browse/HUDI-2359
   
   In issue thread https://github.com/apache/hudi/issues/3321, there was a discussion around the functionality of `hoodie_is_deleted` field.
   
   1. We wanted to ensure that when this field was being set to `true`, that the specified record would be deleted.
   2. We also wanted to make sure that this field only needed to be set to `true` for an incoming record, and not for existing records.
   
   The goal of this PR is to add unit tests that follow similar reproductions as discussed in the above github issue thread.
   
   @nsivabalan example https://gist.github.com/nsivabalan/e5ac69677ed05e9f2749fae67d3abc19 
   @nmukerje example https://github.com/nmukerje/misc/blob/master/Hudi/Hudi_Pyspark_Delete_Upsert_Test.ipynb
   
   ## Verify this pull request
   
   
   This change added test methods to existing test classes and can be verified as follows:
   ```
   mvn -Dtest=TestMORDataSource#testHoodieIsDeletedMOR test -DfailIfNoTests=false -pl hudi-spark-datasource/hudi-spark/
   
   mvn -Dtest=TestCOWDataSource#testHoodieIsDeletedCOW test -DfailIfNoTests=false -pl hudi-spark-datasource/hudi-spark/
   ```
   
   ## Committer checklist
   
    - [] Has a corresponding JIRA in PR title & commit
    
    - [] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3538: [HUDI-2359] Add basic "hoodie_is_deleted" unit tests to TestDataSource classes

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3538:
URL: https://github.com/apache/hudi/pull/3538#issuecomment-905926295


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "fc39ed3e732d8f6621b904279e316bed8b47f485",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "fc39ed3e732d8f6621b904279e316bed8b47f485",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * fc39ed3e732d8f6621b904279e316bed8b47f485 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] rahil-c closed pull request #3538: [HUDI-2359] Add basic "hoodie_is_deleted" unit tests to TestDataSource classes

Posted by GitBox <gi...@apache.org>.
rahil-c closed pull request #3538:
URL: https://github.com/apache/hudi/pull/3538


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3538: [HUDI-2359] Add basic "hoodie_is_deleted" unit tests to TestDataSource classes

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3538:
URL: https://github.com/apache/hudi/pull/3538#issuecomment-905926295


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "fc39ed3e732d8f6621b904279e316bed8b47f485",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1895",
       "triggerID" : "fc39ed3e732d8f6621b904279e316bed8b47f485",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * fc39ed3e732d8f6621b904279e316bed8b47f485 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1895) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org