[GitHub] [spark] beliefer commented on a change in pull request #34554: [SPARK-37286][SQL] Move compileFilter and compileAggregates from JDBCRDD to JdbcDialect

[GitBox <gi...@apache.org>]

beliefer commented on a change in pull request #34554:
URL: https://github.com/apache/spark/pull/34554#discussion_r748719956



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala
##########
@@ -193,6 +195,85 @@ abstract class JdbcDialect extends Serializable with Logging{
     case _ => value
   }
 
+  /**
+   * Turns a single Filter into a String representing a SQL expression.
+   * Returns None for an unhandled filter.
+   */
+  @Since("3.3.0")
+  def compileFilter(f: Filter): Option[String] = {

Review comment:
       Yes. I think should lets any database to overwrite it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org