[kylin] branch master updated: KYLIN-3929 Check satisfaction before execute cubeplanner algorithm

[sh...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

shaofengshi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kylin.git


The following commit(s) were added to refs/heads/master by this push:
     new 7a1f90d  KYLIN-3929 Check satisfaction before execute cubeplanner algorithm
7a1f90d is described below

commit 7a1f90d598b0254b94f36fa0e381c66274aced83
Author: chao long <wa...@qq.com>
AuthorDate: Tue Apr 2 10:01:15 2019 +0800

    KYLIN-3929 Check satisfaction before execute cubeplanner algorithm
---
 .../org/apache/kylin/cube/cuboid/algorithm/CuboidRecommender.java  | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/core-cube/src/main/java/org/apache/kylin/cube/cuboid/algorithm/CuboidRecommender.java b/core-cube/src/main/java/org/apache/kylin/cube/cuboid/algorithm/CuboidRecommender.java
index fdaa654..da4f457 100644
--- a/core-cube/src/main/java/org/apache/kylin/cube/cuboid/algorithm/CuboidRecommender.java
+++ b/core-cube/src/main/java/org/apache/kylin/cube/cuboid/algorithm/CuboidRecommender.java
@@ -128,6 +128,10 @@ public class CuboidRecommender {
         int allCuboidCount = cuboidStats.getAllCuboidsForMandatory().size()
                 + cuboidStats.getAllCuboidsForSelection().size();
 
+        if (!ifForceRecommend && allCuboidCount <= threshold1) {
+            return null;
+        }
+
         BenefitPolicy benefitPolicy = new PBPUSCalculator(cuboidStats);
         CuboidRecommendAlgorithm algorithm = null;
 
@@ -157,9 +161,6 @@ public class CuboidRecommender {
             }
         }
 
-        if (!ifForceRecommend && allCuboidCount <= threshold1) {
-            return null;
-        }
         return recommendCuboidsWithStats;
     }