You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "anirudh-04 (via GitHub)" <gi...@apache.org> on 2025/03/27 10:30:17 UTC
[PR] CAMEL-20937 add azure-storage-queue span decorator [camel]
anirudh-04 opened a new pull request, #17592:
URL: https://github.com/apache/camel/pull/17592
# Description
<!--
- Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
-->
Added azure-storage-queue Span decorator.
# Target
- [x] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch)
# Tracking
- [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [x] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [x] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes.
<!--
You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20937 add azure-storage-datalake span decorator [camel]
Posted by "anirudh-04 (via GitHub)" <gi...@apache.org>.
anirudh-04 commented on PR #17592:
URL: https://github.com/apache/camel/pull/17592#issuecomment-2760558634
@bvahdat thanks for the review! I've made the suggested changes and squashed the commits. Please check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20937 add azure-storage-queue span decorator [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17592:
URL: https://github.com/apache/camel/pull/17592#issuecomment-2757532068
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20937 add azure-storage-datalake span decorator [camel]
Posted by "bvahdat (via GitHub)" <gi...@apache.org>.
bvahdat merged PR #17592:
URL: https://github.com/apache/camel/pull/17592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20937 add azure-storage-datalake span decorator [camel]
Posted by "bvahdat (via GitHub)" <gi...@apache.org>.
bvahdat commented on code in PR #17592:
URL: https://github.com/apache/camel/pull/17592#discussion_r2018114646
##########
components/camel-tracing/src/main/java/org/apache/camel/tracing/decorators/AzureStorageDataLakeSpanDecorator.java:
##########
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.tracing.decorators;
+
+import java.time.Duration;
+import java.time.OffsetDateTime;
+import java.util.Map;
+
+import org.apache.camel.Endpoint;
+import org.apache.camel.Exchange;
+import org.apache.camel.tracing.SpanAdapter;
+import org.apache.camel.tracing.TagConstants;
+
+public class AzureStorageDataLakeSpanDecorator extends AbstractSpanDecorator {
+
+ static final String STORAGE_DATALAKE_DIRECTORY_NAME = "directoryName";
+ static final String STORAGE_DATALAKE_FILE_NAME = "fileName";
+ static final String STORAGE_DATALAKE_PATH = "path";
+ static final String STORAGE_DATALAKE_TIMEOUT = "timeout";
+ static final String STORAGE_DATALAKE_CONTENT_TYPE = "contentType";
+ static final String STORAGE_DATALAKE_METADATA = "metadata";
+ static final String STORAGE_DATALAKE_LAST_MODIFIED = "lastModified";
+ static final String STORAGE_DATALAKE_POSITION = "position";
+ static final String STORAGE_DATALAKE_EXPRESSION = "expression";
+
+ /**
+ * Constants copied from {@link org.apache.camel.component.azure.storage.datalake.DataLakeConstants}
+ */
+ static final String OPERATION = "CamelAzureStorageDataLakeOperation";
+ static final String FILESYSTEM_NAME = "CamelAzureStorageDataLakeFileSystemName";
+ static final String DIRECTORY_NAME = "CamelAzureStorageDataLakeDirectoryName";
+ static final String FILE_NAME = "CamelAzureStorageDataLakeFileName";
+ static final String PATH = "CamelAzureStorageDataLakePath";
+ static final String TIMEOUT = "CamelAzureStorageDataLakeTimeout";
+ static final String CONTENT_TYPE = "CamelAzureStorageDataLakeContentType";
+ static final String METADATA = "CamelAzureStorageDataLakeMetadata";
+ static final String LAST_MODIFIED = "CamelAzureStorageDataLakeLastModified";
+ static final String POSITION = "CamelAzureStorageDataLakePosition";
+ static final String EXPRESSION = "CamelAzureStorageDataLakeExpression";
+
+ @Override
+ public String getComponent() {
+ return "azure-storage-datalake";
+ }
+
+ @Override
+ public String getComponentClassName() {
+ return "org.apache.camel.component.azure.storage.datalake.DataLakeComponent.java";
Review Comment:
Please remove the `.java` suffix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org