You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by soralee <gi...@git.apache.org> on 2017/01/03 11:53:59 UTC
[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...
GitHub user soralee opened a pull request:
https://github.com/apache/zeppelin/pull/1834
[ZEPPELIN-1864] Improvement to show folder and note after searching note
### What is this PR for?
This PR is for improvement to show folder and note after using the filter. And I found some bugs and fixed like this.
the following list is improvement and bug fixed.
1. After using the filter in Zeppelin Home, every note is shown by the form [FolderName/NoteName] like below. It would be nice to show folder icon and note icon as previous status.
2. When using the filter, some functions and icons next to note and folder are disappeared.
3. When using the filter, the `Rename Note` function doesn't work. ( When I was handling this PR, this bug was discovered.)
### What type of PR is it?
[ Bug Fix | Improvement ]
### Todos
* [x] - improve to show folder and note when finishing to use filter.
* [x] - some functions and icons next to note and folder are appeared when using filter.
* [x] - fix `Rename Note` function when using the filter.
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1864
### How should this be tested?
- **[Test 1]** Before/After using the filter, check the list structure of your notes. It should be same appearance.
- **[Test 2]** When using the filter, check the notes, some icon and function next to note and folder should be appeared.
- **[Test 3]** When using the filter, click `Rename Note`. It should be appeared the path of Note.
### Screenshots (if appropriate)
**Test 1**.
**Test 2**.
**Test 3**.
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/soralee/zeppelin ZEPPELIN-1864
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1834.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1834
----
commit c21c9d33138e7a4e48d42c1f46862eebc75cad02
Author: soralee <so...@nflabs.com>
Date: 2017-01-03T09:35:55Z
Improvement to show folder and note after searching note
commit 4ef7f8d6af372355d609a606cfeb12592f14584c
Author: soralee <so...@nflabs.com>
Date: 2017-01-03T11:51:31Z
Improvement to show folder and note after searching note
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1834: [ZEPPELIN-1864] Improvement to show folder and note af...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1834
@soralee Thanks for the improvement. I've also seen those issues when I was using filter. Let me test this :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1834: [ZEPPELIN-1864] Improvement to show folder and note af...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1834
You mean if we
open the folder in the **_navbar_** (e.g. Zeppelin Tutorial)-> type some text in the search bar -> remove all text -> the opened folder is closed
But this isn't happened in **_home_**. Am I right? I tested again and checked what you mentioned. I think current status is good for me and we can keep improving it if you need more time to handle this part.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...
Posted by soralee <gi...@git.apache.org>.
GitHub user soralee reopened a pull request:
https://github.com/apache/zeppelin/pull/1834
[ZEPPELIN-1864] Improvement to show folder and note after searching note
### What is this PR for?
This PR is for improvement to show folder and note after using the filter. And I found some bugs and fixed like this.
the following list is improvement and bug fixed.
1. After using the filter in Zeppelin Home, every note is shown by the form [FolderName/NoteName] like below. It would be nice to show folder icon and note icon as previous status.
2. When using the filter, some functions and icons next to note and folder are disappeared.
3. When using the filter, the `Rename Note` function doesn't work. ( When I was handling this PR, this bug was discovered.)
### What type of PR is it?
[ Bug Fix | Improvement ]
### Todos
* [x] - improve to show folder and note when finishing to use filter.
* [x] - some functions and icons next to note and folder are appeared when using filter.
* [x] - fix `Rename Note` function when using the filter.
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1864
### How should this be tested?
- **[Test 1]** Before/After using the filter, check the list structure of your notes. It must be same appearance.
- **[Test 2]** When using the filter, check the notes. Some icons and functions next to note and folder must be appeared.
- **[Test 3]** When using the filter, click `Rename Note`. It must be appeared the path of Note.
### Screenshots (if appropriate)
**Test 1**.
**Test 2**.
**Test 3**.
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/soralee/zeppelin ZEPPELIN-1864
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1834.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1834
----
commit 69d6d6d710c72e07d28e0c29978fe24e15002f8d
Author: soralee <so...@nflabs.com>
Date: 2017-01-03T09:35:55Z
Improvement to show folder and note after searching note
commit 61680e5f814ca67dc015406852315a1a92d4e7a8
Author: soralee <so...@nflabs.com>
Date: 2017-01-03T11:51:31Z
Improvement to show folder and note after searching note
commit 3e4b8ae80f53e9c7b4709bb41a65ac31b0f62fb4
Author: soralee <so...@nflabs.com>
Date: 2017-01-09T09:19:11Z
fix for that filter of navbar and home don't work
commit fd2c2438d6fbc3880194cd6c6e3ed1993b71f3a0
Author: soralee <so...@nflabs.com>
Date: 2017-01-11T06:04:53Z
resolve conflict
commit 6fb53aa420e39ee9144513d2b68521bbac1f83a5
Author: soralee <so...@nflabs.com>
Date: 2017-01-11T06:26:23Z
resolve conflict
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...
Posted by soralee <gi...@git.apache.org>.
GitHub user soralee reopened a pull request:
https://github.com/apache/zeppelin/pull/1834
[ZEPPELIN-1864] Improvement to show folder and note after searching note
### What is this PR for?
This PR is for improvement to show folder and note after using the filter. And I found some bugs and fixed like this.
the following list is improvement and bug fixed.
1. After using the filter in Zeppelin Home, every note is shown by the form [FolderName/NoteName] like below. It would be nice to show folder icon and note icon as previous status.
2. When using the filter, some functions and icons next to note and folder are disappeared.
3. When using the filter, the `Rename Note` function doesn't work. ( When I was handling this PR, this bug was discovered.)
### What type of PR is it?
[ Bug Fix | Improvement ]
### Todos
* [x] - improve to show folder and note when finishing to use filter.
* [x] - some functions and icons next to note and folder are appeared when using filter.
* [x] - fix `Rename Note` function when using the filter.
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1864
### How should this be tested?
- **[Test 1]** Before/After using the filter, check the list structure of your notes. It must be same appearance.
- **[Test 2]** When using the filter, check the notes. Some icons and functions next to note and folder must be appeared.
- **[Test 3]** When using the filter, click `Rename Note`. It must be appeared the path of Note.
### Screenshots (if appropriate)
**Test 1**.
**Test 2**.
**Test 3**.
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/soralee/zeppelin ZEPPELIN-1864
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1834.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1834
----
commit 69d6d6d710c72e07d28e0c29978fe24e15002f8d
Author: soralee <so...@nflabs.com>
Date: 2017-01-03T09:35:55Z
Improvement to show folder and note after searching note
commit 61680e5f814ca67dc015406852315a1a92d4e7a8
Author: soralee <so...@nflabs.com>
Date: 2017-01-03T11:51:31Z
Improvement to show folder and note after searching note
commit 3e4b8ae80f53e9c7b4709bb41a65ac31b0f62fb4
Author: soralee <so...@nflabs.com>
Date: 2017-01-09T09:19:11Z
fix for that filter of navbar and home don't work
commit fd2c2438d6fbc3880194cd6c6e3ed1993b71f3a0
Author: soralee <so...@nflabs.com>
Date: 2017-01-11T06:04:53Z
resolve conflict
commit 6fb53aa420e39ee9144513d2b68521bbac1f83a5
Author: soralee <so...@nflabs.com>
Date: 2017-01-11T06:26:23Z
resolve conflict
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1834: [ZEPPELIN-1864] Improvement to show folder and note af...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1834
@soralee Tested and works well for all 3 cases you mentioned. But for the consistency, don't we need to apply this to the Navbar one? I mean currently filter doesn't work for folder structured notes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1834: [ZEPPELIN-1864] Improvement to show folder and note af...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/1834
@AhyoungRyu Yes, you're right.
I mean, If I change **navbar** folder option, it works together both the filter in the **home** and **navbar**. So, I did not include this part because I think this improvement should be opened other PR.
Thanks for review again!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1834: [ZEPPELIN-1864] Improvement to show folder and note af...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/1834
@AhyoungRyu I updated the filter of Navbar.
But, the folder of notes in navbar don't have previous status. Because If using the hidden value of the note, it works together both the filter in the home and navbar.
I think it will take more time to add this feature so it would be nice to improve this part by separating PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...
Posted by soralee <gi...@git.apache.org>.
Github user soralee closed the pull request at:
https://github.com/apache/zeppelin/pull/1834
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1834
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...
Posted by soralee <gi...@git.apache.org>.
GitHub user soralee reopened a pull request:
https://github.com/apache/zeppelin/pull/1834
[ZEPPELIN-1864] Improvement to show folder and note after searching note
### What is this PR for?
This PR is for improvement to show folder and note after using the filter. And I found some bugs and fixed like this.
the following list is improvement and bug fixed.
1. After using the filter in Zeppelin Home, every note is shown by the form [FolderName/NoteName] like below. It would be nice to show folder icon and note icon as previous status.
2. When using the filter, some functions and icons next to note and folder are disappeared.
3. When using the filter, the `Rename Note` function doesn't work. ( When I was handling this PR, this bug was discovered.)
### What type of PR is it?
[ Bug Fix | Improvement ]
### Todos
* [x] - improve to show folder and note when finishing to use filter.
* [x] - some functions and icons next to note and folder are appeared when using filter.
* [x] - fix `Rename Note` function when using the filter.
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1864
### How should this be tested?
- **[Test 1]** Before/After using the filter, check the list structure of your notes. It must be same appearance.
- **[Test 2]** When using the filter, check the notes. Some icons and functions next to note and folder must be appeared.
- **[Test 3]** When using the filter, click `Rename Note`. It must be appeared the path of Note.
### Screenshots (if appropriate)
**Test 1**.
**Test 2**.
**Test 3**.
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/soralee/zeppelin ZEPPELIN-1864
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1834.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1834
----
commit 69d6d6d710c72e07d28e0c29978fe24e15002f8d
Author: soralee <so...@nflabs.com>
Date: 2017-01-03T09:35:55Z
Improvement to show folder and note after searching note
commit 61680e5f814ca67dc015406852315a1a92d4e7a8
Author: soralee <so...@nflabs.com>
Date: 2017-01-03T11:51:31Z
Improvement to show folder and note after searching note
commit 3e4b8ae80f53e9c7b4709bb41a65ac31b0f62fb4
Author: soralee <so...@nflabs.com>
Date: 2017-01-09T09:19:11Z
fix for that filter of navbar and home don't work
commit fd2c2438d6fbc3880194cd6c6e3ed1993b71f3a0
Author: soralee <so...@nflabs.com>
Date: 2017-01-11T06:04:53Z
resolve conflict
commit 6fb53aa420e39ee9144513d2b68521bbac1f83a5
Author: soralee <so...@nflabs.com>
Date: 2017-01-11T06:26:23Z
resolve conflict
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...
Posted by soralee <gi...@git.apache.org>.
Github user soralee closed the pull request at:
https://github.com/apache/zeppelin/pull/1834
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1834: [ZEPPELIN-1864] Improvement to show folder and note af...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1834
Yup thanks for the explanation. Merge if there are no more discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...
Posted by soralee <gi...@git.apache.org>.
Github user soralee closed the pull request at:
https://github.com/apache/zeppelin/pull/1834
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1834: [ZEPPELIN-1864] Improvement to show folder and note af...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/1834
Thanks for detailed test @AhyoungRyu! :heart_eyes:
Sure, actually I missed the filter in the Navbar!
Let me check and update PR!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...
Posted by soralee <gi...@git.apache.org>.
Github user soralee closed the pull request at:
https://github.com/apache/zeppelin/pull/1834
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...
Posted by soralee <gi...@git.apache.org>.
GitHub user soralee reopened a pull request:
https://github.com/apache/zeppelin/pull/1834
[ZEPPELIN-1864] Improvement to show folder and note after searching note
### What is this PR for?
This PR is for improvement to show folder and note after using the filter. And I found some bugs and fixed like this.
the following list is improvement and bug fixed.
1. After using the filter in Zeppelin Home, every note is shown by the form [FolderName/NoteName] like below. It would be nice to show folder icon and note icon as previous status.
2. When using the filter, some functions and icons next to note and folder are disappeared.
3. When using the filter, the `Rename Note` function doesn't work. ( When I was handling this PR, this bug was discovered.)
### What type of PR is it?
[ Bug Fix | Improvement ]
### Todos
* [x] - improve to show folder and note when finishing to use filter.
* [x] - some functions and icons next to note and folder are appeared when using filter.
* [x] - fix `Rename Note` function when using the filter.
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1864
### How should this be tested?
- **[Test 1]** Before/After using the filter, check the list structure of your notes. It must be same appearance.
- **[Test 2]** When using the filter, check the notes. Some icons and functions next to note and folder must be appeared.
- **[Test 3]** When using the filter, click `Rename Note`. It must be appeared the path of Note.
### Screenshots (if appropriate)
**Test 1**.
**Test 2**.
**Test 3**.
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/soralee/zeppelin ZEPPELIN-1864
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1834.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1834
----
commit 69d6d6d710c72e07d28e0c29978fe24e15002f8d
Author: soralee <so...@nflabs.com>
Date: 2017-01-03T09:35:55Z
Improvement to show folder and note after searching note
commit 61680e5f814ca67dc015406852315a1a92d4e7a8
Author: soralee <so...@nflabs.com>
Date: 2017-01-03T11:51:31Z
Improvement to show folder and note after searching note
commit 3e4b8ae80f53e9c7b4709bb41a65ac31b0f62fb4
Author: soralee <so...@nflabs.com>
Date: 2017-01-09T09:19:11Z
fix for that filter of navbar and home don't work
commit fd2c2438d6fbc3880194cd6c6e3ed1993b71f3a0
Author: soralee <so...@nflabs.com>
Date: 2017-01-11T06:04:53Z
resolve conflict
commit 6fb53aa420e39ee9144513d2b68521bbac1f83a5
Author: soralee <so...@nflabs.com>
Date: 2017-01-11T06:26:23Z
resolve conflict
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...
Posted by soralee <gi...@git.apache.org>.
GitHub user soralee reopened a pull request:
https://github.com/apache/zeppelin/pull/1834
[ZEPPELIN-1864] Improvement to show folder and note after searching note
### What is this PR for?
This PR is for improvement to show folder and note after using the filter. And I found some bugs and fixed like this.
the following list is improvement and bug fixed.
1. After using the filter in Zeppelin Home, every note is shown by the form [FolderName/NoteName] like below. It would be nice to show folder icon and note icon as previous status.
2. When using the filter, some functions and icons next to note and folder are disappeared.
3. When using the filter, the `Rename Note` function doesn't work. ( When I was handling this PR, this bug was discovered.)
### What type of PR is it?
[ Bug Fix | Improvement ]
### Todos
* [x] - improve to show folder and note when finishing to use filter.
* [x] - some functions and icons next to note and folder are appeared when using filter.
* [x] - fix `Rename Note` function when using the filter.
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1864
### How should this be tested?
- **[Test 1]** Before/After using the filter, check the list structure of your notes. It must be same appearance.
- **[Test 2]** When using the filter, check the notes. Some icons and functions next to note and folder must be appeared.
- **[Test 3]** When using the filter, click `Rename Note`. It must be appeared the path of Note.
### Screenshots (if appropriate)
**Test 1**.
**Test 2**.
**Test 3**.
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/soralee/zeppelin ZEPPELIN-1864
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1834.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1834
----
commit 69d6d6d710c72e07d28e0c29978fe24e15002f8d
Author: soralee <so...@nflabs.com>
Date: 2017-01-03T09:35:55Z
Improvement to show folder and note after searching note
commit 61680e5f814ca67dc015406852315a1a92d4e7a8
Author: soralee <so...@nflabs.com>
Date: 2017-01-03T11:51:31Z
Improvement to show folder and note after searching note
commit 3e4b8ae80f53e9c7b4709bb41a65ac31b0f62fb4
Author: soralee <so...@nflabs.com>
Date: 2017-01-09T09:19:11Z
fix for that filter of navbar and home don't work
commit fd2c2438d6fbc3880194cd6c6e3ed1993b71f3a0
Author: soralee <so...@nflabs.com>
Date: 2017-01-11T06:04:53Z
resolve conflict
commit 6fb53aa420e39ee9144513d2b68521bbac1f83a5
Author: soralee <so...@nflabs.com>
Date: 2017-01-11T06:26:23Z
resolve conflict
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...
Posted by soralee <gi...@git.apache.org>.
Github user soralee closed the pull request at:
https://github.com/apache/zeppelin/pull/1834
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1834: [ZEPPELIN-1864] Improvement to show folder and note af...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1834
@soralee Thanks for the update and kind reminder! Let me test again :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...
Posted by soralee <gi...@git.apache.org>.
Github user soralee closed the pull request at:
https://github.com/apache/zeppelin/pull/1834
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...
Posted by soralee <gi...@git.apache.org>.
GitHub user soralee reopened a pull request:
https://github.com/apache/zeppelin/pull/1834
[ZEPPELIN-1864] Improvement to show folder and note after searching note
### What is this PR for?
This PR is for improvement to show folder and note after using the filter. And I found some bugs and fixed like this.
the following list is improvement and bug fixed.
1. After using the filter in Zeppelin Home, every note is shown by the form [FolderName/NoteName] like below. It would be nice to show folder icon and note icon as previous status.
2. When using the filter, some functions and icons next to note and folder are disappeared.
3. When using the filter, the `Rename Note` function doesn't work. ( When I was handling this PR, this bug was discovered.)
### What type of PR is it?
[ Bug Fix | Improvement ]
### Todos
* [x] - improve to show folder and note when finishing to use filter.
* [x] - some functions and icons next to note and folder are appeared when using filter.
* [x] - fix `Rename Note` function when using the filter.
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1864
### How should this be tested?
- **[Test 1]** Before/After using the filter, check the list structure of your notes. It should be same appearance.
- **[Test 2]** When using the filter, check the notes. Some icons and functions next to note and folder should be appeared.
- **[Test 3]** When using the filter, click `Rename Note`. It should be appeared the path of Note.
### Screenshots (if appropriate)
**Test 1**.
**Test 2**.
**Test 3**.
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/soralee/zeppelin ZEPPELIN-1864
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1834.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1834
----
commit 93c4b6b17cdfa6bfde7ac000f7743971f41b7640
Author: soralee <so...@nflabs.com>
Date: 2017-01-03T09:35:55Z
Improvement to show folder and note after searching note
commit b11ec620ddf44c0c76f2e61e7db7fa1d9a69e755
Author: soralee <so...@nflabs.com>
Date: 2017-01-03T11:51:31Z
Improvement to show folder and note after searching note
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1834: [ZEPPELIN-1864] Improvement to show folder and note af...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/1834
Thank you @AhyoungRyu :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---