[jira] [Commented] (YARN-9026) DefaultOOMHandler should mark preempted containers as killed

["Zhankun Tang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-9026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690943#comment-16690943 ] 

Zhankun Tang commented on YARN-9026:
------------------------------------

Thanks [~haibochen] . I'm not that familiar with this part. Just check the code of ContainerLaunch#handleContainerExitCode, the exit code 137(FORCE_KILLED) which represent "killed" is already marked as killed? Please correct me if I missed something important.
{code:java}
if (exitCode == ExitCode.FORCE_KILLED.getExitCode()
 || exitCode == ExitCode.TERMINATED.getExitCode()) {
 // If the process was killed, Send container_cleanedup_after_kill and
 // just break out of this method.
 dispatcher.getEventHandler().handle(
 new ContainerExitEvent(containerId,
 ContainerEventType.CONTAINER_KILLED_ON_REQUEST, exitCode,
 diagnosticInfo.toString()));
}{code}

> DefaultOOMHandler should mark preempted containers as killed
> ------------------------------------------------------------
>
>                 Key: YARN-9026
>                 URL: https://issues.apache.org/jira/browse/YARN-9026
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: nodemanager
>    Affects Versions: 3.2.1
>            Reporter: Haibo Chen
>            Priority: Major
>
> DefaultOOMHandler today kills a selected container by sending kill -9 signal to all processes running within the container cgroup.
> The container would exit with a non-zero code, and hence treated as a failure by ContainerLaunch threads.
> We should instead mark the containers as killed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org