You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/10 18:42:17 UTC

[GitHub] [incubator-superset] riahk opened a new pull request #10829: fix: update the time filter for 'Last Year' option in explore

riahk opened a new pull request #10829:
URL: https://github.com/apache/incubator-superset/pull/10829


   ### SUMMARY
   Currently in the explore > time > defaults > LAST YEAR filter, relative time is used, resulting in a filter that shows the past 365 days from the current date. We want it to apply to the full previous year (in this case, 01/01/2019-01/01/2020).
   
   - [x] Update `moment` logic in `DateFilterControl` for `years` unit
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   <img width="419" alt="Screen Shot 2020-09-09 at 11 17 34 AM" src="https://user-images.githubusercontent.com/8216382/92782671-01248c00-f35a-11ea-988e-90fbab9f1052.png">
   After:
   <img width="420" alt="Screen Shot 2020-09-09 at 11 33 53 AM" src="https://user-images.githubusercontent.com/8216382/92782647-fbc74180-f359-11ea-81df-ed242fa0bd2e.png">
   
   ### TEST PLAN
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] willbarrett merged pull request #10829: fix: update the time filter for 'Last Year' option in explore

Posted by GitBox <gi...@apache.org>.
willbarrett merged pull request #10829:
URL: https://github.com/apache/incubator-superset/pull/10829


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] willbarrett commented on pull request #10829: fix: update the time filter for 'Last Year' option in explore

Posted by GitBox <gi...@apache.org>.
willbarrett commented on pull request #10829:
URL: https://github.com/apache/incubator-superset/pull/10829#issuecomment-691516224


   Let's get some tests around this. Date functionality is weird enough :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] willbarrett commented on pull request #10829: fix: update the time filter for 'Last Year' option in explore

Posted by GitBox <gi...@apache.org>.
willbarrett commented on pull request #10829:
URL: https://github.com/apache/incubator-superset/pull/10829#issuecomment-691516224






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] willbarrett commented on pull request #10829: fix: update the time filter for 'Last Year' option in explore

Posted by GitBox <gi...@apache.org>.
willbarrett commented on pull request #10829:
URL: https://github.com/apache/incubator-superset/pull/10829#issuecomment-691516224






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10829: fix: update the time filter for 'Last Year' option in explore

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10829:
URL: https://github.com/apache/incubator-superset/pull/10829#issuecomment-690792559


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10829?src=pr&el=h1) Report
   > Merging [#10829](https://codecov.io/gh/apache/incubator-superset/pull/10829?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3ae80d3b98f9d27bc5a0a49bb7c87c3924281196?el=desc) will **increase** coverage by `4.24%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10829/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10829?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10829      +/-   ##
   ==========================================
   + Coverage   61.23%   65.47%   +4.24%     
   ==========================================
     Files         802      803       +1     
     Lines       37815    37930     +115     
     Branches     3557     3559       +2     
   ==========================================
   + Hits        23155    24836    +1681     
   + Misses      14474    12988    -1486     
   + Partials      186      106      -80     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `55.82% <100.00%> (?)` | |
   | #javascript | `61.58% <100.00%> (-0.05%)` | :arrow_down: |
   | #python | `61.16% <ø> (+0.17%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10829?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../explore/components/controls/DateFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC5qc3g=) | `65.47% <100.00%> (+12.78%)` | :arrow_up: |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `66.66% <0.00%> (-3.34%)` | :arrow_down: |
   | [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.36% <0.00%> (-3.06%)` | :arrow_down: |
   | [...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0FkZERhdGFzZXRNb2RhbC50c3g=) | `57.57% <0.00%> (-2.43%)` | :arrow_down: |
   | [...rontend/src/components/ErrorMessage/ErrorAlert.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Vycm9yQWxlcnQudHN4) | `20.83% <0.00%> (-1.62%)` | :arrow_down: |
   | [...tend/src/views/CRUD/data/database/DatabaseList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZUxpc3QudHN4) | `86.95% <0.00%> (-1.38%)` | :arrow_down: |
   | [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `53.70% <0.00%> (-0.85%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.61% <0.00%> (-0.68%)` | :arrow_down: |
   | [...frontend/src/views/CRUD/welcome/DashboardTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9EYXNoYm9hcmRUYWJsZS50c3g=) | `78.37% <0.00%> (-0.57%)` | :arrow_down: |
   | [...src/components/FilterableTable/FilterableTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS50c3g=) | `81.68% <0.00%> (-0.50%)` | :arrow_down: |
   | ... and [196 more](https://codecov.io/gh/apache/incubator-superset/pull/10829/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10829?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10829?src=pr&el=footer). Last update [3ae80d3...b63167c](https://codecov.io/gh/apache/incubator-superset/pull/10829?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10829: fix: update the time filter for 'Last Year' option in explore

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10829:
URL: https://github.com/apache/incubator-superset/pull/10829#issuecomment-690792559


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10829?src=pr&el=h1) Report
   > Merging [#10829](https://codecov.io/gh/apache/incubator-superset/pull/10829?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3ae80d3b98f9d27bc5a0a49bb7c87c3924281196?el=desc) will **increase** coverage by `4.15%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10829/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10829?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10829      +/-   ##
   ==========================================
   + Coverage   61.23%   65.38%   +4.15%     
   ==========================================
     Files         802      803       +1     
     Lines       37815    37930     +115     
     Branches     3557     3559       +2     
   ==========================================
   + Hits        23155    24801    +1646     
   + Misses      14474    13020    -1454     
   + Partials      186      109      -77     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `55.37% <100.00%> (?)` | |
   | #javascript | `61.58% <100.00%> (-0.05%)` | :arrow_down: |
   | #python | `61.16% <ø> (+0.17%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10829?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../explore/components/controls/DateFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC5qc3g=) | `65.47% <100.00%> (+12.78%)` | :arrow_up: |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `66.66% <0.00%> (-3.34%)` | :arrow_down: |
   | [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.36% <0.00%> (-3.06%)` | :arrow_down: |
   | [...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0FkZERhdGFzZXRNb2RhbC50c3g=) | `57.57% <0.00%> (-2.43%)` | :arrow_down: |
   | [...rontend/src/components/ErrorMessage/ErrorAlert.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Vycm9yQWxlcnQudHN4) | `20.83% <0.00%> (-1.62%)` | :arrow_down: |
   | [...tend/src/views/CRUD/data/database/DatabaseList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZUxpc3QudHN4) | `86.95% <0.00%> (-1.38%)` | :arrow_down: |
   | [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `53.70% <0.00%> (-0.85%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.61% <0.00%> (-0.68%)` | :arrow_down: |
   | [...frontend/src/views/CRUD/welcome/DashboardTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9EYXNoYm9hcmRUYWJsZS50c3g=) | `78.37% <0.00%> (-0.57%)` | :arrow_down: |
   | [...src/components/FilterableTable/FilterableTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS50c3g=) | `81.68% <0.00%> (-0.50%)` | :arrow_down: |
   | ... and [194 more](https://codecov.io/gh/apache/incubator-superset/pull/10829/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10829?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10829?src=pr&el=footer). Last update [3ae80d3...b63167c](https://codecov.io/gh/apache/incubator-superset/pull/10829?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] willbarrett merged pull request #10829: fix: update the time filter for 'Last Year' option in explore

Posted by GitBox <gi...@apache.org>.
willbarrett merged pull request #10829:
URL: https://github.com/apache/incubator-superset/pull/10829


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org