You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:11:12 UTC

[GitHub] [shardingsphere] strongduanmu opened a new issue #10868: Refactor FederateStatementTest & FederatePrepareStatementTest with shardingsphere-integration-test

strongduanmu opened a new issue #10868:
URL: https://github.com/apache/shardingsphere/issues/10868


   Currently `FederateStatementTest` and `FederatePrepareStatementTest` use JUNIT to test the following SQL statements. In order to improve test coverage and code elegance, we need to migrate the test scenarios of FederateStatementTest and FederatePrepareStatementTest to `shardingsphere-integration-test`. 
   
   ```sql
   select o.*, i.* from t_order_federate o, t_order_item_federate i where o.order_id = ? and i.item_id = ?
   
   select t_order_federate.*, t_order_item_federate_sharding.* "
                       + "from t_order_federate, t_order_item_federate_sharding "
                       + "where t_order_federate.order_id = t_order_item_federate_sharding.item_id "
                       + "AND t_order_item_federate_sharding.order_id = ?
   
   select o.*, i.* from t_order_federate o, t_order_item_federate_sharding i "
                       + "where o.order_id = i.item_id AND i.order_id = ?
   
   select t_order_federate.*, t_order_item_federate_sharding.* "
                       + "from t_order_federate, t_order_item_federate_sharding "
                       + "where t_order_federate.order_id = t_order_item_federate_sharding.item_id "
                       + "AND t_order_item_federate_sharding.remarks = 't_order_item_federate_sharding' "
                       + "AND t_order_item_federate_sharding.user_id = ?
   
   select t_user_encrypt_federate.user_id, t_user_encrypt_federate.pwd, t_user_info.information from t_user_encrypt_federate, t_user_info "
                       + "where t_user_encrypt_federate.user_id = t_user_info.user_id and t_user_encrypt_federate.user_id > ?
   
   select t_user_encrypt_federate_sharding.user_id, t_user_encrypt_federate_sharding.pwd, t_user_info.information from t_user_encrypt_federate_sharding, t_user_info "
               + "where t_user_encrypt_federate_sharding.user_id = t_user_info.user_id and t_user_encrypt_federate_sharding.user_id > ?
   
   select o.order_id_sharding, i.order_id from t_order_federate_sharding o, t_order_item_federate_sharding i "
                       + "where o.order_id_sharding = i.item_id and i.order_id > ?
   
   SELECT user_id, SUM(order_id_sharding) FROM t_order_federate_sharding GROUP BY user_id HAVING SUM(order_id_sharding) > ?
   
   SELECT (SELECT MAX(user_id) FROM t_order_federate_sharding) max_user_id, order_id_sharding, status FROM t_order_federate_sharding WHERE order_id_sharding > ?
   
   SELECT SUM(DISTINCT user_id), SUM(order_id_sharding) FROM t_order_federate_sharding WHERE order_id_sharding > ?
   ...
   ```
   
   In order to accomplish this task, you need to understand the [documentation](https://shardingsphere.apache.org/document/current/cn/features/test-engine/integration-test/) of the integration test first, and then start the refactoring work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] LeeGuoPing commented on issue #10868: Refactor SELECT_SQL_BY_ID_ACROSS_SINGLE_AND_SHARDING_TABLES statement with shardingsphere-integration-test

Posted by GitBox <gi...@apache.org>.
LeeGuoPing commented on issue #10868:
URL: https://github.com/apache/shardingsphere/issues/10868#issuecomment-889686031


   I have finished it @strongduanmu


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on issue #10868: Refactor FederateStatementTest & FederatePrepareStatementTest with shardingsphere-integration-test

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #10868:
URL: https://github.com/apache/shardingsphere/issues/10868#issuecomment-864839434


   > Hi, Can I work on this issue?
   
   @LeeGuoPing I'm very sorry, this issue is prepared for OSD2021, please see if you are interested in other issues.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] LeeGuoPing commented on issue #10868: Refactor SELECT_SQL_BY_ID_ACROSS_SINGLE_AND_SHARDING_TABLES statement with shardingsphere-integration-test

Posted by GitBox <gi...@apache.org>.
LeeGuoPing commented on issue #10868:
URL: https://github.com/apache/shardingsphere/issues/10868#issuecomment-882957024


   ok


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] LeeGuoPing commented on issue #10868: Refactor SELECT_SQL_BY_ID_ACROSS_SINGLE_AND_SHARDING_TABLES statement with shardingsphere-integration-test

Posted by GitBox <gi...@apache.org>.
LeeGuoPing commented on issue #10868:
URL: https://github.com/apache/shardingsphere/issues/10868#issuecomment-882957024


   ok


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on issue #10868: Refactor SELECT_SQL_BY_ID_ACROSS_SINGLE_AND_SHARDING_TABLES statement with shardingsphere-integration-test

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #10868:
URL: https://github.com/apache/shardingsphere/issues/10868#issuecomment-889694536


   > I have finished it @strongduanmu
   
   @LeeGuoPing Thank you for your effort, I will review this pr.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on issue #10868: Refactor SELECT_SQL_BY_ID_ACROSS_SINGLE_AND_SHARDING_TABLES statement with shardingsphere-integration-test

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #10868:
URL: https://github.com/apache/shardingsphere/issues/10868#issuecomment-882949264


   @LeeGuoPing Hi this issue is open now, would you like to have a try?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on issue #10868: Refactor FederateStatementTest & FederatePrepareStatementTest with shardingsphere-integration-test

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #10868:
URL: https://github.com/apache/shardingsphere/issues/10868#issuecomment-864839434


   > Hi, Can I work on this issue?
   
   @LeeGuoPing I'm very sorry, this issue is prepared for OSD2021, please see if you are interested in other issues.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on issue #10868: Refactor SELECT_SQL_BY_ID_ACROSS_SINGLE_AND_SHARDING_TABLES statement with shardingsphere-integration-test

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #10868:
URL: https://github.com/apache/shardingsphere/issues/10868#issuecomment-882949264


   @LeeGuoPing Hi this issue is open now, would you like to have a try?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] LeeGuoPing commented on issue #10868: Refactor FederateStatementTest & FederatePrepareStatementTest with shardingsphere-integration-test

Posted by GitBox <gi...@apache.org>.
LeeGuoPing commented on issue #10868:
URL: https://github.com/apache/shardingsphere/issues/10868#issuecomment-864834745


   Hi, Can I work on this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu closed issue #10868: Refactor SELECT_SQL_BY_ID_ACROSS_SINGLE_AND_SHARDING_TABLES statement with shardingsphere-integration-test

Posted by GitBox <gi...@apache.org>.
strongduanmu closed issue #10868:
URL: https://github.com/apache/shardingsphere/issues/10868


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] LeeGuoPing commented on issue #10868: Refactor FederateStatementTest & FederatePrepareStatementTest with shardingsphere-integration-test

Posted by GitBox <gi...@apache.org>.
LeeGuoPing commented on issue #10868:
URL: https://github.com/apache/shardingsphere/issues/10868#issuecomment-864834745


   Hi, Can I work on this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] LeeGuoPing commented on issue #10868: Refactor SELECT_SQL_BY_ID_ACROSS_SINGLE_AND_SHARDING_TABLES statement with shardingsphere-integration-test

Posted by GitBox <gi...@apache.org>.
LeeGuoPing commented on issue #10868:
URL: https://github.com/apache/shardingsphere/issues/10868#issuecomment-882957024


   ok


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on issue #10868: Refactor SELECT_SQL_BY_ID_ACROSS_SINGLE_AND_SHARDING_TABLES statement with shardingsphere-integration-test

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #10868:
URL: https://github.com/apache/shardingsphere/issues/10868#issuecomment-882949264


   @LeeGuoPing Hi this issue is open now, would you like to have a try?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org