You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@giraph.apache.org by "Eli Reisman (JIRA)" <ji...@apache.org> on 2013/01/31 19:09:13 UTC

[jira] [Commented] (GIRAPH-493) Remove EdgeWithSource

    [ https://issues.apache.org/jira/browse/GIRAPH-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13567885#comment-13567885 ] 

Eli Reisman commented on GIRAPH-493:
------------------------------------

I'm +1 on this, but maybe Alessandro would want to take a peek too?

                
> Remove EdgeWithSource
> ---------------------
>
>                 Key: GIRAPH-493
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-493
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Nitay Joffe
>            Assignee: Nitay Joffe
>         Attachments: GIRAPH-493.patch
>
>
> We create a lot of EdgeWithSource (one per edge read) only to grab the sourceID / Edge out of them right after. Since we are not actually keeping these objects around we might as well just make the interface getSourceId() and getEdge() instead of the current get edge with source, and save on creating all of these objects.
> https://reviews.apache.org/r/9162/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira