[jira] [Commented] (OAK-2464) Optimize read of known non-existing children

["Marcel Reutegger (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297061#comment-14297061 ] 

Marcel Reutegger commented on OAK-2464:
---------------------------------------

Thanks for the patch Vikas.

There are some minor things to improve, like log calls with arguments instead of concatenating strings.

I also had a conversation with Chetan about sorting the list. The list is actually already sorted, but we need to double-check if the sort order of our DocumentStore implementations are really the same as in Java. We can then do a binary search on the list and don't need to scan it completely.

> Optimize read of known non-existing children
> --------------------------------------------
>
>                 Key: OAK-2464
>                 URL: https://issues.apache.org/jira/browse/OAK-2464
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>            Reporter: Vikas Saurabh
>            Priority: Minor
>         Attachments: 0001-OAK-2464-Optimize-read-of-known-non-existing-childre.patch
>
>
> Reading a non-existing node always queries down to {{DocumentStore}}. {{DocumentNodeStore}} should consider {{nodeChildrenCache}} to see if it already knows about non-existence and avoid a look up into {{DocumentStore}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)