You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by clebertsuconic <gi...@git.apache.org> on 2016/08/08 23:31:31 UTC
[GitHub] activemq-artemis pull request #706: ARTEMIS-671 Returning messages after con...
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/706
ARTEMIS-671 Returning messages after connection killed, and validating usage of reconnect
just for review for now... I'm running the full testsuite... will give an ok after it's done
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsuconic/activemq-artemis TCPClose
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/706.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #706
----
commit 00383abaac7b7be651975c01127e9d2b3ac0ff2d
Author: Clebert Suconic <cl...@apache.org>
Date: 2016-08-08T23:29:27Z
ARTEMIS-671 Returning messages after connection killed, and validating usage of reconnect
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #706: ARTEMIS-671 Returning messages after connection...
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on the issue:
https://github.com/apache/activemq-artemis/pull/706
BTW -> SOP = System.out.println instead of logging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #706: ARTEMIS-671 Returning messages after con...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/706#discussion_r73986565
--- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/logs/AssertionLoggerHandler.java ---
@@ -71,6 +71,26 @@ public static boolean hasLevel(Level level) {
return false;
}
+ public static void dump() {
+ for (Map.Entry<String, ExtLogRecord> entry : messages.entrySet()) {
+ System.out.println(entry.getKey());
--- End diff --
Well.. it's useless anyway.. will remove it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #706: ARTEMIS-671 Returning messages after con...
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/706#discussion_r73975246
--- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/logs/AssertionLoggerHandler.java ---
@@ -71,6 +71,26 @@ public static boolean hasLevel(Level level) {
return false;
}
+ public static void dump() {
+ for (Map.Entry<String, ExtLogRecord> entry : messages.entrySet()) {
+ System.out.println(entry.getKey());
--- End diff --
Errr SOP?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #706: ARTEMIS-671 Returning messages after con...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/706
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #706: ARTEMIS-671 Returning messages after connection...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/706
@johnament I see.. it was intentionally SOP then... it would be on junit reports... it was from the test logger.. but it's been removed now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #706: ARTEMIS-671 Returning messages after connection...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/706
I have finished the full testsuite run on this branch. a nice run.
If any objections.. this is good to be merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #706: ARTEMIS-671 Returning messages after con...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/706#discussion_r73986215
--- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/logs/AssertionLoggerHandler.java ---
@@ -71,6 +71,26 @@ public static boolean hasLevel(Level level) {
return false;
}
+ public static void dump() {
+ for (Map.Entry<String, ExtLogRecord> entry : messages.entrySet()) {
+ System.out.println(entry.getKey());
--- End diff --
That's for debug only?
What SOP means?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---