You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by ad...@apache.org on 2016/01/29 22:28:50 UTC

[5/8] incubator-kudu git commit: cmake: remove unnecessary link_directories()

cmake: remove unnecessary link_directories()

While trying to reduce my unit tests' rpath, I stumbled upon this. It's no
longer necessary (perhaps due to the llvm 3.7 upgrade), and removing it
trims the library search path and rpath for all binaries.

In the end shortening the rpaths didn't help (chrpath refuses to grow a
binary's rpath, only rewrite it), but I think the patch still makes sense.

Change-Id: I60af144c324cc41bf01b3d878a549530f578fec8
Reviewed-on: http://gerrit.cloudera.org:8080/1941
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins


Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/2277d8d7
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/2277d8d7
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/2277d8d7

Branch: refs/heads/master
Commit: 2277d8d786268973292e98d5847f2877a8af66f6
Parents: f3f3996
Author: Adar Dembo <ad...@cloudera.com>
Authored: Wed Jan 27 19:49:54 2016 -0800
Committer: Adar Dembo <ad...@cloudera.com>
Committed: Fri Jan 29 20:05:57 2016 +0000

----------------------------------------------------------------------
 CMakeLists.txt | 1 -
 1 file changed, 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/2277d8d7/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/CMakeLists.txt b/CMakeLists.txt
index ae0e328..5bbcd08 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -804,7 +804,6 @@ if(${LLVM_PACKAGE_VERSION} VERSION_LESS 3.4)
 endif()
 message(STATUS "Found LLVM ${LLVM_PACKAGE_VERSION}")
 message(STATUS "Using LLVMConfig.cmake in: ${LLVM_DIR}")
-link_directories(${LLVM_LIBRARY_DIRS})
 
 ## librt
 if (NOT APPLE)