You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/12/13 20:23:32 UTC
[GitHub] [druid] somu-imply opened a new pull request #12060: IN filters for numeric go through selector filters and in filters now
somu-imply opened a new pull request #12060:
URL: https://github.com/apache/druid/pull/12060
Instead of using BoundFilters for numeric IN clauses, they now get converted to SelectorDimFilter which later gets converted to an IN filter. Querying over wikipedia dataset with 10K in clauses with a query `SELECT regionName, user, count(*) as cnt
FROM wikipedia
WHERE metroCode IN (all 10K values here separated by commas)
GROUP BY 1,2`
finished in 10sec
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] JulianJaffePinterest commented on pull request #12060: IN filters for numeric go through selector filters and in filters now
Posted by GitBox <gi...@apache.org>.
JulianJaffePinterest commented on pull request #12060:
URL: https://github.com/apache/druid/pull/12060#issuecomment-1012009899
Do you know how much of the 10 second runtime was planning vs execution? (e.g. does this fix resolve #7904 and the 10 seconds are due to execution, or is there still additional room for improvement in planning large IN clauses?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] somu-imply closed pull request #12060: IN filters for numeric go through selector filters and in filters now
Posted by GitBox <gi...@apache.org>.
somu-imply closed pull request #12060:
URL: https://github.com/apache/druid/pull/12060
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org