You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by bm...@apache.org on 2015/09/04 21:15:01 UTC
mesos git commit: Removed remnants of LIBPROCESS_STATISTICS_WINDOW.
Repository: mesos
Updated Branches:
refs/heads/master b6f3d9b56 -> 7f2bcc7d7
Removed remnants of LIBPROCESS_STATISTICS_WINDOW.
Review: https://reviews.apache.org/r/37699
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/7f2bcc7d
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/7f2bcc7d
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/7f2bcc7d
Branch: refs/heads/master
Commit: 7f2bcc7d7171582bb731f030504a063bc5c7c5a1
Parents: b6f3d9b
Author: Greg Mann <gr...@mesosphere.io>
Authored: Fri Sep 4 12:14:52 2015 -0700
Committer: Benjamin Mahler <be...@gmail.com>
Committed: Fri Sep 4 12:14:53 2015 -0700
----------------------------------------------------------------------
3rdparty/libprocess/src/process.cpp | 20 --------------------
1 file changed, 20 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/7f2bcc7d/3rdparty/libprocess/src/process.cpp
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/src/process.cpp b/3rdparty/libprocess/src/process.cpp
index 755187c..0e5394a 100644
--- a/3rdparty/libprocess/src/process.cpp
+++ b/3rdparty/libprocess/src/process.cpp
@@ -474,9 +474,6 @@ THREAD_LOCAL ProcessBase* __process__ = NULL;
// Per thread executor pointer.
THREAD_LOCAL Executor* _executor_ = NULL;
-// TODO(dhamon): Reintroduce this when it is plumbed through to Statistics.
-// const Duration LIBPROCESS_STATISTICS_WINDOW = Days(1);
-
// NOTE: Clock::* implementations are in clock.cpp except for
// Clock::settle which currently has a dependency on
@@ -974,23 +971,6 @@ void initialize(const string& delegate)
// Create the global system statistics process.
spawn(new System(), true);
- // Create the global statistics.
- // TODO(dhamon): Plumb this through to metrics.
- // value = os::getenv("LIBPROCESS_STATISTICS_WINDOW");
- // if (value.isSome()) {
- // Try<Duration> window = Duration::parse(value.get());
- // if (window.isError()) {
- // LOG(FATAL) << "LIBPROCESS_STATISTICS_WINDOW=" << value.get()
- // << " is not a valid duration: " << window.error();
- // }
- // statistics = new Statistics(window.get());
- // } else {
- // // TODO(bmahler): Investigate memory implications of this window
- // // size. We may also want to provide a maximum memory size rather than
- // // time window. Or, offload older data to disk, etc.
- // statistics = new Statistics(LIBPROCESS_STATISTICS_WINDOW);
- // }
-
// Ensure metrics process is running.
// TODO(bmahler): Consider initializing this consistently with
// the other global Processes.