[GitHub] [netbeans] ppisl commented on a change in pull request #3881: Fetch richer problem info from gradle daemon

[GitBox <gi...@apache.org>]

ppisl commented on a change in pull request #3881:
URL: https://github.com/apache/netbeans/pull/3881#discussion_r838261071



##########
File path: extide/gradle/netbeans-gradle-tooling/src/main/java/org/netbeans/modules/gradle/api/NbProjectInfo.java
##########
@@ -41,5 +41,22 @@
      */    
     Map<String, Object> getExt();
     Set<String> getProblems();
+
+    /**
+     * @since 2.23
+     */

Review comment:
       It's API, shouldn't we add some basic JavaDoc?

##########
File path: extide/gradle/netbeans-gradle-tooling/src/main/java/org/netbeans/modules/gradle/api/NbProjectInfo.java
##########
@@ -41,5 +41,22 @@
      */    
     Map<String, Object> getExt();
     Set<String> getProblems();
+
+    /**
+     * @since 2.23
+     */
+    Set<Report> getReports();
+    
     boolean getMiscOnly();
+    
+    /**
+     * @since 2.23
+     */
+    interface Report {
+        public String getErrorClass();
+        public String getScriptLocation();

Review comment:
       It would be useful to have a JavaDoc here, without an explanation seems to be strange that a method called **getScriptLocation()** returns a String. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists