Re: [PR] PHOENIX-7601 Use synchronous replication in Phoenix coprocs on the write path [phoenix]

["kadirozde (via GitHub)" <gi...@apache.org>]

kadirozde commented on code in PR #2192:
URL: https://github.com/apache/phoenix/pull/2192#discussion_r2182672061


##########
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##########
@@ -448,6 +515,23 @@ public void start(CoprocessorEnvironment e) throws IOException {
           BloomType bloomFilterType = tableDescriptor.getColumnFamilies()[0].getBloomFilterType();
           // when the table descriptor changes, the coproc is reloaded
           this.useBloomFilter = bloomFilterType == BloomType.ROW;
+          byte[] tableName = env.getRegionInfo().getTable().getName();
+          boolean isSystemTable = SchemaUtil.isSystemTable(tableName);

Review Comment:
   I think we should move this check into a method in SchemaUtil. There we need to state that it is assumed that DDL statements that are executed within global (not tenant specific) connections are executed by an admin or a admin process in each clusters separately and thus are not replicated via the HBase or Phoenix replication. We also need to go through for each system table and explain why we do not replicate them. I feel that we may need to replicate them. It is okay to have a TO DO for them in this PR and revisit them later in a separate Jira.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org