You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Taragolis (via GitHub)" <gi...@apache.org> on 2023/02/04 16:36:04 UTC

[GitHub] [airflow] Taragolis opened a new pull request, #29374: Use rfc3339 compatible datetime in Param validation

Taragolis opened a new pull request, #29374:
URL: https://github.com/apache/airflow/pull/29374

   Our canary build/test failed on validation date-time param, the reason new version of `openapi-schema-validator` now use `rfc3339-validator`, and this change behaviour for `jsonschema` validation.
   
   ```diff
   
   332c332
   < openapi-schema-validator==0.4.2
   ---
   > openapi-schema-validator==0.4.3
   439a440
   > rfc3339-validator==0.1.4
   ```
   
   List of changes applied by this PR:
   1. Bump version of `jsonschema` to 4+, in this version `jsonschema` drop support `strict-rfc3339` and only use `rfc3339-validator` if it installed. This mostly for avoid to use another rfc3339 validation method.
   2. Make `rfc3339-validator` as core dependency
   3. Convert valid ISO8601 values to RFC3339
   4. Change example_params_ui_tutorial DAG's parameters to RFC3339


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] Taragolis commented on pull request #29374: Use rfc3339 compatible datetime in Param validation

Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on PR #29374:
URL: https://github.com/apache/airflow/pull/29374#issuecomment-1418756799

   One part fixed another part broken, classic. I will have a look later in a day what can I do with REST API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] Taragolis closed pull request #29374: Use rfc3339 compatible datetime in Param validation

Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis closed pull request #29374: Use rfc3339 compatible datetime in Param validation
URL: https://github.com/apache/airflow/pull/29374


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] Taragolis commented on pull request #29374: Use rfc3339 compatible datetime in Param validation

Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on PR #29374:
URL: https://github.com/apache/airflow/pull/29374#issuecomment-1420688172

   closed in favor of #29395


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org