You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2016/09/09 22:38:58 UTC

Review Request 51776: GEODE-1881: Support null map keys in CompactMapRangeIndex

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51776/
-----------------------------------------------------------

Review request for geode and Jason Huynh.


Repository: geode


Description
-------

Allow indexing maps with null keys by storing the keys as
IndexManager.NULL.


Diffs
-----

  geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/CompactMapRangeIndex.java c374a101714b70c231424645969b492a015cdcf8 
  geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/CompactRangeIndexJUnitTest.java f01f925d8fe8b9bca245f94257fdce144ff00ca0 

Diff: https://reviews.apache.org/r/51776/diff/


Testing
-------


Thanks,

Dan Smith


Re: Review Request 51776: GEODE-1881: Support null map keys in CompactMapRangeIndex

Posted by xiaojian zhou <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51776/#review148554
-----------------------------------------------------------


Ship it!




Ship It!

- xiaojian zhou


On Sept. 9, 2016, 10:38 p.m., Dan Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51776/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2016, 10:38 p.m.)
> 
> 
> Review request for geode and Jason Huynh.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Allow indexing maps with null keys by storing the keys as
> IndexManager.NULL.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/CompactMapRangeIndex.java c374a101714b70c231424645969b492a015cdcf8 
>   geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/CompactRangeIndexJUnitTest.java f01f925d8fe8b9bca245f94257fdce144ff00ca0 
> 
> Diff: https://reviews.apache.org/r/51776/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Smith
> 
>