You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/28 10:26:04 UTC
[GitHub] [incubator-nuttx-apps] rurtle opened a new pull request #446: Fix for nuttx issue 1883
rurtle opened a new pull request #446:
URL: https://github.com/apache/incubator-nuttx-apps/pull/446
## Summary
Fix for nuttx [issue # 1883](https://github.com/apache/incubator-nuttx/issues/1883). When proc file-system is not mounted, running ifconfig should give output as "ifconfig: procfs is not mounted" instead of "ifconfig: opendir failed: 20".
Addressed review comments from @v01d & @xiaoxiang781216. For more details, please refer to [pull request 443](https://github.com/apache/incubator-nuttx-apps/pull/443). Based on the discussion, the error message should now be "**Could not open <dir/file name> (is procfs mounted?)**" at all relevant places.
## Impact
When proc file-system is not mounted, running ifconfig should give output as "ifconfig: procfs is not mounted" instead of "ifconfig: opendir failed: 20".
## Testing
Should be built and tested against relevant h/w platforms.
__Since I don't have necessary h/w platform yet, couldn't test functionality on real hardware by (un/re)mounting procfs.__
**P.S.** I shall send a separate pull request dealing with coding standards related issues in nsh_fsutils.c.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #446: Fix for nuttx issue 1883
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #446:
URL: https://github.com/apache/incubator-nuttx-apps/pull/446#issuecomment-717914857
LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #446: Fix for nuttx issue 1883
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #446:
URL: https://github.com/apache/incubator-nuttx-apps/pull/446
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org