You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@datasketches.apache.org by "notfilippo (via GitHub)" <gi...@apache.org> on 2026/01/02 10:49:56 UTC
[PR] docs: document release process (datasketches-rust)
notfilippo opened a new pull request, #61:
URL: https://github.com/apache/datasketches-rust/pull/61
Related to #57 .
Attempt to document a potential release process.
cc @leerho @freakyzoidberg @tisonkun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] docs: document release process (datasketches-rust)
Posted by "notfilippo (via GitHub)" <gi...@apache.org>.
notfilippo commented on code in PR #61:
URL: https://github.com/apache/datasketches-rust/pull/61#discussion_r2657520264
##########
RELEASE.md:
##########
@@ -0,0 +1,301 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# Release process for Rust components
+
+**NOTES:**
+
+* This process covers major and minor releases only. Bug-fix releases, which increment the third digit, are performed on
+ an A.B.X branch and not on main, but otherwise follow a similar process.
+* Some of these operations can be performed either on the Command-Line or in your IDE, whatever you prefer.
+
+## Preparation
+
+### Verify project health
+
+* Confirm correctness for:
+ * LICENSE
+ * NOTICE -- check for copyright dates
+ * README.md
+ * .asf.yaml
+ * .gitignore
+ * Cargo.toml -- ensure workspace metadata is correct
+
+* From Command Line or IDE:
+ * Run all checks: `cargo x lint`
+ * Run unit tests: `cargo x test`
+ * Run `cargo update` to ensure Cargo.lock is updated
+ <!-- TODO: * Run code coverage: `cargo llvm-cov --workspace` (target > 90%). -->
+ * Run tests on all platforms (see CI workflow)
+ * Confirm that documentation builds: `cargo doc --open`
+ * Confirm that all **temporary** branches are checked into main and/or deleted, both local and remote
+ * Confirm any new bug fixes have corresponding tests
+ * Check that all dependencies are at stable versions (no pre-release dependencies in Cargo.toml)
+
+### Verify release tooling
+
+* From Command Line at project root:
+ * Confirm GitHub repository is current and git status is clean
+ * Ensure you have publishing credentials configured:
+ * If not set: `cargo login` and enter your crates.io API token
+ * At major version releases, search for deprecated code and remove at **Major Versions** only:
+ * `grep -r "deprecated" --include="*.rs" src/`
+
+## Create permanent release branch & release candidate version preparation
+
+* From IDE or Command Line:
+ * Create new **Permanent Branch**: "A.B.X"
+ * Modify `datasketches/Cargo.toml` version:
+ * Change version to `version = "A.B.X"`
+ * Commit the changes with message: "chore: prepare A.B.X release"
+ * Write down the Git hash: example: 40c6f4f
+ * Push Branch "A.B.X" to origin:
+ * `git push -u origin A.B.X`
+ * Do explicit push of tags on branch "A.B.X" to origin:
+ * `git push origin --tags`
+ * **DO NOT MERGE THIS PERMANENT BRANCH INTO THE DEFAULT BRANCH**
+
+* From a web browser at origin website: github.com/apache/datasketches-rust
+ * Select the A.B.X branch
+ * Confirm that the tag: A.B.X-rc.1 exists and that the tag is on the latest commit with the correct Git hash
+ * **DO NOT CREATE PR OR MERGE THIS PERMANENT BRANCH INTO THE DEFAULT BRANCH**
+
+## Publish release candidate to crates.io
+
+**IMPORTANT:** This step publishes a pre-release version to crates.io for community testing. The `-rc.N` suffix
+indicates this is not a final release.
+
+* Return to release branch A.B.X:
+ * `git checkout A.B.X`
+* Create Annotated TAG: A.B.X-rc.1
+ * `git tag -a A.B.X-rc.1 -m "release candidate 1 for version A.B.X"`
+* Modify `datasketches/Cargo.toml` version **temporarily**:
+ * Change version to `version = "A.B.X-rc.1"`
+* Review the package contents:
+ * `cargo package --list -p datasketches`
+ * Ensure no unwanted files are included
+ * Verify LICENSE, NOTICE, README.md are included
+* Run publish in dry-run and verify output:
+ * `cargo publish --dry-run -p datasketches`
+* Publish to crates.io:
+ * `cargo publish -p datasketches`
+* Verify the published crate:
+ * Visit https://crates.io/crates/datasketches
+ * Confirm A.B.X-rc.1 is visible
+ * Test installation: `cargo add datasketches@A.B.X-rc.1` in a test project
+* Reset all temporary changes with `git checkout -f A.B.X`:
+ * `cat datasketches/Cargo.toml | grep version` # should show A.B.X
+
+## Create and/or checkout local *dist/dev* directories on your system
+
+* If you have not already, on your system create the two directory structures that mirror the dist.apache.org/repos/
+ directories:
+ * `mkdir -p dist/dev/datasketches/`
+ * `mkdir -p dist/release/datasketches/`
+* Checkout both "dev" and "release" directories:
+ * Open a terminal in the dist/dev/datasketches directory and do a checkout:
+ * `svn co https://dist.apache.org/repos/dist/dev/datasketches/ .` #Note the DOT
+ * `svn status` # make sure it is clean
+ * Open a terminal in the dist/release/datasketches directory and do a checkout:
+ * `svn co https://dist.apache.org/repos/dist/release/datasketches/ .` #Note the DOT
+ * `svn status` # make sure it is clean
+
+## Create the candidate Apache release distribution on *dist/dev*
+
+### Create primary zip files & signatures
+
+* You will need the following arguments:
+ * Absolute path of target project.basedir on your system
+ * Artifact name: datasketches-rust
+ * GitHub Tag: A.B.X-rc.1 (or rc.N)
+
+* Start a new terminal in the *dist/dev/datasketches/scripts* directory on your system:
+ * To confirm *gpg-agent* is running type:
+ * `ps -axww | grep gpg` # you should see something like:
+ * *64438 ?? 0:30.33 gpg-agent --homedir /Users/\<name\>/.gnupg --use-standard-socket --daemon*
+ * To start GPG if GPG Agent is not running:
+ * `eval $(gpg-agent --daemon)`
+ * Run the deployment script:
+ * `./bashDeployToDist.sh /Users/\<name\>/dev/git/Apache/datasketches-rust datasketches-rust A.B.X-rc.1`
+ * Follow the instructions
+ * NOTE: if you get the error "gpg: signing failed: No pinentry":
+ * open .gnupg/gpg-agent.conf
+ * change to: pinentry-program /usr/local/bin/pinentry-tty
+ * reload the gpg agent in the terminal: `gpg-connect-agent reloadagent /bye`
+ * restart the ./bashDeployToDist script
+ * Close the terminal
+
+* Check and grab the web URL: *https://dist.apache.org/repos/dist/dev/datasketches/rust/A.B.X-rc.1/*
+ * There should be 3 files: \*-src.zip, \*-src.zip.asc, \*-src.zip.sha512
+ * Verify signatures:
+ * `gpg --verify datasketches-rust-A.B.X-rc.1-src.zip.asc datasketches-rust-A.B.X-rc.1-src.zip`
+ * `sha512sum -c datasketches-rust-A.B.X-rc.1-src.zip.sha512`
+
+## Prepare & Send [VOTE] Letter to dev@
+
+* See VoteTemplates directory for a recent example
Review Comment:
Not sure where `VoteTemplates` is but it is mentioned on both Java and CPP. cc @leerho
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] docs: document release process (datasketches-rust)
Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho merged PR #61:
URL: https://github.com/apache/datasketches-rust/pull/61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] docs: document release process (datasketches-rust)
Posted by "notfilippo (via GitHub)" <gi...@apache.org>.
notfilippo commented on PR #61:
URL: https://github.com/apache/datasketches-rust/pull/61#issuecomment-3705235895
> I'm feeling this is too complicated to follow. Although it covers many details, may we start with an easier version?
I thought this was standardized across projects. I would gladly simplify this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] docs: document release process (datasketches-rust)
Posted by "notfilippo (via GitHub)" <gi...@apache.org>.
notfilippo commented on code in PR #61:
URL: https://github.com/apache/datasketches-rust/pull/61#discussion_r2657751228
##########
RELEASE.md:
##########
@@ -0,0 +1,301 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# Release process for Rust components
+
+**NOTES:**
+
+* This process covers major and minor releases only. Bug-fix releases, which increment the third digit, are performed on
+ an A.B.X branch and not on main, but otherwise follow a similar process.
+* Some of these operations can be performed either on the Command-Line or in your IDE, whatever you prefer.
+
+## Preparation
+
+### Verify project health
+
+* Confirm correctness for:
+ * LICENSE
+ * NOTICE -- check for copyright dates
+ * README.md
+ * .asf.yaml
+ * .gitignore
+ * Cargo.toml -- ensure workspace metadata is correct
+
+* From Command Line or IDE:
+ * Run all checks: `cargo x lint`
+ * Run unit tests: `cargo x test`
+ * Run `cargo update` to ensure Cargo.lock is updated
+ <!-- TODO: * Run code coverage: `cargo llvm-cov --workspace` (target > 90%). -->
+ * Run tests on all platforms (see CI workflow)
+ * Confirm that documentation builds: `cargo doc --open`
+ * Confirm that all **temporary** branches are checked into main and/or deleted, both local and remote
+ * Confirm any new bug fixes have corresponding tests
+ * Check that all dependencies are at stable versions (no pre-release dependencies in Cargo.toml)
+
+### Verify release tooling
+
+* From Command Line at project root:
+ * Confirm GitHub repository is current and git status is clean
+ * Ensure you have publishing credentials configured:
+ * If not set: `cargo login` and enter your crates.io API token
+ * At major version releases, search for deprecated code and remove at **Major Versions** only:
+ * `grep -r "deprecated" --include="*.rs" src/`
+
+## Create permanent release branch & release candidate version preparation
+
+* From IDE or Command Line:
+ * Create new **Permanent Branch**: "A.B.X"
+ * Modify `datasketches/Cargo.toml` version:
+ * Change version to `version = "A.B.X"`
+ * Commit the changes with message: "chore: prepare A.B.X release"
+ * Write down the Git hash: example: 40c6f4f
+ * Push Branch "A.B.X" to origin:
+ * `git push -u origin A.B.X`
+ * Do explicit push of tags on branch "A.B.X" to origin:
+ * `git push origin --tags`
+ * **DO NOT MERGE THIS PERMANENT BRANCH INTO THE DEFAULT BRANCH**
+
+* From a web browser at origin website: github.com/apache/datasketches-rust
+ * Select the A.B.X branch
+ * Confirm that the tag: A.B.X-rc.1 exists and that the tag is on the latest commit with the correct Git hash
+ * **DO NOT CREATE PR OR MERGE THIS PERMANENT BRANCH INTO THE DEFAULT BRANCH**
+
+## Publish release candidate to crates.io
+
+**IMPORTANT:** This step publishes a pre-release version to crates.io for community testing. The `-rc.N` suffix
+indicates this is not a final release.
+
+* Return to release branch A.B.X:
+ * `git checkout A.B.X`
+* Create Annotated TAG: A.B.X-rc.1
+ * `git tag -a A.B.X-rc.1 -m "release candidate 1 for version A.B.X"`
+* Modify `datasketches/Cargo.toml` version **temporarily**:
+ * Change version to `version = "A.B.X-rc.1"`
+* Review the package contents:
+ * `cargo package --list -p datasketches`
+ * Ensure no unwanted files are included
+ * Verify LICENSE, NOTICE, README.md are included
+* Run publish in dry-run and verify output:
+ * `cargo publish --dry-run -p datasketches`
+* Publish to crates.io:
+ * `cargo publish -p datasketches`
+* Verify the published crate:
+ * Visit https://crates.io/crates/datasketches
+ * Confirm A.B.X-rc.1 is visible
+ * Test installation: `cargo add datasketches@A.B.X-rc.1` in a test project
+* Reset all temporary changes with `git checkout -f A.B.X`:
+ * `cat datasketches/Cargo.toml | grep version` # should show A.B.X
+
+## Create and/or checkout local *dist/dev* directories on your system
+
+* If you have not already, on your system create the two directory structures that mirror the dist.apache.org/repos/
+ directories:
+ * `mkdir -p dist/dev/datasketches/`
+ * `mkdir -p dist/release/datasketches/`
+* Checkout both "dev" and "release" directories:
+ * Open a terminal in the dist/dev/datasketches directory and do a checkout:
+ * `svn co https://dist.apache.org/repos/dist/dev/datasketches/ .` #Note the DOT
+ * `svn status` # make sure it is clean
+ * Open a terminal in the dist/release/datasketches directory and do a checkout:
+ * `svn co https://dist.apache.org/repos/dist/release/datasketches/ .` #Note the DOT
+ * `svn status` # make sure it is clean
+
+## Create the candidate Apache release distribution on *dist/dev*
+
+### Create primary zip files & signatures
+
+* You will need the following arguments:
+ * Absolute path of target project.basedir on your system
+ * Artifact name: datasketches-rust
+ * GitHub Tag: A.B.X-rc.1 (or rc.N)
+
+* Start a new terminal in the *dist/dev/datasketches/scripts* directory on your system:
+ * To confirm *gpg-agent* is running type:
+ * `ps -axww | grep gpg` # you should see something like:
+ * *64438 ?? 0:30.33 gpg-agent --homedir /Users/\<name\>/.gnupg --use-standard-socket --daemon*
+ * To start GPG if GPG Agent is not running:
+ * `eval $(gpg-agent --daemon)`
+ * Run the deployment script:
+ * `./bashDeployToDist.sh /Users/\<name\>/dev/git/Apache/datasketches-rust datasketches-rust A.B.X-rc.1`
+ * Follow the instructions
+ * NOTE: if you get the error "gpg: signing failed: No pinentry":
+ * open .gnupg/gpg-agent.conf
+ * change to: pinentry-program /usr/local/bin/pinentry-tty
+ * reload the gpg agent in the terminal: `gpg-connect-agent reloadagent /bye`
+ * restart the ./bashDeployToDist script
+ * Close the terminal
+
+* Check and grab the web URL: *https://dist.apache.org/repos/dist/dev/datasketches/rust/A.B.X-rc.1/*
+ * There should be 3 files: \*-src.zip, \*-src.zip.asc, \*-src.zip.sha512
+ * Verify signatures:
+ * `gpg --verify datasketches-rust-A.B.X-rc.1-src.zip.asc datasketches-rust-A.B.X-rc.1-src.zip`
+ * `sha512sum -c datasketches-rust-A.B.X-rc.1-src.zip.sha512`
+
+## Prepare & Send [VOTE] Letter to dev@
+
+* See VoteTemplates directory for a recent example
Review Comment:
That's interesting. I'm in favour of this but I'm new to the ASF way of doing things so maybe @leerho can have a more informed opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] docs: document release process (datasketches-rust)
Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho commented on code in PR #61:
URL: https://github.com/apache/datasketches-rust/pull/61#discussion_r2659280750
##########
RELEASE.md:
##########
@@ -0,0 +1,301 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# Release process for Rust components
+
+**NOTES:**
+
+* This process covers major and minor releases only. Bug-fix releases, which increment the third digit, are performed on
+ an A.B.X branch and not on main, but otherwise follow a similar process.
+* Some of these operations can be performed either on the Command-Line or in your IDE, whatever you prefer.
+
+## Preparation
+
+### Verify project health
+
+* Confirm correctness for:
+ * LICENSE
+ * NOTICE -- check for copyright dates
+ * README.md
+ * .asf.yaml
+ * .gitignore
+ * Cargo.toml -- ensure workspace metadata is correct
+
+* From Command Line or IDE:
+ * Run all checks: `cargo x lint`
+ * Run unit tests: `cargo x test`
+ * Run `cargo update` to ensure Cargo.lock is updated
+ <!-- TODO: * Run code coverage: `cargo llvm-cov --workspace` (target > 90%). -->
+ * Run tests on all platforms (see CI workflow)
+ * Confirm that documentation builds: `cargo doc --open`
+ * Confirm that all **temporary** branches are checked into main and/or deleted, both local and remote
+ * Confirm any new bug fixes have corresponding tests
+ * Check that all dependencies are at stable versions (no pre-release dependencies in Cargo.toml)
+
+### Verify release tooling
+
+* From Command Line at project root:
+ * Confirm GitHub repository is current and git status is clean
+ * Ensure you have publishing credentials configured:
+ * If not set: `cargo login` and enter your crates.io API token
+ * At major version releases, search for deprecated code and remove at **Major Versions** only:
+ * `grep -r "deprecated" --include="*.rs" src/`
+
+## Create permanent release branch & release candidate version preparation
+
+* From IDE or Command Line:
+ * Create new **Permanent Branch**: "A.B.X"
+ * Modify `datasketches/Cargo.toml` version:
+ * Change version to `version = "A.B.X"`
+ * Commit the changes with message: "chore: prepare A.B.X release"
+ * Write down the Git hash: example: 40c6f4f
+ * Push Branch "A.B.X" to origin:
+ * `git push -u origin A.B.X`
+ * Do explicit push of tags on branch "A.B.X" to origin:
+ * `git push origin --tags`
+ * **DO NOT MERGE THIS PERMANENT BRANCH INTO THE DEFAULT BRANCH**
+
+* From a web browser at origin website: github.com/apache/datasketches-rust
+ * Select the A.B.X branch
+ * Confirm that the tag: A.B.X-rc.1 exists and that the tag is on the latest commit with the correct Git hash
+ * **DO NOT CREATE PR OR MERGE THIS PERMANENT BRANCH INTO THE DEFAULT BRANCH**
+
+## Publish release candidate to crates.io
+
+**IMPORTANT:** This step publishes a pre-release version to crates.io for community testing. The `-rc.N` suffix
+indicates this is not a final release.
+
+* Return to release branch A.B.X:
+ * `git checkout A.B.X`
+* Create Annotated TAG: A.B.X-rc.1
+ * `git tag -a A.B.X-rc.1 -m "release candidate 1 for version A.B.X"`
+* Modify `datasketches/Cargo.toml` version **temporarily**:
+ * Change version to `version = "A.B.X-rc.1"`
+* Review the package contents:
+ * `cargo package --list -p datasketches`
+ * Ensure no unwanted files are included
+ * Verify LICENSE, NOTICE, README.md are included
+* Run publish in dry-run and verify output:
+ * `cargo publish --dry-run -p datasketches`
+* Publish to crates.io:
+ * `cargo publish -p datasketches`
+* Verify the published crate:
+ * Visit https://crates.io/crates/datasketches
+ * Confirm A.B.X-rc.1 is visible
+ * Test installation: `cargo add datasketches@A.B.X-rc.1` in a test project
+* Reset all temporary changes with `git checkout -f A.B.X`:
+ * `cat datasketches/Cargo.toml | grep version` # should show A.B.X
+
+## Create and/or checkout local *dist/dev* directories on your system
+
+* If you have not already, on your system create the two directory structures that mirror the dist.apache.org/repos/
+ directories:
+ * `mkdir -p dist/dev/datasketches/`
+ * `mkdir -p dist/release/datasketches/`
+* Checkout both "dev" and "release" directories:
+ * Open a terminal in the dist/dev/datasketches directory and do a checkout:
+ * `svn co https://dist.apache.org/repos/dist/dev/datasketches/ .` #Note the DOT
Review Comment:
@tisonkun,
You will also need a /rust/ subdirectory for the actual release, a. la: https://dist.apache.org/repos/dist/release/datasketches/rust
Apache picks this up and copies it to its release archive. In this directory, please only keep the latest release.
You will notice that we have multiple java version directories because there are still many major platforms that require earlier Java versions. How this works for various Rust versions I don't know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] docs: document release process (datasketches-rust)
Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho commented on code in PR #61:
URL: https://github.com/apache/datasketches-rust/pull/61#discussion_r2659277752
##########
RELEASE.md:
##########
@@ -0,0 +1,301 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# Release process for Rust components
+
+**NOTES:**
+
+* This process covers major and minor releases only. Bug-fix releases, which increment the third digit, are performed on
+ an A.B.X branch and not on main, but otherwise follow a similar process.
+* Some of these operations can be performed either on the Command-Line or in your IDE, whatever you prefer.
+
+## Preparation
+
+### Verify project health
+
+* Confirm correctness for:
+ * LICENSE
+ * NOTICE -- check for copyright dates
+ * README.md
+ * .asf.yaml
+ * .gitignore
+ * Cargo.toml -- ensure workspace metadata is correct
+
+* From Command Line or IDE:
+ * Run all checks: `cargo x lint`
+ * Run unit tests: `cargo x test`
+ * Run `cargo update` to ensure Cargo.lock is updated
+ <!-- TODO: * Run code coverage: `cargo llvm-cov --workspace` (target > 90%). -->
+ * Run tests on all platforms (see CI workflow)
+ * Confirm that documentation builds: `cargo doc --open`
+ * Confirm that all **temporary** branches are checked into main and/or deleted, both local and remote
+ * Confirm any new bug fixes have corresponding tests
+ * Check that all dependencies are at stable versions (no pre-release dependencies in Cargo.toml)
+
+### Verify release tooling
+
+* From Command Line at project root:
+ * Confirm GitHub repository is current and git status is clean
+ * Ensure you have publishing credentials configured:
+ * If not set: `cargo login` and enter your crates.io API token
+ * At major version releases, search for deprecated code and remove at **Major Versions** only:
+ * `grep -r "deprecated" --include="*.rs" src/`
+
+## Create permanent release branch & release candidate version preparation
+
+* From IDE or Command Line:
+ * Create new **Permanent Branch**: "A.B.X"
+ * Modify `datasketches/Cargo.toml` version:
+ * Change version to `version = "A.B.X"`
+ * Commit the changes with message: "chore: prepare A.B.X release"
+ * Write down the Git hash: example: 40c6f4f
+ * Push Branch "A.B.X" to origin:
+ * `git push -u origin A.B.X`
+ * Do explicit push of tags on branch "A.B.X" to origin:
+ * `git push origin --tags`
+ * **DO NOT MERGE THIS PERMANENT BRANCH INTO THE DEFAULT BRANCH**
+
+* From a web browser at origin website: github.com/apache/datasketches-rust
+ * Select the A.B.X branch
+ * Confirm that the tag: A.B.X-rc.1 exists and that the tag is on the latest commit with the correct Git hash
+ * **DO NOT CREATE PR OR MERGE THIS PERMANENT BRANCH INTO THE DEFAULT BRANCH**
+
+## Publish release candidate to crates.io
+
+**IMPORTANT:** This step publishes a pre-release version to crates.io for community testing. The `-rc.N` suffix
+indicates this is not a final release.
+
+* Return to release branch A.B.X:
+ * `git checkout A.B.X`
+* Create Annotated TAG: A.B.X-rc.1
+ * `git tag -a A.B.X-rc.1 -m "release candidate 1 for version A.B.X"`
+* Modify `datasketches/Cargo.toml` version **temporarily**:
+ * Change version to `version = "A.B.X-rc.1"`
+* Review the package contents:
+ * `cargo package --list -p datasketches`
+ * Ensure no unwanted files are included
+ * Verify LICENSE, NOTICE, README.md are included
+* Run publish in dry-run and verify output:
+ * `cargo publish --dry-run -p datasketches`
+* Publish to crates.io:
+ * `cargo publish -p datasketches`
+* Verify the published crate:
+ * Visit https://crates.io/crates/datasketches
+ * Confirm A.B.X-rc.1 is visible
+ * Test installation: `cargo add datasketches@A.B.X-rc.1` in a test project
+* Reset all temporary changes with `git checkout -f A.B.X`:
+ * `cat datasketches/Cargo.toml | grep version` # should show A.B.X
+
+## Create and/or checkout local *dist/dev* directories on your system
+
+* If you have not already, on your system create the two directory structures that mirror the dist.apache.org/repos/
+ directories:
+ * `mkdir -p dist/dev/datasketches/`
+ * `mkdir -p dist/release/datasketches/`
+* Checkout both "dev" and "release" directories:
+ * Open a terminal in the dist/dev/datasketches directory and do a checkout:
+ * `svn co https://dist.apache.org/repos/dist/dev/datasketches/ .` #Note the DOT
+ * `svn status` # make sure it is clean
+ * Open a terminal in the dist/release/datasketches directory and do a checkout:
+ * `svn co https://dist.apache.org/repos/dist/release/datasketches/ .` #Note the DOT
+ * `svn status` # make sure it is clean
+
+## Create the candidate Apache release distribution on *dist/dev*
+
+### Create primary zip files & signatures
+
+* You will need the following arguments:
+ * Absolute path of target project.basedir on your system
+ * Artifact name: datasketches-rust
+ * GitHub Tag: A.B.X-rc.1 (or rc.N)
+
+* Start a new terminal in the *dist/dev/datasketches/scripts* directory on your system:
+ * To confirm *gpg-agent* is running type:
+ * `ps -axww | grep gpg` # you should see something like:
+ * *64438 ?? 0:30.33 gpg-agent --homedir /Users/\<name\>/.gnupg --use-standard-socket --daemon*
+ * To start GPG if GPG Agent is not running:
+ * `eval $(gpg-agent --daemon)`
+ * Run the deployment script:
+ * `./bashDeployToDist.sh /Users/\<name\>/dev/git/Apache/datasketches-rust datasketches-rust A.B.X-rc.1`
+ * Follow the instructions
+ * NOTE: if you get the error "gpg: signing failed: No pinentry":
+ * open .gnupg/gpg-agent.conf
+ * change to: pinentry-program /usr/local/bin/pinentry-tty
+ * reload the gpg agent in the terminal: `gpg-connect-agent reloadagent /bye`
+ * restart the ./bashDeployToDist script
+ * Close the terminal
+
+* Check and grab the web URL: *https://dist.apache.org/repos/dist/dev/datasketches/rust/A.B.X-rc.1/*
+ * There should be 3 files: \*-src.zip, \*-src.zip.asc, \*-src.zip.sha512
+ * Verify signatures:
+ * `gpg --verify datasketches-rust-A.B.X-rc.1-src.zip.asc datasketches-rust-A.B.X-rc.1-src.zip`
+ * `sha512sum -c datasketches-rust-A.B.X-rc.1-src.zip.sha512`
+
+## Prepare & Send [VOTE] Letter to dev@
+
+* See VoteTemplates directory for a recent example
Review Comment:
@PsiACE,
My understanding is that Apache requires that messages for key events (like votes on releases, etc ) be documented / communicated on dev@. This is because the audience for these messages is the entire community of developers and users of a project. Also Apache keeps all these communications in its own archives for legal reasons. If these event messages were on different platforms, some users might not see the message and Apache would not have it in their archives.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] docs: document release process (datasketches-rust)
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #61:
URL: https://github.com/apache/datasketches-rust/pull/61#discussion_r2657569779
##########
RELEASE.md:
##########
@@ -0,0 +1,301 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# Release process for Rust components
+
+**NOTES:**
+
+* This process covers major and minor releases only. Bug-fix releases, which increment the third digit, are performed on
+ an A.B.X branch and not on main, but otherwise follow a similar process.
+* Some of these operations can be performed either on the Command-Line or in your IDE, whatever you prefer.
+
+## Preparation
+
+### Verify project health
+
+* Confirm correctness for:
+ * LICENSE
+ * NOTICE -- check for copyright dates
+ * README.md
+ * .asf.yaml
+ * .gitignore
+ * Cargo.toml -- ensure workspace metadata is correct
+
+* From Command Line or IDE:
+ * Run all checks: `cargo x lint`
+ * Run unit tests: `cargo x test`
+ * Run `cargo update` to ensure Cargo.lock is updated
+ <!-- TODO: * Run code coverage: `cargo llvm-cov --workspace` (target > 90%). -->
+ * Run tests on all platforms (see CI workflow)
+ * Confirm that documentation builds: `cargo doc --open`
+ * Confirm that all **temporary** branches are checked into main and/or deleted, both local and remote
+ * Confirm any new bug fixes have corresponding tests
+ * Check that all dependencies are at stable versions (no pre-release dependencies in Cargo.toml)
+
+### Verify release tooling
+
+* From Command Line at project root:
+ * Confirm GitHub repository is current and git status is clean
+ * Ensure you have publishing credentials configured:
+ * If not set: `cargo login` and enter your crates.io API token
+ * At major version releases, search for deprecated code and remove at **Major Versions** only:
+ * `grep -r "deprecated" --include="*.rs" src/`
+
+## Create permanent release branch & release candidate version preparation
+
+* From IDE or Command Line:
+ * Create new **Permanent Branch**: "A.B.X"
+ * Modify `datasketches/Cargo.toml` version:
+ * Change version to `version = "A.B.X"`
+ * Commit the changes with message: "chore: prepare A.B.X release"
+ * Write down the Git hash: example: 40c6f4f
+ * Push Branch "A.B.X" to origin:
+ * `git push -u origin A.B.X`
+ * Do explicit push of tags on branch "A.B.X" to origin:
+ * `git push origin --tags`
+ * **DO NOT MERGE THIS PERMANENT BRANCH INTO THE DEFAULT BRANCH**
+
+* From a web browser at origin website: github.com/apache/datasketches-rust
+ * Select the A.B.X branch
+ * Confirm that the tag: A.B.X-rc.1 exists and that the tag is on the latest commit with the correct Git hash
+ * **DO NOT CREATE PR OR MERGE THIS PERMANENT BRANCH INTO THE DEFAULT BRANCH**
+
+## Publish release candidate to crates.io
+
+**IMPORTANT:** This step publishes a pre-release version to crates.io for community testing. The `-rc.N` suffix
+indicates this is not a final release.
+
+* Return to release branch A.B.X:
+ * `git checkout A.B.X`
+* Create Annotated TAG: A.B.X-rc.1
+ * `git tag -a A.B.X-rc.1 -m "release candidate 1 for version A.B.X"`
+* Modify `datasketches/Cargo.toml` version **temporarily**:
+ * Change version to `version = "A.B.X-rc.1"`
+* Review the package contents:
+ * `cargo package --list -p datasketches`
+ * Ensure no unwanted files are included
+ * Verify LICENSE, NOTICE, README.md are included
+* Run publish in dry-run and verify output:
+ * `cargo publish --dry-run -p datasketches`
+* Publish to crates.io:
+ * `cargo publish -p datasketches`
+* Verify the published crate:
+ * Visit https://crates.io/crates/datasketches
+ * Confirm A.B.X-rc.1 is visible
+ * Test installation: `cargo add datasketches@A.B.X-rc.1` in a test project
+* Reset all temporary changes with `git checkout -f A.B.X`:
+ * `cat datasketches/Cargo.toml | grep version` # should show A.B.X
+
+## Create and/or checkout local *dist/dev* directories on your system
+
+* If you have not already, on your system create the two directory structures that mirror the dist.apache.org/repos/
+ directories:
+ * `mkdir -p dist/dev/datasketches/`
+ * `mkdir -p dist/release/datasketches/`
+* Checkout both "dev" and "release" directories:
+ * Open a terminal in the dist/dev/datasketches directory and do a checkout:
+ * `svn co https://dist.apache.org/repos/dist/dev/datasketches/ .` #Note the DOT
Review Comment:
I suppose we need only the rust subdirectory:
```
svn co https://dist.apache.org/repos/dist/dev/datasketches/rust
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] docs: document release process (datasketches-rust)
Posted by "notfilippo (via GitHub)" <gi...@apache.org>.
notfilippo commented on code in PR #61:
URL: https://github.com/apache/datasketches-rust/pull/61#discussion_r2657749521
##########
RELEASE.md:
##########
@@ -0,0 +1,301 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# Release process for Rust components
+
+**NOTES:**
+
+* This process covers major and minor releases only. Bug-fix releases, which increment the third digit, are performed on
+ an A.B.X branch and not on main, but otherwise follow a similar process.
+* Some of these operations can be performed either on the Command-Line or in your IDE, whatever you prefer.
+
+## Preparation
+
+### Verify project health
+
+* Confirm correctness for:
+ * LICENSE
+ * NOTICE -- check for copyright dates
+ * README.md
+ * .asf.yaml
+ * .gitignore
+ * Cargo.toml -- ensure workspace metadata is correct
+
+* From Command Line or IDE:
+ * Run all checks: `cargo x lint`
+ * Run unit tests: `cargo x test`
+ * Run `cargo update` to ensure Cargo.lock is updated
+ <!-- TODO: * Run code coverage: `cargo llvm-cov --workspace` (target > 90%). -->
+ * Run tests on all platforms (see CI workflow)
+ * Confirm that documentation builds: `cargo doc --open`
+ * Confirm that all **temporary** branches are checked into main and/or deleted, both local and remote
+ * Confirm any new bug fixes have corresponding tests
+ * Check that all dependencies are at stable versions (no pre-release dependencies in Cargo.toml)
+
+### Verify release tooling
+
+* From Command Line at project root:
+ * Confirm GitHub repository is current and git status is clean
+ * Ensure you have publishing credentials configured:
+ * If not set: `cargo login` and enter your crates.io API token
+ * At major version releases, search for deprecated code and remove at **Major Versions** only:
+ * `grep -r "deprecated" --include="*.rs" src/`
+
+## Create permanent release branch & release candidate version preparation
+
+* From IDE or Command Line:
+ * Create new **Permanent Branch**: "A.B.X"
+ * Modify `datasketches/Cargo.toml` version:
+ * Change version to `version = "A.B.X"`
+ * Commit the changes with message: "chore: prepare A.B.X release"
+ * Write down the Git hash: example: 40c6f4f
+ * Push Branch "A.B.X" to origin:
+ * `git push -u origin A.B.X`
+ * Do explicit push of tags on branch "A.B.X" to origin:
+ * `git push origin --tags`
+ * **DO NOT MERGE THIS PERMANENT BRANCH INTO THE DEFAULT BRANCH**
+
+* From a web browser at origin website: github.com/apache/datasketches-rust
+ * Select the A.B.X branch
+ * Confirm that the tag: A.B.X-rc.1 exists and that the tag is on the latest commit with the correct Git hash
+ * **DO NOT CREATE PR OR MERGE THIS PERMANENT BRANCH INTO THE DEFAULT BRANCH**
+
+## Publish release candidate to crates.io
+
+**IMPORTANT:** This step publishes a pre-release version to crates.io for community testing. The `-rc.N` suffix
+indicates this is not a final release.
+
+* Return to release branch A.B.X:
+ * `git checkout A.B.X`
+* Create Annotated TAG: A.B.X-rc.1
+ * `git tag -a A.B.X-rc.1 -m "release candidate 1 for version A.B.X"`
+* Modify `datasketches/Cargo.toml` version **temporarily**:
+ * Change version to `version = "A.B.X-rc.1"`
+* Review the package contents:
+ * `cargo package --list -p datasketches`
+ * Ensure no unwanted files are included
+ * Verify LICENSE, NOTICE, README.md are included
+* Run publish in dry-run and verify output:
+ * `cargo publish --dry-run -p datasketches`
+* Publish to crates.io:
+ * `cargo publish -p datasketches`
+* Verify the published crate:
+ * Visit https://crates.io/crates/datasketches
+ * Confirm A.B.X-rc.1 is visible
+ * Test installation: `cargo add datasketches@A.B.X-rc.1` in a test project
+* Reset all temporary changes with `git checkout -f A.B.X`:
+ * `cat datasketches/Cargo.toml | grep version` # should show A.B.X
+
+## Create and/or checkout local *dist/dev* directories on your system
+
+* If you have not already, on your system create the two directory structures that mirror the dist.apache.org/repos/
+ directories:
+ * `mkdir -p dist/dev/datasketches/`
+ * `mkdir -p dist/release/datasketches/`
+* Checkout both "dev" and "release" directories:
+ * Open a terminal in the dist/dev/datasketches directory and do a checkout:
+ * `svn co https://dist.apache.org/repos/dist/dev/datasketches/ .` #Note the DOT
Review Comment:
We might need the scripts from `datasketches/scripts`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] docs: document release process (datasketches-rust)
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #61:
URL: https://github.com/apache/datasketches-rust/pull/61#discussion_r2657577081
##########
RELEASE.md:
##########
@@ -0,0 +1,301 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# Release process for Rust components
+
+**NOTES:**
+
+* This process covers major and minor releases only. Bug-fix releases, which increment the third digit, are performed on
+ an A.B.X branch and not on main, but otherwise follow a similar process.
+* Some of these operations can be performed either on the Command-Line or in your IDE, whatever you prefer.
+
+## Preparation
+
+### Verify project health
+
+* Confirm correctness for:
+ * LICENSE
+ * NOTICE -- check for copyright dates
+ * README.md
+ * .asf.yaml
+ * .gitignore
+ * Cargo.toml -- ensure workspace metadata is correct
+
+* From Command Line or IDE:
+ * Run all checks: `cargo x lint`
+ * Run unit tests: `cargo x test`
+ * Run `cargo update` to ensure Cargo.lock is updated
+ <!-- TODO: * Run code coverage: `cargo llvm-cov --workspace` (target > 90%). -->
+ * Run tests on all platforms (see CI workflow)
+ * Confirm that documentation builds: `cargo doc --open`
+ * Confirm that all **temporary** branches are checked into main and/or deleted, both local and remote
+ * Confirm any new bug fixes have corresponding tests
+ * Check that all dependencies are at stable versions (no pre-release dependencies in Cargo.toml)
+
+### Verify release tooling
+
+* From Command Line at project root:
+ * Confirm GitHub repository is current and git status is clean
+ * Ensure you have publishing credentials configured:
+ * If not set: `cargo login` and enter your crates.io API token
+ * At major version releases, search for deprecated code and remove at **Major Versions** only:
+ * `grep -r "deprecated" --include="*.rs" src/`
+
+## Create permanent release branch & release candidate version preparation
+
+* From IDE or Command Line:
+ * Create new **Permanent Branch**: "A.B.X"
+ * Modify `datasketches/Cargo.toml` version:
+ * Change version to `version = "A.B.X"`
+ * Commit the changes with message: "chore: prepare A.B.X release"
+ * Write down the Git hash: example: 40c6f4f
+ * Push Branch "A.B.X" to origin:
Review Comment:
I don't think we will cut a new branch for each release now. But simply has tags and a linear history on the main branch.
We should use `A.B.X-rc.N` during release candidates; here it writes "A.B.X" without the rc suffix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] docs: document release process (datasketches-rust)
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #61:
URL: https://github.com/apache/datasketches-rust/pull/61#discussion_r2657568303
##########
RELEASE.md:
##########
@@ -0,0 +1,301 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# Release process for Rust components
+
+**NOTES:**
+
+* This process covers major and minor releases only. Bug-fix releases, which increment the third digit, are performed on
+ an A.B.X branch and not on main, but otherwise follow a similar process.
+* Some of these operations can be performed either on the Command-Line or in your IDE, whatever you prefer.
+
+## Preparation
+
+### Verify project health
+
+* Confirm correctness for:
+ * LICENSE
+ * NOTICE -- check for copyright dates
+ * README.md
+ * .asf.yaml
+ * .gitignore
+ * Cargo.toml -- ensure workspace metadata is correct
+
+* From Command Line or IDE:
+ * Run all checks: `cargo x lint`
+ * Run unit tests: `cargo x test`
+ * Run `cargo update` to ensure Cargo.lock is updated
+ <!-- TODO: * Run code coverage: `cargo llvm-cov --workspace` (target > 90%). -->
+ * Run tests on all platforms (see CI workflow)
+ * Confirm that documentation builds: `cargo doc --open`
Review Comment:
```suggestion
* Confirm that documentation builds: `RUSTDOCFLAGS="--cfg docsrs" cargo +nightly doc --all-features --no-deps --open`
```
This is what docs.rs does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] docs: document release process (datasketches-rust)
Posted by "notfilippo (via GitHub)" <gi...@apache.org>.
notfilippo commented on code in PR #61:
URL: https://github.com/apache/datasketches-rust/pull/61#discussion_r2657516315
##########
Cargo.lock:
##########
Review Comment:
This is due to me following the release process commands to double check the functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] docs: document release process (datasketches-rust)
Posted by "notfilippo (via GitHub)" <gi...@apache.org>.
notfilippo commented on code in PR #61:
URL: https://github.com/apache/datasketches-rust/pull/61#discussion_r2657639345
##########
RELEASE.md:
##########
@@ -0,0 +1,301 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# Release process for Rust components
+
+**NOTES:**
+
+* This process covers major and minor releases only. Bug-fix releases, which increment the third digit, are performed on
+ an A.B.X branch and not on main, but otherwise follow a similar process.
+* Some of these operations can be performed either on the Command-Line or in your IDE, whatever you prefer.
+
+## Preparation
+
+### Verify project health
+
+* Confirm correctness for:
+ * LICENSE
+ * NOTICE -- check for copyright dates
+ * README.md
+ * .asf.yaml
+ * .gitignore
+ * Cargo.toml -- ensure workspace metadata is correct
+
+* From Command Line or IDE:
+ * Run all checks: `cargo x lint`
+ * Run unit tests: `cargo x test`
+ * Run `cargo update` to ensure Cargo.lock is updated
+ <!-- TODO: * Run code coverage: `cargo llvm-cov --workspace` (target > 90%). -->
+ * Run tests on all platforms (see CI workflow)
+ * Confirm that documentation builds: `cargo doc --open`
Review Comment:
Can we have an X script for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] docs: document release process (datasketches-rust)
Posted by "notfilippo (via GitHub)" <gi...@apache.org>.
notfilippo commented on PR #61:
URL: https://github.com/apache/datasketches-rust/pull/61#issuecomment-3705445586
I think you can give it another pass @tisonkun . I've tried to include the scripts since it's nice to share the same expectations as the other datasketches implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] docs: document release process (datasketches-rust)
Posted by "PsiACE (via GitHub)" <gi...@apache.org>.
PsiACE commented on code in PR #61:
URL: https://github.com/apache/datasketches-rust/pull/61#discussion_r2657720112
##########
RELEASE.md:
##########
@@ -0,0 +1,301 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# Release process for Rust components
+
+**NOTES:**
+
+* This process covers major and minor releases only. Bug-fix releases, which increment the third digit, are performed on
+ an A.B.X branch and not on main, but otherwise follow a similar process.
+* Some of these operations can be performed either on the Command-Line or in your IDE, whatever you prefer.
+
+## Preparation
+
+### Verify project health
+
+* Confirm correctness for:
+ * LICENSE
+ * NOTICE -- check for copyright dates
+ * README.md
+ * .asf.yaml
+ * .gitignore
+ * Cargo.toml -- ensure workspace metadata is correct
+
+* From Command Line or IDE:
+ * Run all checks: `cargo x lint`
+ * Run unit tests: `cargo x test`
+ * Run `cargo update` to ensure Cargo.lock is updated
+ <!-- TODO: * Run code coverage: `cargo llvm-cov --workspace` (target > 90%). -->
+ * Run tests on all platforms (see CI workflow)
+ * Confirm that documentation builds: `cargo doc --open`
+ * Confirm that all **temporary** branches are checked into main and/or deleted, both local and remote
+ * Confirm any new bug fixes have corresponding tests
+ * Check that all dependencies are at stable versions (no pre-release dependencies in Cargo.toml)
+
+### Verify release tooling
+
+* From Command Line at project root:
+ * Confirm GitHub repository is current and git status is clean
+ * Ensure you have publishing credentials configured:
+ * If not set: `cargo login` and enter your crates.io API token
+ * At major version releases, search for deprecated code and remove at **Major Versions** only:
+ * `grep -r "deprecated" --include="*.rs" src/`
+
+## Create permanent release branch & release candidate version preparation
+
+* From IDE or Command Line:
+ * Create new **Permanent Branch**: "A.B.X"
+ * Modify `datasketches/Cargo.toml` version:
+ * Change version to `version = "A.B.X"`
+ * Commit the changes with message: "chore: prepare A.B.X release"
+ * Write down the Git hash: example: 40c6f4f
+ * Push Branch "A.B.X" to origin:
+ * `git push -u origin A.B.X`
+ * Do explicit push of tags on branch "A.B.X" to origin:
+ * `git push origin --tags`
+ * **DO NOT MERGE THIS PERMANENT BRANCH INTO THE DEFAULT BRANCH**
+
+* From a web browser at origin website: github.com/apache/datasketches-rust
+ * Select the A.B.X branch
+ * Confirm that the tag: A.B.X-rc.1 exists and that the tag is on the latest commit with the correct Git hash
+ * **DO NOT CREATE PR OR MERGE THIS PERMANENT BRANCH INTO THE DEFAULT BRANCH**
+
+## Publish release candidate to crates.io
+
+**IMPORTANT:** This step publishes a pre-release version to crates.io for community testing. The `-rc.N` suffix
+indicates this is not a final release.
+
+* Return to release branch A.B.X:
+ * `git checkout A.B.X`
+* Create Annotated TAG: A.B.X-rc.1
+ * `git tag -a A.B.X-rc.1 -m "release candidate 1 for version A.B.X"`
+* Modify `datasketches/Cargo.toml` version **temporarily**:
+ * Change version to `version = "A.B.X-rc.1"`
+* Review the package contents:
+ * `cargo package --list -p datasketches`
+ * Ensure no unwanted files are included
+ * Verify LICENSE, NOTICE, README.md are included
+* Run publish in dry-run and verify output:
+ * `cargo publish --dry-run -p datasketches`
+* Publish to crates.io:
+ * `cargo publish -p datasketches`
+* Verify the published crate:
+ * Visit https://crates.io/crates/datasketches
+ * Confirm A.B.X-rc.1 is visible
+ * Test installation: `cargo add datasketches@A.B.X-rc.1` in a test project
+* Reset all temporary changes with `git checkout -f A.B.X`:
+ * `cat datasketches/Cargo.toml | grep version` # should show A.B.X
+
+## Create and/or checkout local *dist/dev* directories on your system
+
+* If you have not already, on your system create the two directory structures that mirror the dist.apache.org/repos/
+ directories:
+ * `mkdir -p dist/dev/datasketches/`
+ * `mkdir -p dist/release/datasketches/`
+* Checkout both "dev" and "release" directories:
+ * Open a terminal in the dist/dev/datasketches directory and do a checkout:
+ * `svn co https://dist.apache.org/repos/dist/dev/datasketches/ .` #Note the DOT
+ * `svn status` # make sure it is clean
+ * Open a terminal in the dist/release/datasketches directory and do a checkout:
+ * `svn co https://dist.apache.org/repos/dist/release/datasketches/ .` #Note the DOT
+ * `svn status` # make sure it is clean
+
+## Create the candidate Apache release distribution on *dist/dev*
+
+### Create primary zip files & signatures
+
+* You will need the following arguments:
+ * Absolute path of target project.basedir on your system
+ * Artifact name: datasketches-rust
+ * GitHub Tag: A.B.X-rc.1 (or rc.N)
+
+* Start a new terminal in the *dist/dev/datasketches/scripts* directory on your system:
+ * To confirm *gpg-agent* is running type:
+ * `ps -axww | grep gpg` # you should see something like:
+ * *64438 ?? 0:30.33 gpg-agent --homedir /Users/\<name\>/.gnupg --use-standard-socket --daemon*
+ * To start GPG if GPG Agent is not running:
+ * `eval $(gpg-agent --daemon)`
+ * Run the deployment script:
+ * `./bashDeployToDist.sh /Users/\<name\>/dev/git/Apache/datasketches-rust datasketches-rust A.B.X-rc.1`
+ * Follow the instructions
+ * NOTE: if you get the error "gpg: signing failed: No pinentry":
+ * open .gnupg/gpg-agent.conf
+ * change to: pinentry-program /usr/local/bin/pinentry-tty
+ * reload the gpg agent in the terminal: `gpg-connect-agent reloadagent /bye`
+ * restart the ./bashDeployToDist script
+ * Close the terminal
+
+* Check and grab the web URL: *https://dist.apache.org/repos/dist/dev/datasketches/rust/A.B.X-rc.1/*
+ * There should be 3 files: \*-src.zip, \*-src.zip.asc, \*-src.zip.sha512
+ * Verify signatures:
+ * `gpg --verify datasketches-rust-A.B.X-rc.1-src.zip.asc datasketches-rust-A.B.X-rc.1-src.zip`
+ * `sha512sum -c datasketches-rust-A.B.X-rc.1-src.zip.sha512`
+
+## Prepare & Send [VOTE] Letter to dev@
+
+* See VoteTemplates directory for a recent example
Review Comment:
At Opendal, we've switched some mailing list processes to GitHub Discussions as the primary channel and established a standardized format. Like this https://github.com/apache/opendal/discussions/6794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] docs: document release process (datasketches-rust)
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #61:
URL: https://github.com/apache/datasketches-rust/pull/61#discussion_r2657570376
##########
RELEASE.md:
##########
@@ -0,0 +1,301 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# Release process for Rust components
+
+**NOTES:**
+
+* This process covers major and minor releases only. Bug-fix releases, which increment the third digit, are performed on
+ an A.B.X branch and not on main, but otherwise follow a similar process.
+* Some of these operations can be performed either on the Command-Line or in your IDE, whatever you prefer.
+
+## Preparation
+
+### Verify project health
+
+* Confirm correctness for:
+ * LICENSE
+ * NOTICE -- check for copyright dates
+ * README.md
+ * .asf.yaml
+ * .gitignore
+ * Cargo.toml -- ensure workspace metadata is correct
+
+* From Command Line or IDE:
+ * Run all checks: `cargo x lint`
+ * Run unit tests: `cargo x test`
+ * Run `cargo update` to ensure Cargo.lock is updated
+ <!-- TODO: * Run code coverage: `cargo llvm-cov --workspace` (target > 90%). -->
+ * Run tests on all platforms (see CI workflow)
+ * Confirm that documentation builds: `cargo doc --open`
+ * Confirm that all **temporary** branches are checked into main and/or deleted, both local and remote
+ * Confirm any new bug fixes have corresponding tests
+ * Check that all dependencies are at stable versions (no pre-release dependencies in Cargo.toml)
+
+### Verify release tooling
+
+* From Command Line at project root:
+ * Confirm GitHub repository is current and git status is clean
+ * Ensure you have publishing credentials configured:
+ * If not set: `cargo login` and enter your crates.io API token
+ * At major version releases, search for deprecated code and remove at **Major Versions** only:
+ * `grep -r "deprecated" --include="*.rs" src/`
+
+## Create permanent release branch & release candidate version preparation
+
+* From IDE or Command Line:
+ * Create new **Permanent Branch**: "A.B.X"
+ * Modify `datasketches/Cargo.toml` version:
+ * Change version to `version = "A.B.X"`
+ * Commit the changes with message: "chore: prepare A.B.X release"
+ * Write down the Git hash: example: 40c6f4f
+ * Push Branch "A.B.X" to origin:
+ * `git push -u origin A.B.X`
+ * Do explicit push of tags on branch "A.B.X" to origin:
+ * `git push origin --tags`
+ * **DO NOT MERGE THIS PERMANENT BRANCH INTO THE DEFAULT BRANCH**
+
+* From a web browser at origin website: github.com/apache/datasketches-rust
+ * Select the A.B.X branch
+ * Confirm that the tag: A.B.X-rc.1 exists and that the tag is on the latest commit with the correct Git hash
+ * **DO NOT CREATE PR OR MERGE THIS PERMANENT BRANCH INTO THE DEFAULT BRANCH**
+
+## Publish release candidate to crates.io
+
+**IMPORTANT:** This step publishes a pre-release version to crates.io for community testing. The `-rc.N` suffix
+indicates this is not a final release.
+
+* Return to release branch A.B.X:
+ * `git checkout A.B.X`
+* Create Annotated TAG: A.B.X-rc.1
+ * `git tag -a A.B.X-rc.1 -m "release candidate 1 for version A.B.X"`
+* Modify `datasketches/Cargo.toml` version **temporarily**:
+ * Change version to `version = "A.B.X-rc.1"`
+* Review the package contents:
+ * `cargo package --list -p datasketches`
+ * Ensure no unwanted files are included
+ * Verify LICENSE, NOTICE, README.md are included
+* Run publish in dry-run and verify output:
+ * `cargo publish --dry-run -p datasketches`
+* Publish to crates.io:
+ * `cargo publish -p datasketches`
+* Verify the published crate:
+ * Visit https://crates.io/crates/datasketches
+ * Confirm A.B.X-rc.1 is visible
+ * Test installation: `cargo add datasketches@A.B.X-rc.1` in a test project
+* Reset all temporary changes with `git checkout -f A.B.X`:
+ * `cat datasketches/Cargo.toml | grep version` # should show A.B.X
+
+## Create and/or checkout local *dist/dev* directories on your system
+
+* If you have not already, on your system create the two directory structures that mirror the dist.apache.org/repos/
+ directories:
+ * `mkdir -p dist/dev/datasketches/`
+ * `mkdir -p dist/release/datasketches/`
+* Checkout both "dev" and "release" directories:
+ * Open a terminal in the dist/dev/datasketches directory and do a checkout:
+ * `svn co https://dist.apache.org/repos/dist/dev/datasketches/ .` #Note the DOT
+ * `svn status` # make sure it is clean
+ * Open a terminal in the dist/release/datasketches directory and do a checkout:
+ * `svn co https://dist.apache.org/repos/dist/release/datasketches/ .` #Note the DOT
+ * `svn status` # make sure it is clean
+
+## Create the candidate Apache release distribution on *dist/dev*
+
+### Create primary zip files & signatures
+
+* You will need the following arguments:
+ * Absolute path of target project.basedir on your system
+ * Artifact name: datasketches-rust
+ * GitHub Tag: A.B.X-rc.1 (or rc.N)
+
+* Start a new terminal in the *dist/dev/datasketches/scripts* directory on your system:
+ * To confirm *gpg-agent* is running type:
+ * `ps -axww | grep gpg` # you should see something like:
+ * *64438 ?? 0:30.33 gpg-agent --homedir /Users/\<name\>/.gnupg --use-standard-socket --daemon*
+ * To start GPG if GPG Agent is not running:
+ * `eval $(gpg-agent --daemon)`
+ * Run the deployment script:
+ * `./bashDeployToDist.sh /Users/\<name\>/dev/git/Apache/datasketches-rust datasketches-rust A.B.X-rc.1`
Review Comment:
> bashDeployToDist.sh
Do we have this script now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] docs: document release process (datasketches-rust)
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #61:
URL: https://github.com/apache/datasketches-rust/pull/61#issuecomment-3705154759
I'm feeling this is too complicated to follow. Although it covers many details, may we start with an easier version?
That is, many works should be guarded with CI. The release only steps are packaging the source tarball + calling a release on the mailing list. Perhaps with an extra cargo release, which can be automated later, like https://github.com/apache/opendal/blob/b430879d45412e960f2bb8313558dbc18feec6c9/.github/workflows/release_rust.yml#L76-L82
cc @Xuanwo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] docs: document release process (datasketches-rust)
Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho commented on code in PR #61:
URL: https://github.com/apache/datasketches-rust/pull/61#discussion_r2659277752
##########
RELEASE.md:
##########
@@ -0,0 +1,301 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# Release process for Rust components
+
+**NOTES:**
+
+* This process covers major and minor releases only. Bug-fix releases, which increment the third digit, are performed on
+ an A.B.X branch and not on main, but otherwise follow a similar process.
+* Some of these operations can be performed either on the Command-Line or in your IDE, whatever you prefer.
+
+## Preparation
+
+### Verify project health
+
+* Confirm correctness for:
+ * LICENSE
+ * NOTICE -- check for copyright dates
+ * README.md
+ * .asf.yaml
+ * .gitignore
+ * Cargo.toml -- ensure workspace metadata is correct
+
+* From Command Line or IDE:
+ * Run all checks: `cargo x lint`
+ * Run unit tests: `cargo x test`
+ * Run `cargo update` to ensure Cargo.lock is updated
+ <!-- TODO: * Run code coverage: `cargo llvm-cov --workspace` (target > 90%). -->
+ * Run tests on all platforms (see CI workflow)
+ * Confirm that documentation builds: `cargo doc --open`
+ * Confirm that all **temporary** branches are checked into main and/or deleted, both local and remote
+ * Confirm any new bug fixes have corresponding tests
+ * Check that all dependencies are at stable versions (no pre-release dependencies in Cargo.toml)
+
+### Verify release tooling
+
+* From Command Line at project root:
+ * Confirm GitHub repository is current and git status is clean
+ * Ensure you have publishing credentials configured:
+ * If not set: `cargo login` and enter your crates.io API token
+ * At major version releases, search for deprecated code and remove at **Major Versions** only:
+ * `grep -r "deprecated" --include="*.rs" src/`
+
+## Create permanent release branch & release candidate version preparation
+
+* From IDE or Command Line:
+ * Create new **Permanent Branch**: "A.B.X"
+ * Modify `datasketches/Cargo.toml` version:
+ * Change version to `version = "A.B.X"`
+ * Commit the changes with message: "chore: prepare A.B.X release"
+ * Write down the Git hash: example: 40c6f4f
+ * Push Branch "A.B.X" to origin:
+ * `git push -u origin A.B.X`
+ * Do explicit push of tags on branch "A.B.X" to origin:
+ * `git push origin --tags`
+ * **DO NOT MERGE THIS PERMANENT BRANCH INTO THE DEFAULT BRANCH**
+
+* From a web browser at origin website: github.com/apache/datasketches-rust
+ * Select the A.B.X branch
+ * Confirm that the tag: A.B.X-rc.1 exists and that the tag is on the latest commit with the correct Git hash
+ * **DO NOT CREATE PR OR MERGE THIS PERMANENT BRANCH INTO THE DEFAULT BRANCH**
+
+## Publish release candidate to crates.io
+
+**IMPORTANT:** This step publishes a pre-release version to crates.io for community testing. The `-rc.N` suffix
+indicates this is not a final release.
+
+* Return to release branch A.B.X:
+ * `git checkout A.B.X`
+* Create Annotated TAG: A.B.X-rc.1
+ * `git tag -a A.B.X-rc.1 -m "release candidate 1 for version A.B.X"`
+* Modify `datasketches/Cargo.toml` version **temporarily**:
+ * Change version to `version = "A.B.X-rc.1"`
+* Review the package contents:
+ * `cargo package --list -p datasketches`
+ * Ensure no unwanted files are included
+ * Verify LICENSE, NOTICE, README.md are included
+* Run publish in dry-run and verify output:
+ * `cargo publish --dry-run -p datasketches`
+* Publish to crates.io:
+ * `cargo publish -p datasketches`
+* Verify the published crate:
+ * Visit https://crates.io/crates/datasketches
+ * Confirm A.B.X-rc.1 is visible
+ * Test installation: `cargo add datasketches@A.B.X-rc.1` in a test project
+* Reset all temporary changes with `git checkout -f A.B.X`:
+ * `cat datasketches/Cargo.toml | grep version` # should show A.B.X
+
+## Create and/or checkout local *dist/dev* directories on your system
+
+* If you have not already, on your system create the two directory structures that mirror the dist.apache.org/repos/
+ directories:
+ * `mkdir -p dist/dev/datasketches/`
+ * `mkdir -p dist/release/datasketches/`
+* Checkout both "dev" and "release" directories:
+ * Open a terminal in the dist/dev/datasketches directory and do a checkout:
+ * `svn co https://dist.apache.org/repos/dist/dev/datasketches/ .` #Note the DOT
+ * `svn status` # make sure it is clean
+ * Open a terminal in the dist/release/datasketches directory and do a checkout:
+ * `svn co https://dist.apache.org/repos/dist/release/datasketches/ .` #Note the DOT
+ * `svn status` # make sure it is clean
+
+## Create the candidate Apache release distribution on *dist/dev*
+
+### Create primary zip files & signatures
+
+* You will need the following arguments:
+ * Absolute path of target project.basedir on your system
+ * Artifact name: datasketches-rust
+ * GitHub Tag: A.B.X-rc.1 (or rc.N)
+
+* Start a new terminal in the *dist/dev/datasketches/scripts* directory on your system:
+ * To confirm *gpg-agent* is running type:
+ * `ps -axww | grep gpg` # you should see something like:
+ * *64438 ?? 0:30.33 gpg-agent --homedir /Users/\<name\>/.gnupg --use-standard-socket --daemon*
+ * To start GPG if GPG Agent is not running:
+ * `eval $(gpg-agent --daemon)`
+ * Run the deployment script:
+ * `./bashDeployToDist.sh /Users/\<name\>/dev/git/Apache/datasketches-rust datasketches-rust A.B.X-rc.1`
+ * Follow the instructions
+ * NOTE: if you get the error "gpg: signing failed: No pinentry":
+ * open .gnupg/gpg-agent.conf
+ * change to: pinentry-program /usr/local/bin/pinentry-tty
+ * reload the gpg agent in the terminal: `gpg-connect-agent reloadagent /bye`
+ * restart the ./bashDeployToDist script
+ * Close the terminal
+
+* Check and grab the web URL: *https://dist.apache.org/repos/dist/dev/datasketches/rust/A.B.X-rc.1/*
+ * There should be 3 files: \*-src.zip, \*-src.zip.asc, \*-src.zip.sha512
+ * Verify signatures:
+ * `gpg --verify datasketches-rust-A.B.X-rc.1-src.zip.asc datasketches-rust-A.B.X-rc.1-src.zip`
+ * `sha512sum -c datasketches-rust-A.B.X-rc.1-src.zip.sha512`
+
+## Prepare & Send [VOTE] Letter to dev@
+
+* See VoteTemplates directory for a recent example
Review Comment:
My understanding is that Apache requires that messages for key events (like votes on releases, etc ) be documented / communicated on dev@. This is because the audience for these messages is the entire community of developers and users of a project. Also Apache keeps all these communications in its own archives for legal reasons. If these event messages were on different platforms, some users might not see the message and Apache would not have it in their archives.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] docs: document release process (datasketches-rust)
Posted by "notfilippo (via GitHub)" <gi...@apache.org>.
notfilippo commented on PR #61:
URL: https://github.com/apache/datasketches-rust/pull/61#issuecomment-3705667595
I've sent an invite!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] docs: document release process (datasketches-rust)
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #61:
URL: https://github.com/apache/datasketches-rust/pull/61#discussion_r2657578496
##########
RELEASE.md:
##########
@@ -0,0 +1,301 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# Release process for Rust components
+
+**NOTES:**
+
+* This process covers major and minor releases only. Bug-fix releases, which increment the third digit, are performed on
+ an A.B.X branch and not on main, but otherwise follow a similar process.
+* Some of these operations can be performed either on the Command-Line or in your IDE, whatever you prefer.
+
+## Preparation
+
+### Verify project health
+
+* Confirm correctness for:
+ * LICENSE
+ * NOTICE -- check for copyright dates
+ * README.md
+ * .asf.yaml
+ * .gitignore
+ * Cargo.toml -- ensure workspace metadata is correct
+
+* From Command Line or IDE:
+ * Run all checks: `cargo x lint`
+ * Run unit tests: `cargo x test`
+ * Run `cargo update` to ensure Cargo.lock is updated
+ <!-- TODO: * Run code coverage: `cargo llvm-cov --workspace` (target > 90%). -->
+ * Run tests on all platforms (see CI workflow)
+ * Confirm that documentation builds: `cargo doc --open`
+ * Confirm that all **temporary** branches are checked into main and/or deleted, both local and remote
+ * Confirm any new bug fixes have corresponding tests
+ * Check that all dependencies are at stable versions (no pre-release dependencies in Cargo.toml)
+
+### Verify release tooling
+
+* From Command Line at project root:
+ * Confirm GitHub repository is current and git status is clean
+ * Ensure you have publishing credentials configured:
+ * If not set: `cargo login` and enter your crates.io API token
+ * At major version releases, search for deprecated code and remove at **Major Versions** only:
+ * `grep -r "deprecated" --include="*.rs" src/`
Review Comment:
These are either trivial or should be checked with a workflow.
We don't actually have a process to do Major Versions release or handling deprecated code. Let's add something until we really need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] docs: document release process (datasketches-rust)
Posted by "notfilippo (via GitHub)" <gi...@apache.org>.
notfilippo commented on code in PR #61:
URL: https://github.com/apache/datasketches-rust/pull/61#discussion_r2657647331
##########
RELEASE.md:
##########
@@ -0,0 +1,301 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# Release process for Rust components
+
+**NOTES:**
+
+* This process covers major and minor releases only. Bug-fix releases, which increment the third digit, are performed on
+ an A.B.X branch and not on main, but otherwise follow a similar process.
+* Some of these operations can be performed either on the Command-Line or in your IDE, whatever you prefer.
+
+## Preparation
+
+### Verify project health
+
+* Confirm correctness for:
+ * LICENSE
+ * NOTICE -- check for copyright dates
+ * README.md
+ * .asf.yaml
+ * .gitignore
+ * Cargo.toml -- ensure workspace metadata is correct
+
+* From Command Line or IDE:
+ * Run all checks: `cargo x lint`
+ * Run unit tests: `cargo x test`
+ * Run `cargo update` to ensure Cargo.lock is updated
+ <!-- TODO: * Run code coverage: `cargo llvm-cov --workspace` (target > 90%). -->
+ * Run tests on all platforms (see CI workflow)
+ * Confirm that documentation builds: `cargo doc --open`
+ * Confirm that all **temporary** branches are checked into main and/or deleted, both local and remote
+ * Confirm any new bug fixes have corresponding tests
+ * Check that all dependencies are at stable versions (no pre-release dependencies in Cargo.toml)
+
+### Verify release tooling
+
+* From Command Line at project root:
+ * Confirm GitHub repository is current and git status is clean
+ * Ensure you have publishing credentials configured:
+ * If not set: `cargo login` and enter your crates.io API token
+ * At major version releases, search for deprecated code and remove at **Major Versions** only:
+ * `grep -r "deprecated" --include="*.rs" src/`
+
+## Create permanent release branch & release candidate version preparation
+
+* From IDE or Command Line:
+ * Create new **Permanent Branch**: "A.B.X"
+ * Modify `datasketches/Cargo.toml` version:
+ * Change version to `version = "A.B.X"`
+ * Commit the changes with message: "chore: prepare A.B.X release"
+ * Write down the Git hash: example: 40c6f4f
+ * Push Branch "A.B.X" to origin:
+ * `git push -u origin A.B.X`
+ * Do explicit push of tags on branch "A.B.X" to origin:
+ * `git push origin --tags`
+ * **DO NOT MERGE THIS PERMANENT BRANCH INTO THE DEFAULT BRANCH**
+
+* From a web browser at origin website: github.com/apache/datasketches-rust
+ * Select the A.B.X branch
+ * Confirm that the tag: A.B.X-rc.1 exists and that the tag is on the latest commit with the correct Git hash
+ * **DO NOT CREATE PR OR MERGE THIS PERMANENT BRANCH INTO THE DEFAULT BRANCH**
+
+## Publish release candidate to crates.io
+
+**IMPORTANT:** This step publishes a pre-release version to crates.io for community testing. The `-rc.N` suffix
+indicates this is not a final release.
+
+* Return to release branch A.B.X:
+ * `git checkout A.B.X`
+* Create Annotated TAG: A.B.X-rc.1
+ * `git tag -a A.B.X-rc.1 -m "release candidate 1 for version A.B.X"`
+* Modify `datasketches/Cargo.toml` version **temporarily**:
+ * Change version to `version = "A.B.X-rc.1"`
+* Review the package contents:
+ * `cargo package --list -p datasketches`
+ * Ensure no unwanted files are included
+ * Verify LICENSE, NOTICE, README.md are included
+* Run publish in dry-run and verify output:
+ * `cargo publish --dry-run -p datasketches`
+* Publish to crates.io:
+ * `cargo publish -p datasketches`
+* Verify the published crate:
+ * Visit https://crates.io/crates/datasketches
+ * Confirm A.B.X-rc.1 is visible
+ * Test installation: `cargo add datasketches@A.B.X-rc.1` in a test project
+* Reset all temporary changes with `git checkout -f A.B.X`:
+ * `cat datasketches/Cargo.toml | grep version` # should show A.B.X
+
+## Create and/or checkout local *dist/dev* directories on your system
+
+* If you have not already, on your system create the two directory structures that mirror the dist.apache.org/repos/
+ directories:
+ * `mkdir -p dist/dev/datasketches/`
+ * `mkdir -p dist/release/datasketches/`
+* Checkout both "dev" and "release" directories:
+ * Open a terminal in the dist/dev/datasketches directory and do a checkout:
+ * `svn co https://dist.apache.org/repos/dist/dev/datasketches/ .` #Note the DOT
+ * `svn status` # make sure it is clean
+ * Open a terminal in the dist/release/datasketches directory and do a checkout:
+ * `svn co https://dist.apache.org/repos/dist/release/datasketches/ .` #Note the DOT
+ * `svn status` # make sure it is clean
+
+## Create the candidate Apache release distribution on *dist/dev*
+
+### Create primary zip files & signatures
+
+* You will need the following arguments:
+ * Absolute path of target project.basedir on your system
+ * Artifact name: datasketches-rust
+ * GitHub Tag: A.B.X-rc.1 (or rc.N)
+
+* Start a new terminal in the *dist/dev/datasketches/scripts* directory on your system:
+ * To confirm *gpg-agent* is running type:
+ * `ps -axww | grep gpg` # you should see something like:
+ * *64438 ?? 0:30.33 gpg-agent --homedir /Users/\<name\>/.gnupg --use-standard-socket --daemon*
+ * To start GPG if GPG Agent is not running:
+ * `eval $(gpg-agent --daemon)`
+ * Run the deployment script:
+ * `./bashDeployToDist.sh /Users/\<name\>/dev/git/Apache/datasketches-rust datasketches-rust A.B.X-rc.1`
Review Comment:
I think these scripts are here: https://dist.apache.org/repos/dist/dev/datasketches, along with vote templates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] docs: document release process (datasketches-rust)
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #61:
URL: https://github.com/apache/datasketches-rust/pull/61#issuecomment-3706669146
I've tested rc.1 and the T-Digest sketch works well.
Let's enjoy the holiday and wait for PMC's feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] docs: document release process (datasketches-rust)
Posted by "PsiACE (via GitHub)" <gi...@apache.org>.
PsiACE commented on code in PR #61:
URL: https://github.com/apache/datasketches-rust/pull/61#discussion_r2659295062
##########
RELEASE.md:
##########
@@ -0,0 +1,301 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# Release process for Rust components
+
+**NOTES:**
+
+* This process covers major and minor releases only. Bug-fix releases, which increment the third digit, are performed on
+ an A.B.X branch and not on main, but otherwise follow a similar process.
+* Some of these operations can be performed either on the Command-Line or in your IDE, whatever you prefer.
+
+## Preparation
+
+### Verify project health
+
+* Confirm correctness for:
+ * LICENSE
+ * NOTICE -- check for copyright dates
+ * README.md
+ * .asf.yaml
+ * .gitignore
+ * Cargo.toml -- ensure workspace metadata is correct
+
+* From Command Line or IDE:
+ * Run all checks: `cargo x lint`
+ * Run unit tests: `cargo x test`
+ * Run `cargo update` to ensure Cargo.lock is updated
+ <!-- TODO: * Run code coverage: `cargo llvm-cov --workspace` (target > 90%). -->
+ * Run tests on all platforms (see CI workflow)
+ * Confirm that documentation builds: `cargo doc --open`
+ * Confirm that all **temporary** branches are checked into main and/or deleted, both local and remote
+ * Confirm any new bug fixes have corresponding tests
+ * Check that all dependencies are at stable versions (no pre-release dependencies in Cargo.toml)
+
+### Verify release tooling
+
+* From Command Line at project root:
+ * Confirm GitHub repository is current and git status is clean
+ * Ensure you have publishing credentials configured:
+ * If not set: `cargo login` and enter your crates.io API token
+ * At major version releases, search for deprecated code and remove at **Major Versions** only:
+ * `grep -r "deprecated" --include="*.rs" src/`
+
+## Create permanent release branch & release candidate version preparation
+
+* From IDE or Command Line:
+ * Create new **Permanent Branch**: "A.B.X"
+ * Modify `datasketches/Cargo.toml` version:
+ * Change version to `version = "A.B.X"`
+ * Commit the changes with message: "chore: prepare A.B.X release"
+ * Write down the Git hash: example: 40c6f4f
+ * Push Branch "A.B.X" to origin:
+ * `git push -u origin A.B.X`
+ * Do explicit push of tags on branch "A.B.X" to origin:
+ * `git push origin --tags`
+ * **DO NOT MERGE THIS PERMANENT BRANCH INTO THE DEFAULT BRANCH**
+
+* From a web browser at origin website: github.com/apache/datasketches-rust
+ * Select the A.B.X branch
+ * Confirm that the tag: A.B.X-rc.1 exists and that the tag is on the latest commit with the correct Git hash
+ * **DO NOT CREATE PR OR MERGE THIS PERMANENT BRANCH INTO THE DEFAULT BRANCH**
+
+## Publish release candidate to crates.io
+
+**IMPORTANT:** This step publishes a pre-release version to crates.io for community testing. The `-rc.N` suffix
+indicates this is not a final release.
+
+* Return to release branch A.B.X:
+ * `git checkout A.B.X`
+* Create Annotated TAG: A.B.X-rc.1
+ * `git tag -a A.B.X-rc.1 -m "release candidate 1 for version A.B.X"`
+* Modify `datasketches/Cargo.toml` version **temporarily**:
+ * Change version to `version = "A.B.X-rc.1"`
+* Review the package contents:
+ * `cargo package --list -p datasketches`
+ * Ensure no unwanted files are included
+ * Verify LICENSE, NOTICE, README.md are included
+* Run publish in dry-run and verify output:
+ * `cargo publish --dry-run -p datasketches`
+* Publish to crates.io:
+ * `cargo publish -p datasketches`
+* Verify the published crate:
+ * Visit https://crates.io/crates/datasketches
+ * Confirm A.B.X-rc.1 is visible
+ * Test installation: `cargo add datasketches@A.B.X-rc.1` in a test project
+* Reset all temporary changes with `git checkout -f A.B.X`:
+ * `cat datasketches/Cargo.toml | grep version` # should show A.B.X
+
+## Create and/or checkout local *dist/dev* directories on your system
+
+* If you have not already, on your system create the two directory structures that mirror the dist.apache.org/repos/
+ directories:
+ * `mkdir -p dist/dev/datasketches/`
+ * `mkdir -p dist/release/datasketches/`
+* Checkout both "dev" and "release" directories:
+ * Open a terminal in the dist/dev/datasketches directory and do a checkout:
+ * `svn co https://dist.apache.org/repos/dist/dev/datasketches/ .` #Note the DOT
+ * `svn status` # make sure it is clean
+ * Open a terminal in the dist/release/datasketches directory and do a checkout:
+ * `svn co https://dist.apache.org/repos/dist/release/datasketches/ .` #Note the DOT
+ * `svn status` # make sure it is clean
+
+## Create the candidate Apache release distribution on *dist/dev*
+
+### Create primary zip files & signatures
+
+* You will need the following arguments:
+ * Absolute path of target project.basedir on your system
+ * Artifact name: datasketches-rust
+ * GitHub Tag: A.B.X-rc.1 (or rc.N)
+
+* Start a new terminal in the *dist/dev/datasketches/scripts* directory on your system:
+ * To confirm *gpg-agent* is running type:
+ * `ps -axww | grep gpg` # you should see something like:
+ * *64438 ?? 0:30.33 gpg-agent --homedir /Users/\<name\>/.gnupg --use-standard-socket --daemon*
+ * To start GPG if GPG Agent is not running:
+ * `eval $(gpg-agent --daemon)`
+ * Run the deployment script:
+ * `./bashDeployToDist.sh /Users/\<name\>/dev/git/Apache/datasketches-rust datasketches-rust A.B.X-rc.1`
+ * Follow the instructions
+ * NOTE: if you get the error "gpg: signing failed: No pinentry":
+ * open .gnupg/gpg-agent.conf
+ * change to: pinentry-program /usr/local/bin/pinentry-tty
+ * reload the gpg agent in the terminal: `gpg-connect-agent reloadagent /bye`
+ * restart the ./bashDeployToDist script
+ * Close the terminal
+
+* Check and grab the web URL: *https://dist.apache.org/repos/dist/dev/datasketches/rust/A.B.X-rc.1/*
+ * There should be 3 files: \*-src.zip, \*-src.zip.asc, \*-src.zip.sha512
+ * Verify signatures:
+ * `gpg --verify datasketches-rust-A.B.X-rc.1-src.zip.asc datasketches-rust-A.B.X-rc.1-src.zip`
+ * `sha512sum -c datasketches-rust-A.B.X-rc.1-src.zip.sha512`
+
+## Prepare & Send [VOTE] Letter to dev@
+
+* See VoteTemplates directory for a recent example
Review Comment:
Yes. In fact, these contents will automatically sync to `dev@`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] docs: document release process (datasketches-rust)
Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho commented on code in PR #61:
URL: https://github.com/apache/datasketches-rust/pull/61#discussion_r2659274150
##########
RELEASE.md:
##########
@@ -0,0 +1,301 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# Release process for Rust components
+
+**NOTES:**
+
+* This process covers major and minor releases only. Bug-fix releases, which increment the third digit, are performed on
+ an A.B.X branch and not on main, but otherwise follow a similar process.
+* Some of these operations can be performed either on the Command-Line or in your IDE, whatever you prefer.
+
+## Preparation
+
+### Verify project health
+
+* Confirm correctness for:
+ * LICENSE
+ * NOTICE -- check for copyright dates
+ * README.md
+ * .asf.yaml
+ * .gitignore
+ * Cargo.toml -- ensure workspace metadata is correct
+
+* From Command Line or IDE:
+ * Run all checks: `cargo x lint`
+ * Run unit tests: `cargo x test`
+ * Run `cargo update` to ensure Cargo.lock is updated
+ <!-- TODO: * Run code coverage: `cargo llvm-cov --workspace` (target > 90%). -->
+ * Run tests on all platforms (see CI workflow)
+ * Confirm that documentation builds: `cargo doc --open`
+ * Confirm that all **temporary** branches are checked into main and/or deleted, both local and remote
+ * Confirm any new bug fixes have corresponding tests
+ * Check that all dependencies are at stable versions (no pre-release dependencies in Cargo.toml)
+
+### Verify release tooling
+
+* From Command Line at project root:
+ * Confirm GitHub repository is current and git status is clean
+ * Ensure you have publishing credentials configured:
+ * If not set: `cargo login` and enter your crates.io API token
+ * At major version releases, search for deprecated code and remove at **Major Versions** only:
+ * `grep -r "deprecated" --include="*.rs" src/`
+
+## Create permanent release branch & release candidate version preparation
+
+* From IDE or Command Line:
+ * Create new **Permanent Branch**: "A.B.X"
+ * Modify `datasketches/Cargo.toml` version:
+ * Change version to `version = "A.B.X"`
+ * Commit the changes with message: "chore: prepare A.B.X release"
+ * Write down the Git hash: example: 40c6f4f
+ * Push Branch "A.B.X" to origin:
+ * `git push -u origin A.B.X`
+ * Do explicit push of tags on branch "A.B.X" to origin:
+ * `git push origin --tags`
+ * **DO NOT MERGE THIS PERMANENT BRANCH INTO THE DEFAULT BRANCH**
+
+* From a web browser at origin website: github.com/apache/datasketches-rust
+ * Select the A.B.X branch
+ * Confirm that the tag: A.B.X-rc.1 exists and that the tag is on the latest commit with the correct Git hash
+ * **DO NOT CREATE PR OR MERGE THIS PERMANENT BRANCH INTO THE DEFAULT BRANCH**
+
+## Publish release candidate to crates.io
+
+**IMPORTANT:** This step publishes a pre-release version to crates.io for community testing. The `-rc.N` suffix
+indicates this is not a final release.
+
+* Return to release branch A.B.X:
+ * `git checkout A.B.X`
+* Create Annotated TAG: A.B.X-rc.1
+ * `git tag -a A.B.X-rc.1 -m "release candidate 1 for version A.B.X"`
+* Modify `datasketches/Cargo.toml` version **temporarily**:
+ * Change version to `version = "A.B.X-rc.1"`
+* Review the package contents:
+ * `cargo package --list -p datasketches`
+ * Ensure no unwanted files are included
+ * Verify LICENSE, NOTICE, README.md are included
+* Run publish in dry-run and verify output:
+ * `cargo publish --dry-run -p datasketches`
+* Publish to crates.io:
+ * `cargo publish -p datasketches`
+* Verify the published crate:
+ * Visit https://crates.io/crates/datasketches
+ * Confirm A.B.X-rc.1 is visible
+ * Test installation: `cargo add datasketches@A.B.X-rc.1` in a test project
+* Reset all temporary changes with `git checkout -f A.B.X`:
+ * `cat datasketches/Cargo.toml | grep version` # should show A.B.X
+
+## Create and/or checkout local *dist/dev* directories on your system
+
+* If you have not already, on your system create the two directory structures that mirror the dist.apache.org/repos/
+ directories:
+ * `mkdir -p dist/dev/datasketches/`
+ * `mkdir -p dist/release/datasketches/`
+* Checkout both "dev" and "release" directories:
+ * Open a terminal in the dist/dev/datasketches directory and do a checkout:
+ * `svn co https://dist.apache.org/repos/dist/dev/datasketches/ .` #Note the DOT
+ * `svn status` # make sure it is clean
+ * Open a terminal in the dist/release/datasketches directory and do a checkout:
+ * `svn co https://dist.apache.org/repos/dist/release/datasketches/ .` #Note the DOT
+ * `svn status` # make sure it is clean
+
+## Create the candidate Apache release distribution on *dist/dev*
+
+### Create primary zip files & signatures
+
+* You will need the following arguments:
+ * Absolute path of target project.basedir on your system
+ * Artifact name: datasketches-rust
+ * GitHub Tag: A.B.X-rc.1 (or rc.N)
+
+* Start a new terminal in the *dist/dev/datasketches/scripts* directory on your system:
+ * To confirm *gpg-agent* is running type:
+ * `ps -axww | grep gpg` # you should see something like:
+ * *64438 ?? 0:30.33 gpg-agent --homedir /Users/\<name\>/.gnupg --use-standard-socket --daemon*
+ * To start GPG if GPG Agent is not running:
+ * `eval $(gpg-agent --daemon)`
+ * Run the deployment script:
+ * `./bashDeployToDist.sh /Users/\<name\>/dev/git/Apache/datasketches-rust datasketches-rust A.B.X-rc.1`
+ * Follow the instructions
+ * NOTE: if you get the error "gpg: signing failed: No pinentry":
+ * open .gnupg/gpg-agent.conf
+ * change to: pinentry-program /usr/local/bin/pinentry-tty
+ * reload the gpg agent in the terminal: `gpg-connect-agent reloadagent /bye`
+ * restart the ./bashDeployToDist script
+ * Close the terminal
+
+* Check and grab the web URL: *https://dist.apache.org/repos/dist/dev/datasketches/rust/A.B.X-rc.1/*
+ * There should be 3 files: \*-src.zip, \*-src.zip.asc, \*-src.zip.sha512
+ * Verify signatures:
+ * `gpg --verify datasketches-rust-A.B.X-rc.1-src.zip.asc datasketches-rust-A.B.X-rc.1-src.zip`
+ * `sha512sum -c datasketches-rust-A.B.X-rc.1-src.zip.sha512`
+
+## Prepare & Send [VOTE] Letter to dev@
+
+* See VoteTemplates directory for a recent example
Review Comment:
I added a new Vote Template in [VoteTemplates](https://dist.apache.org/repos/dist/dev/datasketches/VoteTemplates/)
There used to be more but they were out of date and I had removed them. The only other template that you might need would be the [ANNOUNCE] template, which is much simpler. You can find examples in dev@ history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org