You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by pa...@apache.org on 2022/05/30 12:56:58 UTC

[shardingsphere] branch master updated: Fix TransactionContexts is not closed in ContextManager (#18074)

This is an automated email from the ASF dual-hosted git repository.

panjuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 810853789bb Fix TransactionContexts is not closed in ContextManager (#18074)
810853789bb is described below

commit 810853789bb4ad0580b8e754e01f5af92f9b38bb
Author: 吴伟杰 <wu...@apache.org>
AuthorDate: Mon May 30 20:56:53 2022 +0800

    Fix TransactionContexts is not closed in ContextManager (#18074)
---
 .../main/java/org/apache/shardingsphere/mode/manager/ContextManager.java | 1 +
 .../java/org/apache/shardingsphere/mode/manager/ContextManagerTest.java  | 1 +
 2 files changed, 2 insertions(+)

diff --git a/shardingsphere-mode/shardingsphere-mode-core/src/main/java/org/apache/shardingsphere/mode/manager/ContextManager.java b/shardingsphere-mode/shardingsphere-mode-core/src/main/java/org/apache/shardingsphere/mode/manager/ContextManager.java
index e60bbcd974a..b9a01bfe4c9 100644
--- a/shardingsphere-mode/shardingsphere-mode-core/src/main/java/org/apache/shardingsphere/mode/manager/ContextManager.java
+++ b/shardingsphere-mode/shardingsphere-mode-core/src/main/java/org/apache/shardingsphere/mode/manager/ContextManager.java
@@ -701,5 +701,6 @@ public final class ContextManager implements AutoCloseable {
     public void close() throws Exception {
         executorEngine.close();
         metaDataContexts.close();
+        transactionContexts.close();
     }
 }
diff --git a/shardingsphere-mode/shardingsphere-mode-core/src/test/java/org/apache/shardingsphere/mode/manager/ContextManagerTest.java b/shardingsphere-mode/shardingsphere-mode-core/src/test/java/org/apache/shardingsphere/mode/manager/ContextManagerTest.java
index 68b34c6a654..9ec1a5de484 100644
--- a/shardingsphere-mode/shardingsphere-mode-core/src/test/java/org/apache/shardingsphere/mode/manager/ContextManagerTest.java
+++ b/shardingsphere-mode/shardingsphere-mode-core/src/test/java/org/apache/shardingsphere/mode/manager/ContextManagerTest.java
@@ -276,5 +276,6 @@ public final class ContextManagerTest {
     public void assertClose() throws Exception {
         contextManager.close();
         verify(metaDataContexts).close();
+        verify(contextManager.getTransactionContexts()).close();
     }
 }