You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by Julien Vermillard <jv...@archean.fr> on 2008/11/12 10:22:28 UTC
[VOTE] Merging some simplifications
Hi,
Since it's cutting some feature, I would like a vote before merging
my branch from sandbox to trunk.
The branch :
http://svn.apache.org/repos/asf/mina/sandbox/jvermillard/mina-cleaning/
The list of changes :
http://svnsearch.org/svnsearch/repos/ASF/search?path=%2Fmina%2Fsandbox%2Fjvermillard%2Fmina-cleaning
* Removed IoService idle event, you still have IoSession idle.
* Reworked IdleStatusChecker for make the code easier to understand.
* Removed setTrafficMask and keeped suspendWrite / suspendRead methods.
* Removed trafficMask event from the IoFilter chain.
* Applied http://issues.apache.org/jira/browse/DIRMINA-620 by
removing superfluous IoSession close() methods. When you close a
session, you need to use session.close(boolean); and say explicitly
if you want to flush the write queue or no.
[ ]: +1, Merge to trunk
[ ]: 0, Abstain
[ ]: -1, Don't merge
Julien
Re: [VOTE] Merging some simplifications
Posted by Emmanuel Lecharny <el...@gmail.com>.
Irving, Dave wrote:
> [ X ]: +1, Merge to trunk
>
> Simplicity is king :)
>
And we should be simplicity lackeys :)
--
--
cordialement, regards,
Emmanuel Lécharny
www.iktek.com
directory.apache.org
RE: [VOTE] Merging some simplifications
Posted by "Irving, Dave" <da...@bankofamerica.com>.
[ X ]: +1, Merge to trunk
[ ]: 0, Abstain
[ ]: -1, Don't merge
Simplicity is king :)
D
Notice to recipient:
The information in this internet e-mail and any attachments is confidential and may be privileged. It is intended solely for the addressee. If you are not the intended addressee please notify the sender immediately by telephone. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited and may be unlawful.
When addressed to external clients any opinions or advice contained in this internet e-mail are subject to the terms and conditions expressed in any applicable governing terms of business or client engagement letter issued by the pertinent Bank of America group entity.
If this email originates from the U.K. please note that Bank of America, N.A., London Branch and Banc of America Securities Limited are authorised and regulated by the Financial Services Authority. For all U.K. corporate disclosures, please refer to www.bankofamerica.com/ukcompanies
Re: [VOTE] Merging some simplifications
Posted by Niklas Gustavsson <ni...@protocol7.com>.
On Wed, Nov 12, 2008 at 10:22 AM, Julien Vermillard
<jv...@archean.fr> wrote:
> [X]: +1, Merge to trunk
Seems reasonable.
/niklas
Re: Re : [VOTE] Merging some simplifications
Posted by Maarten Bosteels <mb...@gmail.com>.
simplicity++
On Wed, Nov 12, 2008 at 6:52 PM, Mark Webb <el...@gmail.com> wrote:
> simple is all I understand. +1
>
> On Wed, Nov 12, 2008 at 11:36 AM, Edouard De Oliveira
> <do...@yahoo.fr> wrote:
> > +1 for merging
> > Cordialement, Regards,
> > -Edouard De Oliveira-
> > http://tedorg.free.fr/en/main.php
> >
> >
> >
> >
> > ________________________________
> > De : Julien Vermillard <jv...@archean.fr>
> > À : dev@mina.apache.org
> > Envoyé le : Mercredi, 12 Novembre 2008, 10h22mn 28s
> > Objet : [VOTE] Merging some simplifications
> >
> > Hi,
> > Since it's cutting some feature, I would like a vote before merging
> > my branch from sandbox to trunk.
> >
> > The branch :
> > http://svn.apache.org/repos/asf/mina/sandbox/jvermillard/mina-cleaning/
> >
> > The list of changes :
> >
> http://svnsearch.org/svnsearch/repos/ASF/search?path=%2Fmina%2Fsandbox%2Fjvermillard%2Fmina-cleaning
> >
> > * Removed IoService idle event, you still have IoSession idle.
> > * Reworked IdleStatusChecker for make the code easier to understand.
> > * Removed setTrafficMask and keeped suspendWrite / suspendRead methods.
> > * Removed trafficMask event from the IoFilter chain.
> > * Applied http://issues.apache.org/jira/browse/DIRMINA-620 by
> > removing superfluous IoSession close() methods. When you close a
> > session, you need to use session.close(boolean); and say explicitly
> > if you want to flush the write queue or no.
> >
> > [ ]: +1, Merge to trunk
> > [ ]: 0, Abstain
> > [ ]: -1, Don't merge
> >
> > Julien
> >
> >
> >
>
Re: Re : [VOTE] Merging some simplifications
Posted by Mark Webb <el...@gmail.com>.
simple is all I understand. +1
On Wed, Nov 12, 2008 at 11:36 AM, Edouard De Oliveira
<do...@yahoo.fr> wrote:
> +1 for merging
> Cordialement, Regards,
> -Edouard De Oliveira-
> http://tedorg.free.fr/en/main.php
>
>
>
>
> ________________________________
> De : Julien Vermillard <jv...@archean.fr>
> À : dev@mina.apache.org
> Envoyé le : Mercredi, 12 Novembre 2008, 10h22mn 28s
> Objet : [VOTE] Merging some simplifications
>
> Hi,
> Since it's cutting some feature, I would like a vote before merging
> my branch from sandbox to trunk.
>
> The branch :
> http://svn.apache.org/repos/asf/mina/sandbox/jvermillard/mina-cleaning/
>
> The list of changes :
> http://svnsearch.org/svnsearch/repos/ASF/search?path=%2Fmina%2Fsandbox%2Fjvermillard%2Fmina-cleaning
>
> * Removed IoService idle event, you still have IoSession idle.
> * Reworked IdleStatusChecker for make the code easier to understand.
> * Removed setTrafficMask and keeped suspendWrite / suspendRead methods.
> * Removed trafficMask event from the IoFilter chain.
> * Applied http://issues.apache.org/jira/browse/DIRMINA-620 by
> removing superfluous IoSession close() methods. When you close a
> session, you need to use session.close(boolean); and say explicitly
> if you want to flush the write queue or no.
>
> [ ]: +1, Merge to trunk
> [ ]: 0, Abstain
> [ ]: -1, Don't merge
>
> Julien
>
>
>
Re : [VOTE] Merging some simplifications
Posted by Edouard De Oliveira <do...@yahoo.fr>.
+1 for merging
Cordialement, Regards,
-Edouard De Oliveira-
http://tedorg.free.fr/en/main.php
________________________________
De : Julien Vermillard <jv...@archean.fr>
À : dev@mina.apache.org
Envoyé le : Mercredi, 12 Novembre 2008, 10h22mn 28s
Objet : [VOTE] Merging some simplifications
Hi,
Since it's cutting some feature, I would like a vote before merging
my branch from sandbox to trunk.
The branch :
http://svn.apache.org/repos/asf/mina/sandbox/jvermillard/mina-cleaning/
The list of changes :
http://svnsearch.org/svnsearch/repos/ASF/search?path=%2Fmina%2Fsandbox%2Fjvermillard%2Fmina-cleaning
* Removed IoService idle event, you still have IoSession idle.
* Reworked IdleStatusChecker for make the code easier to understand.
* Removed setTrafficMask and keeped suspendWrite / suspendRead methods.
* Removed trafficMask event from the IoFilter chain.
* Applied http://issues.apache.org/jira/browse/DIRMINA-620 by
removing superfluous IoSession close() methods. When you close a
session, you need to use session.close(boolean); and say explicitly
if you want to flush the write queue or no.
[ ]: +1, Merge to trunk
[ ]: 0, Abstain
[ ]: -1, Don't merge
Julien
Re: [VOTE] Merging some simplifications
Posted by Julien Vermillard <jv...@archean.fr>.
On Fri, 14 Nov 2008 10:17:15 +0100
Emmanuel Lecharny <el...@gmail.com> wrote:
> Julien Vermillard wrote:
> > Hi
> > Looks like we got consensus here, I'm going to merge.
> >
> Merge, baby, merge !
>
It's done :)
Re: [VOTE] Merging some simplifications
Posted by Emmanuel Lecharny <el...@gmail.com>.
Julien Vermillard wrote:
> Hi
> Looks like we got consensus here, I'm going to merge.
>
Merge, baby, merge !
--
--
cordialement, regards,
Emmanuel Lécharny
www.iktek.com
directory.apache.org
Re: [VOTE] Merging some simplifications
Posted by Julien Vermillard <jv...@archean.fr>.
Hi
Looks like we got consensus here, I'm going to merge.
Julien
On Wed, 12 Nov 2008 10:22:28 +0100
Julien Vermillard <jv...@archean.fr> wrote:
> Hi,
> Since it's cutting some feature, I would like a vote before merging
> my branch from sandbox to trunk.
>
> The branch :
> http://svn.apache.org/repos/asf/mina/sandbox/jvermillard/mina-cleaning/
>
> The list of changes :
> http://svnsearch.org/svnsearch/repos/ASF/search?path=%2Fmina%2Fsandbox%2Fjvermillard%2Fmina-cleaning
>
> * Removed IoService idle event, you still have IoSession idle.
> * Reworked IdleStatusChecker for make the code easier to understand.
> * Removed setTrafficMask and keeped suspendWrite / suspendRead
> methods.
> * Removed trafficMask event from the IoFilter chain.
> * Applied http://issues.apache.org/jira/browse/DIRMINA-620 by
> removing superfluous IoSession close() methods. When you close a
> session, you need to use session.close(boolean); and say explicitly
> if you want to flush the write queue or no.
>
> [ ]: +1, Merge to trunk
> [ ]: 0, Abstain
> [ ]: -1, Don't merge
>
> Julien
>
>