You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Kevin Wilfong (JIRA)" <ji...@apache.org> on 2012/10/16 00:33:04 UTC

[jira] [Created] (HIVE-3581) get_json_object and json_tuple return null in the presence of new line characters

Kevin Wilfong created HIVE-3581:
-----------------------------------

             Summary: get_json_object and json_tuple return null in the presence of new line characters
                 Key: HIVE-3581
                 URL: https://issues.apache.org/jira/browse/HIVE-3581
             Project: Hive
          Issue Type: Bug
          Components: Query Processor
    Affects Versions: 0.10.0
            Reporter: Kevin Wilfong
            Assignee: Kevin Wilfong


This was introduced when these functions were updated to use Jackson.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3581) get_json_object and json_tuple return null in the presence of new line characters

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476965#comment-13476965 ] 

Hudson commented on HIVE-3581:
------------------------------

Integrated in Hive-trunk-h0.21 #1740 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1740/])
    HIVE-3581 get_json_object and json_tuple return null in the presence of new line characters
(Kevin Wilfong via namit) (Revision 1398654)

     Result = ABORTED
namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1398654
Files : 
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFJson.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFJSONTuple.java
* /hive/trunk/ql/src/test/queries/clientpositive/udf_get_json_object.q
* /hive/trunk/ql/src/test/queries/clientpositive/udtf_json_tuple.q
* /hive/trunk/ql/src/test/results/clientpositive/udf_get_json_object.q.out
* /hive/trunk/ql/src/test/results/clientpositive/udtf_json_tuple.q.out

                
> get_json_object and json_tuple return null in the presence of new line characters
> ---------------------------------------------------------------------------------
>
>                 Key: HIVE-3581
>                 URL: https://issues.apache.org/jira/browse/HIVE-3581
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.10.0
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-3581.1.patch.txt
>
>
> This was introduced when these functions were updated to use Jackson.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3581) get_json_object and json_tuple return null in the presence of new line characters

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476598#comment-13476598 ] 

Namit Jain commented on HIVE-3581:
----------------------------------

+1
                
> get_json_object and json_tuple return null in the presence of new line characters
> ---------------------------------------------------------------------------------
>
>                 Key: HIVE-3581
>                 URL: https://issues.apache.org/jira/browse/HIVE-3581
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.10.0
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-3581.1.patch.txt
>
>
> This was introduced when these functions were updated to use Jackson.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-3581) get_json_object and json_tuple return null in the presence of new line characters

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-3581:
-----------------------------

      Resolution: Fixed
    Hadoop Flags: Reviewed
          Status: Resolved  (was: Patch Available)

Committed. Thanks Kevin
                
> get_json_object and json_tuple return null in the presence of new line characters
> ---------------------------------------------------------------------------------
>
>                 Key: HIVE-3581
>                 URL: https://issues.apache.org/jira/browse/HIVE-3581
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.10.0
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-3581.1.patch.txt
>
>
> This was introduced when these functions were updated to use Jackson.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-3581) get_json_object and json_tuple return null in the presence of new line characters

Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Wilfong updated HIVE-3581:
--------------------------------

    Attachment: HIVE-3581.1.patch.txt
    
> get_json_object and json_tuple return null in the presence of new line characters
> ---------------------------------------------------------------------------------
>
>                 Key: HIVE-3581
>                 URL: https://issues.apache.org/jira/browse/HIVE-3581
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.10.0
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-3581.1.patch.txt
>
>
> This was introduced when these functions were updated to use Jackson.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3581) get_json_object and json_tuple return null in the presence of new line characters

Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481952#comment-13481952 ] 

Kevin Wilfong commented on HIVE-3581:
-------------------------------------

Filed HIVE-3607 to set mapreduce.task.classpath.user.precedence to true.
                
> get_json_object and json_tuple return null in the presence of new line characters
> ---------------------------------------------------------------------------------
>
>                 Key: HIVE-3581
>                 URL: https://issues.apache.org/jira/browse/HIVE-3581
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.10.0
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-3581.1.patch.txt
>
>
> This was introduced when these functions were updated to use Jackson.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3581) get_json_object and json_tuple return null in the presence of new line characters

Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476552#comment-13476552 ] 

Kevin Wilfong commented on HIVE-3581:
-------------------------------------

diff here https://reviews.facebook.net/D6039
                
> get_json_object and json_tuple return null in the presence of new line characters
> ---------------------------------------------------------------------------------
>
>                 Key: HIVE-3581
>                 URL: https://issues.apache.org/jira/browse/HIVE-3581
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.10.0
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-3581.1.patch.txt
>
>
> This was introduced when these functions were updated to use Jackson.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-3581) get_json_object and json_tuple return null in the presence of new line characters

Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Wilfong updated HIVE-3581:
--------------------------------

    Status: Patch Available  (was: Open)
    
> get_json_object and json_tuple return null in the presence of new line characters
> ---------------------------------------------------------------------------------
>
>                 Key: HIVE-3581
>                 URL: https://issues.apache.org/jira/browse/HIVE-3581
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.10.0
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-3581.1.patch.txt
>
>
> This was introduced when these functions were updated to use Jackson.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3581) get_json_object and json_tuple return null in the presence of new line characters

Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479137#comment-13479137 ] 

Kevin Wilfong commented on HIVE-3581:
-------------------------------------

Sorry about that.  It looks like we'll either need to set mapreduce.task.classpath.user.precedence to true in Hive, or provide two versions of JSON parsing, one using JSONObject and the other using Jackson, controlled by a config.  I think the former sounds preferable provided it works.
                
> get_json_object and json_tuple return null in the presence of new line characters
> ---------------------------------------------------------------------------------
>
>                 Key: HIVE-3581
>                 URL: https://issues.apache.org/jira/browse/HIVE-3581
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.10.0
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-3581.1.patch.txt
>
>
> This was introduced when these functions were updated to use Jackson.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3581) get_json_object and json_tuple return null in the presence of new line characters

Posted by "Philip Tromans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477800#comment-13477800 ] 

Philip Tromans commented on HIVE-3581:
--------------------------------------

This patch breaks hive trunk on Hadoop 0.20.205.0, I guess because of the difference in Jackson versions. Running hive gives:

Exception in thread "main" java.lang.NoSuchFieldError: ALLOW_UNQUOTED_CONTROL_CHARS
        at org.apache.hadoop.hive.ql.udf.generic.GenericUDTFJSONTuple.<clinit>(GenericUDTFJSONTuple.java:59)
        at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
        at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
        at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
        at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
        at org.apache.hadoop.util.ReflectionUtils.newInstance(ReflectionUtils.java:113)
        at org.apache.hadoop.hive.ql.exec.FunctionRegistry.registerGenericUDTF(FunctionRegistry.java:545)
        at org.apache.hadoop.hive.ql.exec.FunctionRegistry.registerGenericUDTF(FunctionRegistry.java:539)
        at org.apache.hadoop.hive.ql.exec.FunctionRegistry.<clinit>(FunctionRegistry.java:472)
        at org.apache.hadoop.hive.ql.session.SessionState.<init>(SessionState.java:202)
        at org.apache.hadoop.hive.cli.CliSessionState.<init>(CliSessionState.java:86)
        at org.apache.hadoop.hive.cli.CliDriver.run(CliDriver.java:635)
        at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:613)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:597)
        at org.apache.hadoop.util.RunJar.main(RunJar.java:156)

Backing the patch out makes everything work again.
                
> get_json_object and json_tuple return null in the presence of new line characters
> ---------------------------------------------------------------------------------
>
>                 Key: HIVE-3581
>                 URL: https://issues.apache.org/jira/browse/HIVE-3581
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.10.0
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-3581.1.patch.txt
>
>
> This was introduced when these functions were updated to use Jackson.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira