[jira] [Commented] (FLUME-2997) Fix flaky junit test in SpillableMemoryChannel

["Bessenyei Balázs Donát (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLUME-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571828#comment-15571828 ] 

Bessenyei Balázs Donát commented on FLUME-2997:
-----------------------------------------------

[~sati]: thank you for the patch!

Can you please explain why you think it's better to remove the System.out.println-s we had in the test?

> Fix flaky junit test in SpillableMemoryChannel
> ----------------------------------------------
>
>                 Key: FLUME-2997
>                 URL: https://issues.apache.org/jira/browse/FLUME-2997
>             Project: Flume
>          Issue Type: Test
>    Affects Versions: v1.7.0
>            Reporter: Attila Simon
>            Assignee: Attila Simon
>             Fix For: v1.8.0
>
>         Attachments: FLUME-2997-1.patch, FLUME-2997.patch
>
>
> testParallelSingleSourceAndSink sometimes trigger an edge case scenario if sinks are slower than sources. In such situations the channel can get full thus uncaught ChannelFullException breaks the test. Since testCapacityWithOverflow was designed to cover such edge-case scenario already we can safely fix the test by increasing the channel capacity to make sure it won't get full.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)