[GitHub] [doris] morrySnow commented on a diff in pull request #10647: [feature](planner): push sort to olapscan.

[GitBox <gi...@apache.org>]

morrySnow commented on code in PR #10647:
URL: https://github.com/apache/doris/pull/10647#discussion_r914581350


##########
fe/fe-core/src/main/java/org/apache/doris/planner/OlapScanNode.java:
##########
@@ -693,6 +708,37 @@ private void computeTabletInfo() throws UserException {
         }
     }
 
+    /**
+     * Check Parent sort node can push down to child olap scan.

Review Comment:
   add more comment to explain why use prefix matching



##########
fe/fe-core/src/main/java/org/apache/doris/planner/OriginalPlanner.java:
##########
@@ -197,6 +197,28 @@ public void createPlanFragments(StatementBase statement, Analyzer analyzer, TQue
             fragments = distributedPlanner.createPlanFragments(singleNodePlan);
         }
 
+        // Push sort node down to the bottom of olapscan.
+        for (PlanFragment fragment : fragments) {
+            if (fragment.getPlanRoot() instanceof SortNode) {

Review Comment:
   we need to find a pattern sort(scan), so should use recursive way to do that



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org