You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/03/30 03:51:53 UTC

[GitHub] [iotdb] xingtanzjr opened a new pull request #5376: [IoTDB-2661] Add PlanNode visualizer tool

xingtanzjr opened a new pull request #5376:
URL: https://github.com/apache/iotdb/pull/5376


   ## Description
   * Add a tool to visualize the PlanNode in Box Chart. See the snapshot below
     <img width="976" alt="image" src="https://user-images.githubusercontent.com/18027703/160747896-34dd6110-5d6a-41e8-8d04-26614f6d8955.png">
   
   * Cleanup some temporary code for presentation on 03/29
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] JackieTien97 commented on a change in pull request #5376: [IoTDB-2661] Add PlanNode visualizer tool

Posted by GitBox <gi...@apache.org>.
JackieTien97 commented on a change in pull request #5376:
URL: https://github.com/apache/iotdb/pull/5376#discussion_r839082087



##########
File path: server/src/main/java/org/apache/iotdb/db/mpp/sql/planner/plan/node/PlanNode.java
##########
@@ -77,4 +82,8 @@ private int getChildrenCount(List<PlanNode> children) {
   }
 
   public abstract void serialize(ByteBuffer byteBuffer);
+
+  public List<String> getBoxString() {
+    return ImmutableList.of(String.format("PlanNode-%s", getId()));

Review comment:
       Better to make it an abstract method, otherwise other PlanNodes will get compile errors if they don't override this method. In this way we can let new PlanNode coders won't remember this `getBoxingString()`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] xingtanzjr commented on a change in pull request #5376: [IoTDB-2661] Add PlanNode visualizer tool

Posted by GitBox <gi...@apache.org>.
xingtanzjr commented on a change in pull request #5376:
URL: https://github.com/apache/iotdb/pull/5376#discussion_r839350758



##########
File path: server/src/main/java/org/apache/iotdb/db/mpp/sql/planner/plan/node/PlanNode.java
##########
@@ -77,4 +82,8 @@ private int getChildrenCount(List<PlanNode> children) {
   }
 
   public abstract void serialize(ByteBuffer byteBuffer);
+
+  public List<String> getBoxString() {
+    return ImmutableList.of(String.format("PlanNode-%s", getId()));

Review comment:
       Sure. Making it as a `non-abstarct` method is only used to unblock the compiling during the presentation. 😂




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #5376: [IoTDB-2661] Add PlanNode visualizer tool

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #5376:
URL: https://github.com/apache/iotdb/pull/5376#issuecomment-1083228204


   SonarCloud Quality Gate failed.&nbsp; &nbsp; [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb&pullRequest=5376)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5376&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5376&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5376&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5376&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5376&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5376&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=5376&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=5376&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=5376&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5376&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5376&resolved=false&types=CODE_SMELL) [23 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5376&resolved=false&types=CODE_SMELL)
   
   [![1.6%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '1.6%')](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=5376&metric=new_coverage&view=list) [1.6% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=5376&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=5376&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=5376&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] xingtanzjr commented on a change in pull request #5376: [IoTDB-2661] Add PlanNode visualizer tool

Posted by GitBox <gi...@apache.org>.
xingtanzjr commented on a change in pull request #5376:
URL: https://github.com/apache/iotdb/pull/5376#discussion_r839350758



##########
File path: server/src/main/java/org/apache/iotdb/db/mpp/sql/planner/plan/node/PlanNode.java
##########
@@ -77,4 +82,8 @@ private int getChildrenCount(List<PlanNode> children) {
   }
 
   public abstract void serialize(ByteBuffer byteBuffer);
+
+  public List<String> getBoxString() {
+    return ImmutableList.of(String.format("PlanNode-%s", getId()));

Review comment:
       Sure. Making it as a `non-abstract` method is only used to unblock the compiling during the presentation. 😂




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org