You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "adietrich-ussignal (via GitHub)" <gi...@apache.org> on 2024/08/02 16:06:36 UTC
[I] Improve "Delete Account" pop-up verbiage [cloudstack]
adietrich-ussignal opened a new issue, #9480:
URL: https://github.com/apache/cloudstack/issues/9480
<!--
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release and main branch are affected too.
Always add information AFTER of these HTML comments, but no need to delete the comments.
-->
##### ISSUE TYPE
<!-- Pick one below and delete the rest -->
* Improvement Request
##### COMPONENT NAME
<!--
Categorize the issue, e.g. API, VR, VPN, UI, etc.
-->
~~~
UI
~~~
##### CLOUDSTACK VERSION
<!--
New line separated list of affected versions, commit ID for issues on main branch.
-->
~~~
4.19.0.2
~~~
##### CONFIGURATION
<!--
Information about the configuration if relevant, e.g. basic network, advanced networking, etc. N/A otherwise
-->
N/A
##### OS / ENVIRONMENT
<!--
Information about the environment if relevant, N/A otherwise
-->
N/A
##### SUMMARY
<!-- Explain the problem/feature briefly -->
When deleting an account, the only information provided at the pop-up window to delete an account is "Please confirm that you want to delete this Account." While the documentation is clear on what occurs when an account is deleted, I think providing some of the key aspects of what is removed or an additional prompt such as "Type the name of the account to delete it" would be valuable to avoid removing instances or snapshots unintentionally.
##### STEPS TO REPRODUCE
<!--
For bugs, show exactly how to reproduce the problem, using a minimal test-case. Use Screenshots if accurate.
For new features, show how the feature would be used.
-->
<!-- Paste example playbooks or commands between quotes below -->
~~~
1. In the UI, navigate to Accounts
2. Select an Account.
3. Select Delete Account.
4. Observe focused prompt.
~~~
<!-- You can also paste gist.github.com links for larger files -->
##### EXPECTED RESULTS
<!-- What did you expect to happen when running the steps above? -->
~~~
Additional text in the pop-up similar to:
"Note: Removal of an Account destroys instances owned by this account."
~~~
##### ACTUAL RESULTS
<!-- What actually happened? -->
<!-- Paste verbatim command output between quotes below -->
~~~
The output below is displayed.
~~~
<img width="519" alt="Screenshot 2024-08-02 at 11 57 58 AM" src="https://github.com/user-attachments/assets/5131f243-a7ba-4b63-b9ed-fbb74324a018">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Improve "Delete Account" pop-up verbiage [cloudstack]
Posted by "abh1sar (via GitHub)" <gi...@apache.org>.
abh1sar commented on issue #9480:
URL: https://github.com/apache/cloudstack/issues/9480#issuecomment-2602398251
Also being discussed here https://github.com/apache/cloudstack/discussions/10128
Suggested fix :
1. Account has to be disabled first for it to be deleted (Disabling actually shuts down all the VMs).
2. Improve the warning message to say that all VMs, volumes and data associated with the account will be deleted.
3. Additional prompt to type the name of the account to confirm account deletion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Improve "Delete Account" pop-up verbiage [cloudstack]
Posted by "Imvedansh (via GitHub)" <gi...@apache.org>.
Imvedansh commented on issue #9480:
URL: https://github.com/apache/cloudstack/issues/9480#issuecomment-2804616863
@abh1sar Yeah, I wanted to work on both myself,
Sure , will make sure changes are limited to UI and doesnt break ,
I ll take care of both #9904 & #9480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Improve "Delete Account" pop-up verbiage [cloudstack]
Posted by "abh1sar (via GitHub)" <gi...@apache.org>.
abh1sar commented on issue #9480:
URL: https://github.com/apache/cloudstack/issues/9480#issuecomment-2606295386
@weizhouapache
This is mostly UI change.
Only check added is that account should be disabled before deleting, which I think is similar to other infrastructure resources.
Please advice on https://github.com/apache/cloudstack/pull/10232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Improve "Delete Account" pop-up verbiage [cloudstack]
Posted by "Imvedansh (via GitHub)" <gi...@apache.org>.
Imvedansh commented on issue #9480:
URL: https://github.com/apache/cloudstack/issues/9480#issuecomment-2792382378
Hi @abh1sar ,
It seems that PR #10232 provides a partial solution . However, the original feature request—enhancing the confirmation dialog with clearer messaging and possibly an input-based confirmation—still appears to be open.
I also noticed that #10232 was closed without merging. Could you please confirm if this issue is still open for contribution and if I can proceed with completing the remaining UI/UX improvements?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Improve "Delete Account" pop-up verbiage [cloudstack]
Posted by "abh1sar (via GitHub)" <gi...@apache.org>.
abh1sar commented on issue #9480:
URL: https://github.com/apache/cloudstack/issues/9480#issuecomment-2800778707
@Imvedansh
I didn't get time to work on it. Please feel free to provide a fix for both Issues #9904 and https://github.com/apache/cloudstack/issues/9480.
I'll close my PR #10242
Please do keep in mind that some admins use the ability to do group action delete on accounts (mostly in test environments for cleaning up).
Also if any changes are done in CLI in the behaviour of delete accounts (like enforcing them to be disabled first) might break things with orchestrators like terraform. Any UI changes are fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Improve "Delete Account" pop-up verbiage [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on issue #9480:
URL: https://github.com/apache/cloudstack/issues/9480#issuecomment-2603882270
another option is similar as deleteproject
https://github.com/apache/cloudstack/blob/1c626c884c6e4de988f3a42c5d38b0ca41dc91dd/api/src/main/java/org/apache/cloudstack/api/command/user/project/DeleteProjectCmd.java#L48-L49
please bear in mind, if we change the default behavior, other 3rd-party projects (e.g. terraform) might be impacted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org