You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Wade Simmons (JIRA)" <ji...@apache.org> on 2011/01/07 20:35:46 UTC
[jira] Created: (THRIFT-1033) Node.js language target
Node.js language target
-----------------------
Key: THRIFT-1033
URL: https://issues.apache.org/jira/browse/THRIFT-1033
Project: Thrift
Issue Type: New Feature
Reporter: Wade Simmons
Attachments: thrift_nodejs.patch
This patch allows you to pass an option to the JavaScript compiler to make it compile sources that work with Node.JS
thrift --gen js:node ...
If you prefer, you can browse the individual patches on my github repo:
https://github.com/wadey/thrift/compare/trunk...nodejs-compiler-trunk
The Node.JS client is available here (wasn't sure if I should add it in this patch to the lib/ folder):
https://github.com/wadey/node-thrift
Here is a client and server example:
https://github.com/wadey/node-thrift/tree/master/examples
My company, SimpleGeo, has been using this code in production for multiple months and we haven't run into any major bugs that haven't already been fixed. I've also been chatting with someone who found the code on github and is using this code to talk with PHP (PHP Thrift client -> Node.JS Thrift server).
Let me know if you have any questions or concerns! I would love to see this make it in to 0.6; hopefully I am not too late for that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (THRIFT-1033) Node.js language target
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani reassigned THRIFT-1033:
--------------------------------------
Assignee: T Jake Luciani
> Node.js language target
> -----------------------
>
> Key: THRIFT-1033
> URL: https://issues.apache.org/jira/browse/THRIFT-1033
> Project: Thrift
> Issue Type: New Feature
> Components: JavaScript - Compiler, JavaScript - Library
> Affects Versions: 0.6
> Reporter: Wade Simmons
> Assignee: T Jake Luciani
> Fix For: 0.6
>
> Attachments: thrift_nodejs.patch, thrift_nodejs_lib.patch
>
>
> This patch allows you to pass an option to the JavaScript compiler to make it compile sources that work with Node.JS
> thrift --gen js:node ...
> If you prefer, you can browse the individual patches on my github repo:
> https://github.com/wadey/thrift/compare/trunk...nodejs-compiler-trunk
> The Node.JS client is available here (wasn't sure if I should add it in this patch to the lib/ folder):
> https://github.com/wadey/node-thrift
> Here is a client and server example:
> https://github.com/wadey/node-thrift/tree/master/examples
> My company, SimpleGeo, has been using this code in production for multiple months and we haven't run into any major bugs that haven't already been fixed. I've also been chatting with someone who found the code on github and is using this code to talk with PHP (PHP Thrift client -> Node.JS Thrift server).
> Let me know if you have any questions or concerns! I would love to see this make it in to 0.6; hopefully I am not too late for that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-1033) Node.js language target
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984024#action_12984024 ]
Bryan Duxbury commented on THRIFT-1033:
---------------------------------------
Wade - new tickets would be great.
> Node.js language target
> -----------------------
>
> Key: THRIFT-1033
> URL: https://issues.apache.org/jira/browse/THRIFT-1033
> Project: Thrift
> Issue Type: New Feature
> Components: JavaScript - Compiler, JavaScript - Library
> Affects Versions: 0.6
> Reporter: Wade Simmons
> Assignee: T Jake Luciani
> Fix For: 0.6
>
> Attachments: thrift_nodejs.patch, thrift_nodejs_lib.patch
>
>
> This patch allows you to pass an option to the JavaScript compiler to make it compile sources that work with Node.JS
> thrift --gen js:node ...
> If you prefer, you can browse the individual patches on my github repo:
> https://github.com/wadey/thrift/compare/trunk...nodejs-compiler-trunk
> The Node.JS client is available here (wasn't sure if I should add it in this patch to the lib/ folder):
> https://github.com/wadey/node-thrift
> Here is a client and server example:
> https://github.com/wadey/node-thrift/tree/master/examples
> My company, SimpleGeo, has been using this code in production for multiple months and we haven't run into any major bugs that haven't already been fixed. I've also been chatting with someone who found the code on github and is using this code to talk with PHP (PHP Thrift client -> Node.JS Thrift server).
> Let me know if you have any questions or concerns! I would love to see this make it in to 0.6; hopefully I am not too late for that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (THRIFT-1033) Node.js language target
Posted by "Wade Simmons (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984017#action_12984017 ]
Wade Simmons edited comment on THRIFT-1033 at 1/19/11 11:08 PM:
----------------------------------------------------------------
I found a few bugs with serializing maps and inheritance (when a service extends another service). Should I submit these patches as new JIRA tickets?
was (Author: wadey):
I found a few bugs with serializing maps and inheritance (when a server extends another service). Should I submit these patches as new JIRA tickets?
> Node.js language target
> -----------------------
>
> Key: THRIFT-1033
> URL: https://issues.apache.org/jira/browse/THRIFT-1033
> Project: Thrift
> Issue Type: New Feature
> Components: JavaScript - Compiler, JavaScript - Library
> Affects Versions: 0.6
> Reporter: Wade Simmons
> Assignee: T Jake Luciani
> Fix For: 0.6
>
> Attachments: thrift_nodejs.patch, thrift_nodejs_lib.patch
>
>
> This patch allows you to pass an option to the JavaScript compiler to make it compile sources that work with Node.JS
> thrift --gen js:node ...
> If you prefer, you can browse the individual patches on my github repo:
> https://github.com/wadey/thrift/compare/trunk...nodejs-compiler-trunk
> The Node.JS client is available here (wasn't sure if I should add it in this patch to the lib/ folder):
> https://github.com/wadey/node-thrift
> Here is a client and server example:
> https://github.com/wadey/node-thrift/tree/master/examples
> My company, SimpleGeo, has been using this code in production for multiple months and we haven't run into any major bugs that haven't already been fixed. I've also been chatting with someone who found the code on github and is using this code to talk with PHP (PHP Thrift client -> Node.JS Thrift server).
> Let me know if you have any questions or concerns! I would love to see this make it in to 0.6; hopefully I am not too late for that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-1033) Node.js language target
Posted by "Wade Simmons (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wade Simmons updated THRIFT-1033:
---------------------------------
Attachment: thrift_nodejs.patch
> Node.js language target
> -----------------------
>
> Key: THRIFT-1033
> URL: https://issues.apache.org/jira/browse/THRIFT-1033
> Project: Thrift
> Issue Type: New Feature
> Reporter: Wade Simmons
> Attachments: thrift_nodejs.patch
>
>
> This patch allows you to pass an option to the JavaScript compiler to make it compile sources that work with Node.JS
> thrift --gen js:node ...
> If you prefer, you can browse the individual patches on my github repo:
> https://github.com/wadey/thrift/compare/trunk...nodejs-compiler-trunk
> The Node.JS client is available here (wasn't sure if I should add it in this patch to the lib/ folder):
> https://github.com/wadey/node-thrift
> Here is a client and server example:
> https://github.com/wadey/node-thrift/tree/master/examples
> My company, SimpleGeo, has been using this code in production for multiple months and we haven't run into any major bugs that haven't already been fixed. I've also been chatting with someone who found the code on github and is using this code to talk with PHP (PHP Thrift client -> Node.JS Thrift server).
> Let me know if you have any questions or concerns! I would love to see this make it in to 0.6; hopefully I am not too late for that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-1033) Node.js language target
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979082#action_12979082 ]
T Jake Luciani commented on THRIFT-1033:
----------------------------------------
Committed to truck with slight re-orgs to the example and added ASF headers
Thanks!
> Node.js language target
> -----------------------
>
> Key: THRIFT-1033
> URL: https://issues.apache.org/jira/browse/THRIFT-1033
> Project: Thrift
> Issue Type: New Feature
> Reporter: Wade Simmons
> Attachments: thrift_nodejs.patch, thrift_nodejs_lib.patch
>
>
> This patch allows you to pass an option to the JavaScript compiler to make it compile sources that work with Node.JS
> thrift --gen js:node ...
> If you prefer, you can browse the individual patches on my github repo:
> https://github.com/wadey/thrift/compare/trunk...nodejs-compiler-trunk
> The Node.JS client is available here (wasn't sure if I should add it in this patch to the lib/ folder):
> https://github.com/wadey/node-thrift
> Here is a client and server example:
> https://github.com/wadey/node-thrift/tree/master/examples
> My company, SimpleGeo, has been using this code in production for multiple months and we haven't run into any major bugs that haven't already been fixed. I've also been chatting with someone who found the code on github and is using this code to talk with PHP (PHP Thrift client -> Node.JS Thrift server).
> Let me know if you have any questions or concerns! I would love to see this make it in to 0.6; hopefully I am not too late for that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-1033) Node.js language target
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani updated THRIFT-1033:
-----------------------------------
Component/s: JavaScript - Library
JavaScript - Compiler
Affects Version/s: 0.6
Fix Version/s: 0.6
> Node.js language target
> -----------------------
>
> Key: THRIFT-1033
> URL: https://issues.apache.org/jira/browse/THRIFT-1033
> Project: Thrift
> Issue Type: New Feature
> Components: JavaScript - Compiler, JavaScript - Library
> Affects Versions: 0.6
> Reporter: Wade Simmons
> Fix For: 0.6
>
> Attachments: thrift_nodejs.patch, thrift_nodejs_lib.patch
>
>
> This patch allows you to pass an option to the JavaScript compiler to make it compile sources that work with Node.JS
> thrift --gen js:node ...
> If you prefer, you can browse the individual patches on my github repo:
> https://github.com/wadey/thrift/compare/trunk...nodejs-compiler-trunk
> The Node.JS client is available here (wasn't sure if I should add it in this patch to the lib/ folder):
> https://github.com/wadey/node-thrift
> Here is a client and server example:
> https://github.com/wadey/node-thrift/tree/master/examples
> My company, SimpleGeo, has been using this code in production for multiple months and we haven't run into any major bugs that haven't already been fixed. I've also been chatting with someone who found the code on github and is using this code to talk with PHP (PHP Thrift client -> Node.JS Thrift server).
> Let me know if you have any questions or concerns! I would love to see this make it in to 0.6; hopefully I am not too late for that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-1033) Node.js language target
Posted by "Wade Simmons (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wade Simmons updated THRIFT-1033:
---------------------------------
Attachment: thrift_nodejs_lib.patch
Here is a patch the imports the node-thrift library into the lib/ folder. I changed the license to match Thrift's license and added a README to the examples folder
> Node.js language target
> -----------------------
>
> Key: THRIFT-1033
> URL: https://issues.apache.org/jira/browse/THRIFT-1033
> Project: Thrift
> Issue Type: New Feature
> Reporter: Wade Simmons
> Attachments: thrift_nodejs.patch, thrift_nodejs_lib.patch
>
>
> This patch allows you to pass an option to the JavaScript compiler to make it compile sources that work with Node.JS
> thrift --gen js:node ...
> If you prefer, you can browse the individual patches on my github repo:
> https://github.com/wadey/thrift/compare/trunk...nodejs-compiler-trunk
> The Node.JS client is available here (wasn't sure if I should add it in this patch to the lib/ folder):
> https://github.com/wadey/node-thrift
> Here is a client and server example:
> https://github.com/wadey/node-thrift/tree/master/examples
> My company, SimpleGeo, has been using this code in production for multiple months and we haven't run into any major bugs that haven't already been fixed. I've also been chatting with someone who found the code on github and is using this code to talk with PHP (PHP Thrift client -> Node.JS Thrift server).
> Let me know if you have any questions or concerns! I would love to see this make it in to 0.6; hopefully I am not too late for that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-1033) Node.js language target
Posted by "Wade Simmons (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984017#action_12984017 ]
Wade Simmons commented on THRIFT-1033:
--------------------------------------
I found a few bugs with serializing maps and inheritance (when a server extends another service). Should I submit these patches as new JIRA tickets?
> Node.js language target
> -----------------------
>
> Key: THRIFT-1033
> URL: https://issues.apache.org/jira/browse/THRIFT-1033
> Project: Thrift
> Issue Type: New Feature
> Components: JavaScript - Compiler, JavaScript - Library
> Affects Versions: 0.6
> Reporter: Wade Simmons
> Assignee: T Jake Luciani
> Fix For: 0.6
>
> Attachments: thrift_nodejs.patch, thrift_nodejs_lib.patch
>
>
> This patch allows you to pass an option to the JavaScript compiler to make it compile sources that work with Node.JS
> thrift --gen js:node ...
> If you prefer, you can browse the individual patches on my github repo:
> https://github.com/wadey/thrift/compare/trunk...nodejs-compiler-trunk
> The Node.JS client is available here (wasn't sure if I should add it in this patch to the lib/ folder):
> https://github.com/wadey/node-thrift
> Here is a client and server example:
> https://github.com/wadey/node-thrift/tree/master/examples
> My company, SimpleGeo, has been using this code in production for multiple months and we haven't run into any major bugs that haven't already been fixed. I've also been chatting with someone who found the code on github and is using this code to talk with PHP (PHP Thrift client -> Node.JS Thrift server).
> Let me know if you have any questions or concerns! I would love to see this make it in to 0.6; hopefully I am not too late for that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-1033) Node.js language target
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani resolved THRIFT-1033.
------------------------------------
Resolution: Fixed
> Node.js language target
> -----------------------
>
> Key: THRIFT-1033
> URL: https://issues.apache.org/jira/browse/THRIFT-1033
> Project: Thrift
> Issue Type: New Feature
> Components: JavaScript - Compiler, JavaScript - Library
> Affects Versions: 0.6
> Reporter: Wade Simmons
> Assignee: T Jake Luciani
> Fix For: 0.6
>
> Attachments: thrift_nodejs.patch, thrift_nodejs_lib.patch
>
>
> This patch allows you to pass an option to the JavaScript compiler to make it compile sources that work with Node.JS
> thrift --gen js:node ...
> If you prefer, you can browse the individual patches on my github repo:
> https://github.com/wadey/thrift/compare/trunk...nodejs-compiler-trunk
> The Node.JS client is available here (wasn't sure if I should add it in this patch to the lib/ folder):
> https://github.com/wadey/node-thrift
> Here is a client and server example:
> https://github.com/wadey/node-thrift/tree/master/examples
> My company, SimpleGeo, has been using this code in production for multiple months and we haven't run into any major bugs that haven't already been fixed. I've also been chatting with someone who found the code on github and is using this code to talk with PHP (PHP Thrift client -> Node.JS Thrift server).
> Let me know if you have any questions or concerns! I would love to see this make it in to 0.6; hopefully I am not too late for that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-1033) Node.js language target
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978942#action_12978942 ]
T Jake Luciani commented on THRIFT-1033:
----------------------------------------
First, thanks for this great work!
I think you should be contributing the whole of the project as in the /lib stuff for this to be useful.
Also, the tests and examples should go in there too.
I'm not a node users so I'm not sure what is needed to run your example but some instructions in a README would be helpful.
> Node.js language target
> -----------------------
>
> Key: THRIFT-1033
> URL: https://issues.apache.org/jira/browse/THRIFT-1033
> Project: Thrift
> Issue Type: New Feature
> Reporter: Wade Simmons
> Attachments: thrift_nodejs.patch
>
>
> This patch allows you to pass an option to the JavaScript compiler to make it compile sources that work with Node.JS
> thrift --gen js:node ...
> If you prefer, you can browse the individual patches on my github repo:
> https://github.com/wadey/thrift/compare/trunk...nodejs-compiler-trunk
> The Node.JS client is available here (wasn't sure if I should add it in this patch to the lib/ folder):
> https://github.com/wadey/node-thrift
> Here is a client and server example:
> https://github.com/wadey/node-thrift/tree/master/examples
> My company, SimpleGeo, has been using this code in production for multiple months and we haven't run into any major bugs that haven't already been fixed. I've also been chatting with someone who found the code on github and is using this code to talk with PHP (PHP Thrift client -> Node.JS Thrift server).
> Let me know if you have any questions or concerns! I would love to see this make it in to 0.6; hopefully I am not too late for that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.