You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/05/11 15:02:45 UTC

[GitHub] [incubator-kvrocks] yancz2000 opened a new pull request, #571: Fix make uninstall file deletion path

yancz2000 opened a new pull request, #571:
URL: https://github.com/apache/incubator-kvrocks/pull/571

   make uninstall did not remove the binaries.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] git-hulk commented on pull request #571: Fix make uninstall file deletion path

Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #571:
URL: https://github.com/apache/incubator-kvrocks/pull/571#issuecomment-1123917223

   Thanks @yancz2000. As mentioned in https://github.com/apache/incubator-kvrocks/pull/564#issuecomment-1121972637, we're planning to remove the Makefile to keep the build system unify and easy to maintain. @PragmaTwice will help to create a new issue to track this change later, welcome to discuss in that thread if you have any thoughts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] yancz2000 commented on pull request #571: Fix make uninstall file deletion path

Posted by GitBox <gi...@apache.org>.
yancz2000 commented on PR #571:
URL: https://github.com/apache/incubator-kvrocks/pull/571#issuecomment-1123972940

   Thanks for the timely review, I will put forward any ideas in time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org