You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kevin Klues <kl...@gmail.com> on 2016/11/29 06:49:26 UTC
Re: Review Request 53974: Added support to handle
ATTACH_CONTAINER_OUPUT in the io switchbaord.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53974/
-----------------------------------------------------------
(Updated Nov. 29, 2016, 6:49 a.m.)
Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
Changes
-------
Rebase on newest changes.
Bugs: MESOS-6467
https://issues.apache.org/jira/browse/MESOS-6467
Repository: mesos
Description
-------
Added support to handle ATTACH_CONTAINER_OUPUT in the io switchbaord.
Diffs (updated)
-----
src/slave/containerizer/mesos/io/switchboard.cpp 25cbf2447d197134f0753b062b6f4130821005b2
Diff: https://reviews.apache.org/r/53974/diff/
Testing
-------
GTEST_FILTER="" make -j check
sudo src/mesos-tests
Thanks,
Kevin Klues
Re: Review Request 53974: Added support to handle
ATTACH_CONTAINER_OUPUT in the io switchbaord.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53974/#review157498
-----------------------------------------------------------
src/slave/containerizer/mesos/io/switchboard.cpp (line 509)
<https://reviews.apache.org/r/53974/#comment228101>
This can be Option<Failure> failure.
src/slave/containerizer/mesos/io/switchboard.cpp (lines 654 - 663)
<https://reviews.apache.org/r/53974/#comment228124>
we should handle onDiscarded as well
src/slave/containerizer/mesos/io/switchboard.cpp (line 655)
<https://reviews.apache.org/r/53974/#comment228102>
`failure = Failure("Failed ...");`
src/slave/containerizer/mesos/io/switchboard.cpp (line 656)
<https://reviews.apache.org/r/53974/#comment228103>
Can you add some notes about why 'false' is used here?
src/slave/containerizer/mesos/io/switchboard.cpp (line 680)
<https://reviews.apache.org/r/53974/#comment228104>
`{` on the next line.
src/slave/containerizer/mesos/io/switchboard.cpp (line 739)
<https://reviews.apache.org/r/53974/#comment228105>
kill this line?
src/slave/containerizer/mesos/io/switchboard.cpp (line 746)
<https://reviews.apache.org/r/53974/#comment228106>
kill this line
src/slave/containerizer/mesos/io/switchboard.cpp (line 787)
<https://reviews.apache.org/r/53974/#comment228113>
const?
src/slave/containerizer/mesos/io/switchboard.cpp (line 796)
<https://reviews.apache.org/r/53974/#comment228112>
why not const?
src/slave/containerizer/mesos/io/switchboard.cpp (line 825)
<https://reviews.apache.org/r/53974/#comment228117>
iterator might be invalidated after insertion or erase. So I don't think this works.
src/tests/containerizer/io_switchboard_tests.cpp (line 204)
<https://reviews.apache.org/r/53974/#comment228129>
Is there constant for this?
- Jie Yu
On Nov. 30, 2016, 10:26 p.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53974/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2016, 10:26 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-6467
> https://issues.apache.org/jira/browse/MESOS-6467
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added support to handle ATTACH_CONTAINER_OUPUT in the io switchbaord.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/io/switchboard.hpp aaa3a35245b291f6003f519dbf8c0e1b82bc15fd
> src/slave/containerizer/mesos/io/switchboard.cpp 25cbf2447d197134f0753b062b6f4130821005b2
> src/slave/containerizer/mesos/io/switchboard_main.cpp PRE-CREATION
> src/tests/containerizer/io_switchboard_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53974/diff/
>
>
> Testing
> -------
>
> GTEST_FILTER="" make -j check
> sudo src/mesos-tests
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 53974: Added support to handle
ATTACH_CONTAINER_OUPUT in the io switchbaord.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53974/
-----------------------------------------------------------
(Updated Dec. 1, 2016, 1:32 a.m.)
Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
Changes
-------
Updated based on Jie's comments.
Bugs: MESOS-6467
https://issues.apache.org/jira/browse/MESOS-6467
Repository: mesos
Description
-------
Added support to handle ATTACH_CONTAINER_OUPUT in the io switchbaord.
Diffs (updated)
-----
src/slave/containerizer/mesos/io/switchboard.hpp d3ab52d98ade067ccec63f3539073c152840099f
src/slave/containerizer/mesos/io/switchboard.cpp ae7a1fe3e24d5dc18269d9da951493700ee957d0
src/slave/containerizer/mesos/io/switchboard_main.cpp PRE-CREATION
src/tests/containerizer/io_switchboard_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/53974/diff/
Testing
-------
GTEST_FILTER="" make -j check
sudo src/mesos-tests
Thanks,
Kevin Klues
Re: Review Request 53974: Added support to handle
ATTACH_CONTAINER_OUPUT in the io switchbaord.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53974/
-----------------------------------------------------------
(Updated Nov. 30, 2016, 10:26 p.m.)
Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
Changes
-------
Updated based on changes to previous patches.
Bugs: MESOS-6467
https://issues.apache.org/jira/browse/MESOS-6467
Repository: mesos
Description
-------
Added support to handle ATTACH_CONTAINER_OUPUT in the io switchbaord.
Diffs (updated)
-----
src/slave/containerizer/mesos/io/switchboard.hpp aaa3a35245b291f6003f519dbf8c0e1b82bc15fd
src/slave/containerizer/mesos/io/switchboard.cpp 25cbf2447d197134f0753b062b6f4130821005b2
src/slave/containerizer/mesos/io/switchboard_main.cpp PRE-CREATION
src/tests/containerizer/io_switchboard_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/53974/diff/
Testing
-------
GTEST_FILTER="" make -j check
sudo src/mesos-tests
Thanks,
Kevin Klues
Re: Review Request 53974: Added support to handle
ATTACH_CONTAINER_OUPUT in the io switchbaord.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53974/
-----------------------------------------------------------
(Updated Nov. 30, 2016, 9:36 p.m.)
Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
Changes
-------
Rebased on changes to previous patches.
Bugs: MESOS-6467
https://issues.apache.org/jira/browse/MESOS-6467
Repository: mesos
Description
-------
Added support to handle ATTACH_CONTAINER_OUPUT in the io switchbaord.
Diffs (updated)
-----
src/slave/containerizer/mesos/io/switchboard.hpp aaa3a35245b291f6003f519dbf8c0e1b82bc15fd
src/slave/containerizer/mesos/io/switchboard.cpp 25cbf2447d197134f0753b062b6f4130821005b2
src/slave/containerizer/mesos/io/switchboard_main.cpp PRE-CREATION
src/tests/containerizer/io_switchboard_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/53974/diff/
Testing
-------
GTEST_FILTER="" make -j check
sudo src/mesos-tests
Thanks,
Kevin Klues
Re: Review Request 53974: Added support to handle
ATTACH_CONTAINER_OUPUT in the io switchbaord.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53974/
-----------------------------------------------------------
(Updated Nov. 30, 2016, 6:56 p.m.)
Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
Changes
-------
Rebased on master.
Bugs: MESOS-6467
https://issues.apache.org/jira/browse/MESOS-6467
Repository: mesos
Description
-------
Added support to handle ATTACH_CONTAINER_OUPUT in the io switchbaord.
Diffs (updated)
-----
src/slave/containerizer/mesos/io/switchboard.hpp aaa3a35245b291f6003f519dbf8c0e1b82bc15fd
src/slave/containerizer/mesos/io/switchboard.cpp 25cbf2447d197134f0753b062b6f4130821005b2
src/slave/containerizer/mesos/io/switchboard_main.cpp PRE-CREATION
src/tests/containerizer/io_switchboard_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/53974/diff/
Testing
-------
GTEST_FILTER="" make -j check
sudo src/mesos-tests
Thanks,
Kevin Klues
Re: Review Request 53974: Added support to handle
ATTACH_CONTAINER_OUPUT in the io switchbaord.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53974/
-----------------------------------------------------------
(Updated Nov. 30, 2016, 3:51 a.m.)
Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
Changes
-------
Rebased on previous patch changes. Also updated to add a new flag for waiting until the iurst connection comes before starting our redirect. Also updated to properly self terminate and close all connections when the server is ready to shutdown. We self terminate in a way that all outstanding messages in the event queue will be processed before we exit (thus ensuring we flush the IO to any open connections). Also added a test to make sure this all works.
Bugs: MESOS-6467
https://issues.apache.org/jira/browse/MESOS-6467
Repository: mesos
Description
-------
Added support to handle ATTACH_CONTAINER_OUPUT in the io switchbaord.
Diffs (updated)
-----
src/slave/containerizer/mesos/io/switchboard.hpp aaa3a35245b291f6003f519dbf8c0e1b82bc15fd
src/slave/containerizer/mesos/io/switchboard.cpp 25cbf2447d197134f0753b062b6f4130821005b2
src/slave/containerizer/mesos/io/switchboard_main.cpp PRE-CREATION
src/tests/containerizer/io_switchboard_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/53974/diff/
Testing
-------
GTEST_FILTER="" make -j check
sudo src/mesos-tests
Thanks,
Kevin Klues