You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "Aleksei-grovety (via GitHub)" <gi...@apache.org> on 2023/06/23 13:33:29 UTC
[GitHub] [tvm] Aleksei-grovety opened a new pull request, #15147: [microNPU][ETHOSU] Add option to disable copying constants for case without cascader
Aleksei-grovety opened a new pull request, #15147:
URL: https://github.com/apache/tvm/pull/15147
Added the option to disable copying constants for the case when the user determines in the linker script for section ".rodata.tvm" that the constants are located in SRAM.
cc @neildhickey, @lhutton1, @ekalda, @leandron
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 merged pull request #15147: [microNPU][ETHOSU] Add option to disable copying constants for case without cascader
Posted by "lhutton1 (via GitHub)" <gi...@apache.org>.
lhutton1 merged PR #15147:
URL: https://github.com/apache/tvm/pull/15147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #15147: [microNPU][ETHOSU] Add option to disable copying constants for case without cascader
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #15147:
URL: https://github.com/apache/tvm/pull/15147#issuecomment-1604293922
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @Mousius, @leandron <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Aleksei-grovety commented on a diff in pull request #15147: [microNPU][ETHOSU] Add option to disable copying constants for case without cascader
Posted by "Aleksei-grovety (via GitHub)" <gi...@apache.org>.
Aleksei-grovety commented on code in PR #15147:
URL: https://github.com/apache/tvm/pull/15147#discussion_r1243218041
##########
src/relay/backend/contrib/ethosu/compiler_attrs.cc:
##########
@@ -59,6 +60,9 @@ struct EthosUCompilerConfigNode : public tvm::AttrsNode<EthosUCompilerConfigNode
TVM_ATTR_FIELD(enable_cascader)
.describe("Whether the cascader should be enabled")
.set_default(false);
+ TVM_ATTR_FIELD(disable_copying_constants)
+ .describe("Whether copying constants is disabled for case without cascader")
Review Comment:
Yes, sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 commented on a diff in pull request #15147: [microNPU][ETHOSU] Add option to disable copying constants for case without cascader
Posted by "lhutton1 (via GitHub)" <gi...@apache.org>.
lhutton1 commented on code in PR #15147:
URL: https://github.com/apache/tvm/pull/15147#discussion_r1242287897
##########
src/relay/backend/contrib/ethosu/compiler_attrs.cc:
##########
@@ -59,6 +60,9 @@ struct EthosUCompilerConfigNode : public tvm::AttrsNode<EthosUCompilerConfigNode
TVM_ATTR_FIELD(enable_cascader)
.describe("Whether the cascader should be enabled")
.set_default(false);
+ TVM_ATTR_FIELD(disable_copying_constants)
+ .describe("Whether copying constants is disabled for case without cascader")
Review Comment:
Perhaps it's worth mentioning here that constants are expected to be in SRAM when this option is enabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org