You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2012/05/30 21:08:24 UTC

[jira] [Commented] (ZOOKEEPER-1445) Add support for binary data for zktreeutil

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285925#comment-13285925 ] 

Hadoop QA commented on ZOOKEEPER-1445:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12530248/ZOOKEEPER-1445.patch
  against trunk revision 1337029.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1084//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1084//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1084//console

This message is automatically generated.
                
> Add support for binary data for zktreeutil
> ------------------------------------------
>
>                 Key: ZOOKEEPER-1445
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1445
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: contrib
>    Affects Versions: 3.4.3
>            Reporter: Thawan Kooburat
>            Assignee: Thawan Kooburat
>         Attachments: ZOOKEEPER-1445.patch, ZOOKEEPER-1445.patch
>
>
> zktreeutil does not support binary data. The program will fail to import/export znode's data which are in binary format. We are going to use OpenSSL library to perform Base64 encoding so that we can store it XML format. OpenSSL seems to be the only widely available library which as support for Base64 encoding and decoding. Libxml2 only have encoding support. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira