[jira] [Commented] (VCL-1006) performance improvements for 2.5

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/VCL-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15773554#comment-15773554 ] 

ASF subversion and git services commented on VCL-1006:
------------------------------------------------------

Commit 1775892 from [~jfthomps] in branch 'vcl/trunk'
[ https://svn.apache.org/r1775892 ]

VCL-1006 - performance improvements for 2.5

made efforts to convert calls to in_array to use isset because it is notably faster - this required changing data so that rather than being an array of values, the data is an associative array with the keys being the needed information and the values just being set to 1

privileges.php:
-modified getNodePrivileges: modified returned data so that the arrays of privileges at each node are associative arrays with the key being the desired information and the value just being 1 for each key
-modified getNodeCascadePrivileges: modified returned data so that the arrays of privileges at each node are associative arrays with the key being the desired information and the value just being 1 for each key; for users and usergroups, moved queries outside of while loops and created static variables to hold all of the information so that it only had to be retrieved once per page load to decrease the time being spent performing queries
-modified printUserPrivRow, getUserPrivRowHTML, getResourcePrivRowHTML, AJchangeUserPrivs, AJchangeUserGroupPrivs, AJchangeResourcePrivs, AJsubmitAddUserPriv, AJsubmitAddUserGroupPriv, AJsubmitAddResourcePriv, and checkUserHasPriv: changed calls to in_array to check for user/usergroup permissions to call isset

utils.php:
-modified initGlobals: check for QUERYLOGGING not being defined and set it to 1 if it is not - did this so doQuery does not need to check if it is defined since that function is called so much
-modified doQuery: removed check for QUERYLOGGING being defined
-modified getUserResources and addNodeUserResourcePrivs: changed to check user privileges to use isset instead of in_array
-modified encryptData and decryptData: use openssl_encrypt and openssl_decrypt if they exist; fall back to Crypt_AES if they don't exist; openssl is notably faster
-modified getParentNodes: changed array_push($nodelist, $node) to $nodelist[] = $node

secrets-default.php:
-added $cryptiv
-changed comment for $cryptkey and set comment for $cryptiv to explain how to generate 16 random base64 encoded characters using openssl

> performance improvements for 2.5
> --------------------------------
>
>                 Key: VCL-1006
>                 URL: https://issues.apache.org/jira/browse/VCL-1006
>             Project: VCL
>          Issue Type: Improvement
>          Components: web gui (frontend)
>            Reporter: Josh Thompson
>             Fix For: 2.5
>
>
> This issue is to track performance improvements to the web code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)